fix(tagger): real leak root cause — handler params were shifted vs event inputs (caption_toggle got always-truthy lang_state), so NL caption ran unconditionally and the nl radio never checked the box; add AST regression guard

app.py

@@ -1859,7 +1859,7 @@ with gr.Blocks(**_blocks_kw) as demo:
     # Fold ensemble `mode` into the tagger call while keeping fmt semantics.
     # "nl" is a UI shortcut that enables the caption checkbox; the tagger
     # itself only runs the caption inside "ensemble" mode.
-    def on_tag_image_with_mode(image, gen_threshold, char_threshold, fmt, lang, mode, pose_toggle, caption_toggle, progress=gr.Progress()):
+    def on_tag_image_with_mode(image, gen_threshold, char_threshold, fmt, mode, pose_toggle, caption_toggle, lang, progress=gr.Progress()):
         mode_key = mode if isinstance(mode, str) and mode.startswith(
             ("wd:", "deepdanbooru", "ensemble")
         ) else "ensemble"
@@ -1898,12 +1898,12 @@ with gr.Blocks(**_blocks_kw) as demo:
     # inputs here: in Gradio 6, CheckboxGroup.preprocess validates the value
     # against the current choices and raises on stale selections, which
     # crashed re-runs ("Value: ... is not in the list of choices").
-    def on_tag_rerun(image, gen_threshold, char_threshold, fmt, lang, mode, pose_toggle, caption_toggle, progress=gr.Progress()):
+    def on_tag_rerun(image, gen_threshold, char_threshold, fmt, mode, pose_toggle, caption_toggle, lang, progress=gr.Progress()):
         with_caption = bool(caption_toggle) or mode == "nl"
         caption_update = gr.update(value=True) if mode == "nl" else gr.skip()
         if image is None:
             return (gr.skip(),) * 8 + (caption_update,)
-        return tuple(on_tag_image_with_mode(image, gen_threshold, char_threshold, fmt, lang, mode, pose_toggle, with_caption, progress=progress)) + (caption_update,)
+        return tuple(on_tag_image_with_mode(image, gen_threshold, char_threshold, fmt, mode, pose_toggle, with_caption, lang, progress=progress)) + (caption_update,)
 
     rerun_inputs = [
         tagger_image, tagger_gen_threshold, tagger_char_threshold, tagger_format,

tests/test_tagger_arg_alignment.py

@@ -0,0 +1,102 @@
+"""Regression guard: tagger handlers must be wired to their event inputs in
+exactly the same order as their parameters.
+
+A previous refactor shifted the parameter order of ``on_tag_image_with_mode``
+and ``on_tag_rerun`` relative to the Gradio ``inputs`` lists (lang/mode/pose/
+caption were offset by two), so the caption toggle silently received the
+always-truthy ``lang_state`` and the NL caption ran even with the checkbox
+off, while the "nl" radio item never checked the box.
+"""
+import ast
+import os
+
+import pytest
+
+_ROOT = os.path.dirname(os.path.dirname(os.path.abspath(__file__)))
+_APP = os.path.join(_ROOT, "app.py")
+
+_HANDLERS = {
+    "on_tag_image_with_mode": {
+        "events": ["tagger_btn.click"],
+        "params": [
+            ("image", "tagger_image"),
+            ("gen_threshold", "tagger_gen_threshold"),
+            ("char_threshold", "tagger_char_threshold"),
+            ("fmt", "tagger_format"),
+            ("mode", "tagger_mode"),
+            ("pose_toggle", "tagger_pose_toggle"),
+            ("caption_toggle", "tagger_caption_toggle"),
+            ("lang", "lang_state"),
+        ],
+    },
+    "on_tag_rerun": {
+        "events": ["tagger_mode.change", "tagger_pose_toggle.change"],
+        "params": [
+            ("image", "tagger_image"),
+            ("gen_threshold", "tagger_gen_threshold"),
+            ("char_threshold", "tagger_char_threshold"),
+            ("fmt", "tagger_format"),
+            ("mode", "tagger_mode"),
+            ("pose_toggle", "tagger_pose_toggle"),
+            ("caption_toggle", "tagger_caption_toggle"),
+            ("lang", "lang_state"),
+        ],
+    },
+}
+
+
+def _component_name(expr):
+    if isinstance(expr, ast.Name):
+        return expr.id
+    if isinstance(expr, ast.Attribute):
+        return expr.attr
+    return ast.unparse(expr)
+
+
+def _resolve_inputs(call, tree):
+    for kw in call.keywords:
+        if kw.arg != "inputs":
+            continue
+        value = kw.value
+        if isinstance(value, ast.List):
+            return [_component_name(elt) for elt in value.elts]
+        if isinstance(value, ast.Name):
+            for node in ast.walk(tree):
+                if isinstance(node, ast.Assign):
+                    for target in node.targets:
+                        if isinstance(target, ast.Name) and target.id == value.id:
+                            if isinstance(node.value, ast.List):
+                                return [_component_name(elt) for elt in node.value.elts]
+    return None
+
+
+def _handler_wiring():
+    with open(_APP, encoding="utf-8") as fh:
+        tree = ast.parse(fh.read())
+    expected_events = {e for h in _HANDLERS.values() for e in h["events"]}
+    wiring = {}
+    for node in ast.walk(tree):
+        if not isinstance(node, ast.Call) or not isinstance(node.func, ast.Attribute):
+            continue
+        if not isinstance(node.func.value, ast.Name):
+            continue
+        event = f"{node.func.value.id}.{node.func.attr}"
+        if event not in expected_events:
+            continue
+        fn_kw = next((kw for kw in node.keywords if kw.arg == "fn"), None)
+        if fn_kw is None or not isinstance(fn_kw.value, ast.Name):
+            continue
+        wiring.setdefault(fn_kw.value.id, []).append((event, _resolve_inputs(node, tree)))
+    return wiring
+
+
+@pytest.mark.parametrize("handler", sorted(_HANDLERS))
+def test_handler_inputs_match_signature(handler):
+    wiring = _handler_wiring()
+    assert handler in wiring, f"{handler} is not wired to any expected event"
+    expected = [comp for _, comp in _HANDLERS[handler]["params"]]
+    for event, inputs in wiring[handler]:
+        assert inputs is not None, f"{event} has no resolvable inputs list"
+        assert inputs == expected, (
+            f"{event} inputs {inputs} do not match {handler} parameters {expected}"
+        )