repo stringclasses 1
value | number int64 1 25.3k | state stringclasses 2
values | title stringlengths 1 487 | body stringlengths 0 234k ⌀ | created_at stringlengths 19 19 | closed_at stringlengths 19 19 | comments stringlengths 0 293k |
|---|---|---|---|---|---|---|---|
transformers | 25,105 | closed | fix get_keys_to_not_convert() to return correct modules for full precision inference | # What does this PR do?
This PR fixes `get_keys_to_not_convert()` and returns the correct modules that should not be quantized for numerical stability reasons.
For GPT2 and bloom, both the current(1st output) and new version(2nd output) work well.
GPT2
```
>>> filtered_module_names_old is ['transformer.wte', 'l... | 07-26-2023 07:26:45 | 07-26-2023 07:26:45 | _The documentation is not available anymore as the PR was closed or merged._<|||||>cc @younesbelkada for a first look<|||||>@younesbelkada Looks like that you have fixed this in #25047 two days ago. Great work. My bad for not using latest code.
<|||||>Alright. I am diving deeper into the code.
Could you try this c... |
transformers | 25,104 | open | Inconsistent Rotation Base for Dynamic NTK Scaling RoPE | ### System Info
- `transformers` version: 4.31.0
- Platform: Linux-5.19.0-42-generic-x86_64-with-glibc2.27
- Python version: 3.8.0
- PyTorch version (GPU?): 2.0.0+cu117 (True)
### Who can help?
@ArthurZucker @younesbelkada
### Information
- [X] The official example scripts
- [ ] My own modified scrip... | 07-26-2023 07:15:39 | 07-26-2023 07:15:39 | cc @ArthurZucker who works more on this (kind of) model(s).
However, @NormXU, could you provide a short but self-contained code snippet to demonstrate the `inconsistency` you mentioned? Thanks.<|||||>Sure
The inconsistency happens here:
https://github.com/huggingface/transformers/blob/a5cc30d72ae2dc19af534e4b3... |
transformers | 25,103 | open | Beam search genereation with len(eos_token_id) > 1 throws exceptions | ### System Info
- `transformers` version: 4.31.0
- Platform: Linux-5.13.0-1031-aws-x86_64-with-glibc2.31
- Python version: 3.10.5
- Huggingface_hub version: 0.16.4
- Safetensors version: 0.3.1
- Accelerate version: not installed
- Accelerate config: not found
- PyTorch version (GPU?): 2.0.1+cu117 (True)
- Te... | 07-26-2023 06:06:05 | 07-26-2023 06:06:05 | I think maybe the point of following line was to be sure there are enough tokens that are not eos:
[`generation/utils.py:2976`](https://github.com/huggingface/transformers/blame/main/src/transformers/generation/utils.py#L3072)
~~~
# Sample 2 next tokens for each beam (so we have some spare tokens and match output of... |
transformers | 25,102 | closed | documentation for llama2 models | # What does this PR do?
Adds some documentation for 'f' models.
Fixes #25090
## Before submitting
- [X] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
## Who can review?
@ArthurZucker
** I'm not sure if this is even the right way to include the documenta... | 07-26-2023 03:10:26 | 07-26-2023 03:10:26 | _The documentation is not available anymore as the PR was closed or merged._<|||||>changes incorporated! |
transformers | 25,101 | closed | fix tied_params for meta tensor | # What does this PR do?
This PR fix the retrieval of `tied_params` when we load a model with accelerate. The issue was that we were not able to retrieve the tied parameters by using the `id` function to check equality between meta `tensor`. Instead, we use `find_tied_parameters` from accelerate library.
Solves [#1... | 07-25-2023 21:07:07 | 07-25-2023 21:07:07 | _The documentation is not available anymore as the PR was closed or merged._ |
transformers | 25,100 | open | Trainer/accelerate crashes when loading checkpoint using FSDP: sync_module_states ValueError | ### System Info
- `transformers` version: 4.31.0
- Platform: Linux-5.15.0-41-generic-x86_64-with-glibc2.31
- Python version: 3.11.4
- Huggingface_hub version: 0.16.4
- Safetensors version: 0.3.1
- Accelerate version: 0.21.0
- Accelerate config: not found
- PyTorch version (GPU?): 2.0.1+cu117 (True)
- Tensor... | 07-25-2023 20:47:40 | 07-25-2023 20:47:40 | Hello, as the error mentions, `sync_module_states` needs to be True. For this please use the accelerate launcher with the related accelerate config as specified in the docs here: https://huggingface.co/docs/transformers/main_classes/trainer#using-accelerate-launcher-with-trainer<|||||>Thank you, I will try that. Is it ... |
transformers | 25,099 | open | Missing '1' token for the Donut Processor checkpoints | ### System Info
`transformers==4.31.0`
`python=3.9`
### Who can help?
_No response_
### Information
- [X] The official example scripts
- [ ] My own modified scripts
### Tasks
- [ ] An officially supported task in the `examples` folder (such as GLUE/SQuAD, ...)
- [ ] My own task or dataset (give details below)
... | 07-25-2023 20:43:36 | 07-25-2023 20:43:36 | Not sure this is something wrong in Transformers, sounds like it's the model repos that are missing something. cc @younesbelkada <|||||>> Note that this behavior is not present for the tokenizer mentioned as a pretrained base on the [donut github repo](https://github.com/clovaai/donut/blob/master/donut/model.py#L159C9-... |
transformers | 25,098 | closed | Bump certifi from 2022.12.7 to 2023.7.22 in /examples/research_projects/decision_transformer | Bumps [certifi](https://github.com/certifi/python-certifi) from 2022.12.7 to 2023.7.22.
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/certifi/python-certifi/commit/8fb96ed81f71e7097ed11bc4d9b19afd7ea5c909"><code>8fb96ed</code></a> 2023.07.22</li>
<li><a href="https://github.com/certifi/pytho... | 07-25-2023 20:43:18 | 07-25-2023 20:43:18 | _The documentation is not available anymore as the PR was closed or merged._ |
transformers | 25,097 | closed | Bump certifi from 2022.12.7 to 2023.7.22 in /examples/research_projects/visual_bert | [//]: # (dependabot-start)
⚠️ **Dependabot is rebasing this PR** ⚠️
Rebasing might not happen immediately, so don't worry if this takes some time.
Note: if you make any changes to this PR yourself, they will take precedence over the rebase.
---
[//]: # (dependabot-end)
Bumps [certifi](https://github.com/certifi/... | 07-25-2023 20:43:05 | 07-25-2023 20:43:05 | _The documentation is not available anymore as the PR was closed or merged._ |
transformers | 25,096 | closed | Bump certifi from 2022.12.7 to 2023.7.22 in /examples/research_projects/lxmert | Bumps [certifi](https://github.com/certifi/python-certifi) from 2022.12.7 to 2023.7.22.
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/certifi/python-certifi/commit/8fb96ed81f71e7097ed11bc4d9b19afd7ea5c909"><code>8fb96ed</code></a> 2023.07.22</li>
<li><a href="https://github.com/certifi/pytho... | 07-25-2023 20:42:39 | 07-25-2023 20:42:39 | _The documentation is not available anymore as the PR was closed or merged._ |
transformers | 25,095 | open | Migrate Trainer from `Repository` to `upload_folder` | # What does this PR do?
This PR migrates the internal of the push to Hub strategy inside the Trainer to the upload methods instead of the old git approach. The goal is to benefit from the improvements in terms of speed (for instance `upload_folder` is faster than `Repository` on Colab) and avoid some weird sync erro... | 07-25-2023 19:23:28 | 07-25-2023 19:23:28 | Note that the Hub tests are failing because `upload_folder` seems very slow on moon-staging (with 503 errors and multiple retries for each push). Might be worth putting everything in blocking mode for those tests (though we won't test the fact that jobs properly run in the background then)<|||||>The docs for this PR li... |
transformers | 25,094 | closed | Add bloom flax | # What does this PR do?
Adds the Flax BLOOM model, superseding #18022 (where force pushing to Younes' branch after rebase closed the PR branch and created a new one) | 07-25-2023 18:35:46 | 07-25-2023 18:35:46 | _The documentation is not available anymore as the PR was closed or merged._<|||||>Thanks for the clinical review! Merging 👍 |
transformers | 25,093 | open | Add mask2former fp16 support | # What does this PR do?
Add float16 support to mask2former module and derivatives
Some operations and conversions were fixed in order to propagate the chosen user _dtype_ (ex: float32, float16) for input and embeddings. In this way, we can pass in fp16 tensors for inference.
## Who can review?
Similar PRs wer... | 07-25-2023 18:25:15 | 07-25-2023 18:25:15 | Hi @pedrohml, thanks for opening this PR!
Could you add some tests for these models e.g. [like this one for ViT](https://github.com/huggingface/transformers/blob/dd9d45b6ecc0861847e21d461187711331a56138/tests/models/vit/test_modeling_vit.py#L320)<|||||>@amyeroberts thanks for review. do you mind to double check new... |
transformers | 25,092 | closed | fix idefics vision config | # What does this PR do?
As discussed offline, this should refactor the vision config args.
We need to address similar changes as https://huggingface.co/HuggingFaceM4/tiny-random-idefics/discussions/2 to make it work with other checkpoints
cc @stas00
| 07-25-2023 18:13:51 | 07-25-2023 18:13:51 | _The documentation is not available anymore as the PR was closed or merged._<|||||>The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_25092). All of your documentation changes will be reflected on that endpoint. |
transformers | 25,091 | closed | Hotfix for failing `MusicgenForConditionalGeneration` tests | # What does this PR do?
A exceptional case (for `MusicgenForConditionalGeneration`) is not detected by the CI triggered in #24927.
Test is currently failing on `main`, see
https://app.circleci.com/pipelines/github/huggingface/transformers/68971/workflows/503866ea-e425-4817-9849-52c6e7fd2865/jobs/863722 | 07-25-2023 18:00:12 | 07-25-2023 18:00:12 | _The documentation is not available anymore as the PR was closed or merged._ |
transformers | 25,090 | closed | Need documentation for understanding the difference between `7B` and `7Bf` | Unclear what the tradeoffs are between using eg `7B` and `7Bf` as an argument for `model_size` in the `convert_llama_weights_to_hf.py` script:
https://github.com/huggingface/transformers/blob/f9cc333805c47665c6afee8b5867931e54abe0c6/src/transformers/models/llama/convert_llama_weights_to_hf.py#L65 | 07-25-2023 17:49:17 | 07-25-2023 17:49:17 | cc @ArthurZucker <|||||>Sure, we can add a bit of documentation, mentioning that this is specific to llama2 official release 😉 |
transformers | 25,089 | closed | Move common image processing methods to BaseImageProcessor | # What does this PR do?
Moves out the `rescale` and `normalize` methods of the image processors to the BaseImageProcessor class, which all the image processors inherit from.
Reason for moving `rescale` and `normalize`:
* Standard image processing steps
* Used by (almost) all image processors
* Few cases wh... | 07-25-2023 17:21:37 | 07-25-2023 17:21:37 | _The documentation is not available anymore as the PR was closed or merged._ |
transformers | 25,088 | open | [`resize_embedding`] Introduce `pad_to_multiple_of` and guidance | # What does this PR do?
Fixes #22312.
After internal discussions, it appears that adding this to `tokenizers` is not really feasible ( nor is it desirable).
However, what we can do is by default resize the embedding layer to the nearest size that is optimal for the dtype of the model [following this](https://docs.n... | 07-25-2023 17:09:42 | 07-25-2023 17:09:42 | The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_25088). All of your documentation changes will be reflected on that endpoint. |
transformers | 25,087 | closed | Edit err message and comment in `test_model_is_small` | # What does this PR do?
Tiny error message and comment update to bring into alignment with 1M param max mentioned in https://github.com/huggingface/transformers/pull/24824#issue-1804886584
<!--
Congratulations! You've made it this far! You're not quite done yet though.
Once merged, your PR is going to appear in... | 07-25-2023 16:09:57 | 07-25-2023 16:09:57 | The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_25087). All of your documentation changes will be reflected on that endpoint. |
transformers | 25,086 | open | Generate: return `past_key_values` | # What does this PR do?
WIP | 07-25-2023 15:29:13 | 07-25-2023 15:29:13 | The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_25086). All of your documentation changes will be reflected on that endpoint. |
transformers | 25,085 | closed | [`TF`] Also apply patch to support left padding | # What does this PR do?
Fixes red test on main GPTj test equivalence. Follows #24979 | 07-25-2023 14:52:28 | 07-25-2023 14:52:28 | The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_25085). All of your documentation changes will be reflected on that endpoint. |
transformers | 25,084 | closed | AttributeError: 'GenerationConfig' object has no attribute 'task_to_id' | ### System Info
I am following the [Audio course](https://huggingface.co/learn/audio-course/chapter5/asr_models#longform-transcription-and-timestamps) course and tried to perform translation using the automatic speech recognition pipeline but got a weird error.
Code:
```
from transformers import pipeline
asr =... | 07-25-2023 14:52:27 | 07-25-2023 14:52:27 | Also cc @sanchit-gandhi since it comes from the audio course.<|||||>Can you link the full stacktrace if possible ? This might help us narrow it down faster.<|||||>+1 on the full stack-trace. It might require an update to your generation config since this is a fine-tuned checkpoint and the API was updated to take the `t... |
transformers | 25,083 | closed | update `use_auth_token` -> `token` | # What does this PR do?
Fix #25008
@sgugger This should be ready for a review. There are still a few places that use `use_auth_token`, but only during the calls to relevant methods.
I will change those calls to use `token` before merge. | 07-25-2023 14:30:39 | 07-25-2023 14:30:39 | _The documentation is not available anymore as the PR was closed or merged._<|||||>In some training example script, (for example, `examples/tensorflow/contrastive-image-text/run_clip.py`) there are
```python
use_auth_token: bool = field(
default=False,
metadata={
"help": (
... |
transformers | 25,082 | closed | LLaMA Tokenizer does not compute word_ids | ### System Info
- `transformers` version: 4.31.0.dev0
- Platform: Linux-4.18.0-477.10.1.el8_8.x86_64-x86_64-with-glibc2.28
- Python version: 3.9.7
- Huggingface_hub version: 0.14.1
- Safetensors version: 0.3.1
- PyTorch version (GPU?): 2.1.0.dev20230515+cu117 (True)
- Tensorflow version (GPU?): not installed (... | 07-25-2023 14:25:53 | 07-25-2023 14:25:53 | Hey! Thanks for reporting this. This seems to be related to the backend tokenizer, so most probably the `tokenizers` library. cc @Narsil if you have a quick idea, otherwise, I'll investigate<|||||>Oh it's simple.
It's just that what you call "word" doesn't exist for this tokenizer...
A lot of tokenizers use whitesp... |
transformers | 25,081 | open | WIP [`split_special_tokens`] Add support for `split_special_tokens` argument to encode | # What does this PR do?
Argument name is totally debatable. Will also require a pull request in `tokenizers`.
The goal is to be able to simply activate and de-activate the special token splitting. Feature was asked in #22490, and is required for some production type cases, where users pass inputs and we don't want t... | 07-25-2023 14:02:58 | 07-25-2023 14:02:58 | The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_25081). All of your documentation changes will be reflected on that endpoint. |
transformers | 25,080 | open | fix bug : add global_step when call self.lr_scheduler.step | # What does this PR do?
<!--
Congratulations! You've made it this far! You're not quite done yet though.
Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution.
Then, please replace this w... | 07-25-2023 13:02:52 | 07-25-2023 13:02:52 | |
transformers | 25,079 | open | Forget to put the global-step in lr scheduler in train.py | ### System Info
- ` transformers` version: 4.30.2
- Platform: Linux-3.10.0-1160.83.1.el7.x86_64-x86_64-with-glibc2.35
- Python version: 3.10.6
- Huggingface_hub version: 0.15.1
- Safetensors version: 0.3.1
- PyTorch version (GPU?): 2.0.0 (True)
- Tensorflow version (GPU?): not installed (NA)
- Flax versio... | 07-25-2023 13:01:28 | 07-25-2023 13:01:28 | cc @pacman100 <|||||>Hello, a minimal reproducer for this please. The checkpointing test loads back the correct lr: https://github.com/huggingface/accelerate/actions/runs/5651936442/job/15310803049#step:5:2259<|||||>> Hello, a minimal reproducer for this please. The checkpointing test loads back the correct lr: https:/... |
transformers | 25,078 | closed | replace `per_gpu_eval_batch_size` with `per_device_eval_batch_size` in readme of multiple-choice task | ### What does this PR do?
replace `per_gpu_eval_batch_size` with `per_device_eval_batch_size` in readme of multiple-choice task as the training arguments `per_gpu_*` is deprecated.
## Before submitting
- [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
- [... | 07-25-2023 12:00:21 | 07-25-2023 12:00:21 | The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_25078). All of your documentation changes will be reflected on that endpoint. |
transformers | 25,077 | open | [`PEFT`] Peft integration alternative design | # What does this PR do?
From the offline discussion + the comments from @patrickvonplaten in https://github.com/huggingface/transformers/pull/24827#issuecomment-1641750464 I propose a new design for tightly integrating PEFT into transformers.
This integration enables loading any PEFT adapter that is saved locally ... | 07-25-2023 11:12:34 | 07-25-2023 11:12:34 | The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_25077). All of your documentation changes will be reflected on that endpoint.<|||||>Mmmm, but know we can't do `model = AutoModelForCausalLM.from_pretrained("ybelkada/opt-350m-lora")` despite the checkpoint having all the correct ... |
transformers | 25,076 | closed | Evaluation resulting in "RuntimeError: Tensors must be contiguous". | ### System Info
Copy-and-paste the text below in your GitHub issue and FILL OUT the two last points.
- `transformers` version: 4.31.0
- Platform: Linux-5.15.0-1037-aws-x86_64-with-glibc2.29
- Python version: 3.8.10
- Huggingface_hub version: 0.15.1
- Safetensors version: 0.3.1
- Accelerate version: 0.21.0
- A... | 07-25-2023 11:07:28 | 07-25-2023 11:07:28 | You should debug the code to find which tensor PyTorch complains about and make sure you add the `contiguous` as requested.
But we could also make sure to add it in `gather` directly @muellerzr <|||||>@notrichardren try running again, installing accelerate via `pip install git+https://github.com/huggingface/accelera... |
transformers | 25,075 | closed | Set `TF32` flag for PyTorch cuDNN backend | # What does this PR do?
<!--
Congratulations! You've made it this far! You're not quite done yet though.
Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution.
Then, please replace this w... | 07-25-2023 11:05:15 | 07-25-2023 11:05:15 | _The documentation is not available anymore as the PR was closed or merged._ |
transformers | 25,074 | closed | Fix: repeat per sample for SAM image embeddings | # What does this PR do?
<!--
Congratulations! You've made it this far! You're not quite done yet though.
Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution.
Then, please replace this w... | 07-25-2023 10:55:33 | 07-25-2023 10:55:33 | cc @younesbelkada since you added the model.<|||||>The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_25074). All of your documentation changes will be reflected on that endpoint. |
transformers | 25,073 | open | Slow Tokenizer adds whitespace after special token | ### System Info
Python 3.10.6
Transformers 4.31.0
<class 'transformers.models.llama.tokenization_llama.LlamaTokenizer'>
### Who can help?
@ArthurZucker @younesbelkada
### Information
- [ ] The official example scripts
- [X] My own modified scripts
### Tasks
- [ ] An officially supported task i... | 07-25-2023 10:07:20 | 07-25-2023 10:07:20 | Hey! My first suggestion would be to not use the legacy behaviour by setting `legacy = False` when you initialize the tokenizer.
Second, the `txt_encoded == txt_encoded_decoded` assumption is not always true for all tokenizers. In this case, the decoding adds an extra space, maybe because it is based on the previous ... |
transformers | 25,072 | closed | [Docs] fix rope_scaling doc string | The `rope_scaling` supports *two* scaling strategies not three. | 07-25-2023 09:31:57 | 07-25-2023 09:31:57 | _The documentation is not available anymore as the PR was closed or merged._ |
transformers | 25,071 | open | evaluation_strategy and eval_steps does not work | ### System Info
- `transformers` version: 4.27.1
- Platform: Linux-4.15.0-200-generic-x86_64-with-debian-buster-sid
- Python version: 3.7.16
- Huggingface_hub version: 0.13.2
- PyTorch version (GPU?): 1.13.1+cu117 (True)
- Tensorflow version (GPU?): 2.4.0 (True)
- Flax version (CPU?/GPU?/TPU?): not installed (NA... | 07-25-2023 09:18:39 | 07-25-2023 09:18:39 | Please provide a reproducer we can execute. We do not have your `train_file` and `validation_file`. |
transformers | 25,070 | closed | Param grad None despite model training with requires_grad=True | ### System Info
- `transformers` version: 4.32.0.dev0
- Platform: Linux-3.10.0-1160.80.1.el7.x86_64-x86_64-with-glibc2.17
- Python version: 3.9.17
- Huggingface_hub version: 0.16.4
- Safetensors version: 0.3.1
- Accelerate version: 0.21.0
- Accelerate config: not found
- PyTorch version (GPU?): 2.0.1 (False)
... | 07-25-2023 08:11:14 | 07-25-2023 08:11:14 | cc @sanchit-gandhi since this is an audio model.<|||||>Hey @Remorax - the print statements you've added are in the forward pass of the model, where the gradients will always be zero. The gradients are only computed in the back prop, which is triggered once the forward pass is completed. Once the back propagation is com... |
transformers | 25,069 | open | Fast and normal tokenizer generate different output when handling consecutive spaces. | ### System Info
Transformer version: 4.29.2
### Who can help?
_No response_
### Information
- [ ] The official example scripts
- [ ] My own modified scripts
### Tasks
- [ ] An officially supported task in the `examples` folder (such as GLUE/SQuAD, ...)
- [ ] My own task or dataset (give details below)
### Repro... | 07-25-2023 06:29:46 | 07-25-2023 06:29:46 | cc @ArthurZucker <|||||>This seems to be pretty close to #24918.
I don't know how they converted the fast tokenizer but it seems wrong. I suggest you open an issue at https://hf.co/openlm-research/open_llama_7b/discussions, as if you use the `huggyllama/llama-7b` model, you will not have this issue:
```python
i... |
transformers | 25,068 | open | change vocab_size in deberta-v2 default config | # What does this PR do?
<!--
Congratulations! You've made it this far! You're not quite done yet though.
Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution.
Then, please replace this w... | 07-25-2023 06:27:11 | 07-25-2023 06:27:11 | The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_25068). All of your documentation changes will be reflected on that endpoint. |
transformers | 25,067 | closed | Fix broken link in README_hd.md | # What does this PR do?
<!--
Congratulations! You've made it this far! You're not quite done yet though.
Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution.
Then, please replace this w... | 07-25-2023 03:36:22 | 07-25-2023 03:36:22 | _The documentation is not available anymore as the PR was closed or merged._ |
transformers | 25,066 | closed | fix: add TOC anchor link | # What does this PR do?
<!--
Congratulations! You've made it this far! You're not quite done yet though.
Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution.
Then, please replace this w... | 07-25-2023 02:59:19 | 07-25-2023 02:59:19 | _The documentation is not available anymore as the PR was closed or merged._ |
transformers | 25,065 | open | llama2 training has nan | ### System Info
- `transformers` version: 4.31.0
- Platform: Linux-5.19.0-42-generic-x86_64-with-glibc2.35
- Python version: 3.9.16
- Huggingface_hub version: 0.14.1
- Safetensors version: 0.3.1
- Accelerate version: 0.21.0
- Accelerate config: - compute_environment: LOCAL_MACHINE
- distributed_type:... | 07-25-2023 01:37:14 | 07-25-2023 01:37:14 | What are you setting as your `pad_token`? I was getting `nan` while running batched inference (see post [here](https://discuss.huggingface.co/t/llama2-pad-token-for-batched-inference/48020)) and am wondering if this might be related to your issue?<|||||>I set tokenizer.pad_token_id = 0, which is the same as llama1 (:<|... |
transformers | 25,064 | closed | Feature/forward | null | 07-25-2023 01:06:35 | 07-25-2023 01:06:35 | |
transformers | 25,063 | closed | model.generate does not work when using a AlbertModel | ### System Info
- `transformers` version: 4.31.0
- Platform: Linux-5.15.109+-x86_64-with-glibc2.35
- Python version: 3.10.6
- Huggingface_hub version: 0.16.4
- Safetensors version: 0.3.1
- Accelerate version: not installed
- Accelerate config: not found
- PyTorch version (GPU?): 2.0.1+cu118 (False)
- Tensorf... | 07-25-2023 00:20:12 | 07-25-2023 00:20:12 | I don't know what more you want me to say. As the error clearly states, this is not a model that supports `.generate`. ALBERT was trained on a masked language modeling objective so none of its variants are compatible with `.generate()`. |
transformers | 25,062 | open | GPTQ integration | # What does this PR do?
This PR adds the possibility to perform GTPQ quantization with transformers model using [optimum](https://github.com/huggingface/optimum) library. The backend relies on [auto_gptq](https://github.com/PanQiWei/AutoGPTQ) library where we use `GTPQ` and `QuantLinear` class.
Here's the related [... | 07-24-2023 22:48:42 | 07-24-2023 22:48:42 | The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_25062). All of your documentation changes will be reflected on that endpoint.<|||||>> 2- Would it make sense to slowly "deprecate" the args load_in_4bit and load_in_8bit as it might lead to confusion for users (because technically... |
transformers | 25,061 | open | Generation refactor: new interface, new classes. | ## Summary
This PR introduces an updated `generate()` interface for the Huggingface Transformers library. The update focuses on enhancing extensibility and enabling the explicit declaration of the generation strategy, while ensuring backward compatibility.
## Detailed Description
### Introducing the "generatio... | 07-24-2023 22:46:14 | 07-24-2023 22:46:14 | Hi @manueldeprada 👋
Thank you for the proposal, but this PR adds further parameterization to `generate()`, and we want to go in the opposite direction whenever possible -- `.generate()` already has too many possible arguments.
Related to this PR: we are internally discussing how to refactor `.generate()` -- is... |
transformers | 25,060 | open | LlaVa model in transformers | ### Feature request
Support to Llava model in transformers? https://github.com/haotian-liu/LLaVA Similar to InstructBlip w/ connector module between image embeddings and LLM's
### Motivation
Llava is performing really well in MLLM related tasks and for folks to try out InstructBlip vs Llava models it makes it easier... | 07-24-2023 21:41:07 | 07-24-2023 21:41:07 | Hi @RajeshRadha Thank you for the feature request.
As @ArthurZucker mentioning to me, the repo. has reached 4K starts and 300 fork, it seems this is quite popular.
Will leave our core maintainers @amyeroberts and @sgugger to see if this qualifies the model to be in `transformers` or we still prefer to have it fir... |
transformers | 25,059 | closed | Fix `token` in auto classes | # What does this PR do?
Fix `token` in auto classes.
Fix #25008
We (me) should start to:
- add (some) explicit arguments to `from_pretrained` for auto classes
- (probably) clean-up the usage of `use_auth_token` even internally
But let's do this in separate PR(s), I promise. | 07-24-2023 18:31:31 | 07-24-2023 18:31:31 | The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_25059). All of your documentation changes will be reflected on that endpoint.<|||||>Good catch. I guess I have to deal with the internal usages of those `kwargs`<|||||>Yes, ideally we want to only use `token` everywhere now :-) Ha... |
transformers | 25,058 | closed | Fix last models for common tests that are too big. | # What does this PR do?
This PR fixes the last batch of models that are too big for common tests. After it, only two classes override the common test to skip it:
- timm-backbone
- layoutlmv2
In the first case, it's because there is no timm model small enough to work (I did switch to the smallest resnet though) an... | 07-24-2023 18:27:13 | 07-24-2023 18:27:13 | _The documentation is not available anymore as the PR was closed or merged._ |
transformers | 25,057 | closed | fix deepspeed load best model at end when the model gets sharded | # What does this PR do?
1. Fixes https://github.com/huggingface/transformers/issues/25027 | 07-24-2023 17:41:23 | 07-24-2023 17:41:23 | _The documentation is not available anymore as the PR was closed or merged._ |
transformers | 25,056 | closed | [`IDEFICS`] Fix idefics ci | # What does this PR do?
Attempt to fix IDEFICS failing CI as discussed offline @stas00 - more info coming soon
original PR: https://github.com/huggingface/transformers/pull/24796
| 07-24-2023 16:48:20 | 07-24-2023 16:48:20 | _The documentation is not available anymore as the PR was closed or merged._<|||||>The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_25056). All of your documentation changes will be reflected on that endpoint. |
transformers | 25,055 | closed | [`RWKV`] Add note in doc on `RwkvStoppingCriteria` | # What does this PR do?
Given the usage of RWKV, decide to go with a tip in the doc rather than changing the `generate` and adding `RwkvStoppingCriteria` to the library. Adresses #23852 | 07-24-2023 16:47:31 | 07-24-2023 16:47:31 | _The documentation is not available anymore as the PR was closed or merged._ |
transformers | 25,054 | closed | removed_unused_columns = True deletes dataset for custom loss func | Feel free to see the[ second comment](https://github.com/huggingface/transformers/issues/25054#issuecomment-1648263249) directly. The original issue was on confusion for the training dataset seemingly not working -- I narrowed it down to the ```removed_unused_columns = True``` dataset deleting an entire dataset, which ... | 07-24-2023 16:37:48 | 07-24-2023 16:37:48 | I did some further investigation and found that this dataset seems to work _if_ and only if you set remove_unused_columns = False in the training arguments.
**It seems very odd that "remove_unused_columns = True" would result in the entire dataset being wiped, given that the features in the dataset are ['labels', 'i... |
transformers | 25,053 | closed | [ `PreTrainedTokenizerFast`] Keep properties from fast tokenizer | # What does this PR do?
Start a potential fix to #24179, ended up being releated to #24441, calling modifies the values of the underlying tokenizer, but never changes anything on the surface so will probably add some kind of warning in the documentation.
TLDR; adds the possibility of initialize a `PreTrainedToken... | 07-24-2023 16:35:40 | 07-24-2023 16:35:40 | _The documentation is not available anymore as the PR was closed or merged._<|||||>Yes, currently everything is ignored |
transformers | 25,052 | closed | MaskFormer - enable return_dict in order to compile | # What does this PR do?
Is was previously not possible to use `torch.compile` on Maskformer as some modules always returned a dataclass, instead of a tuple.
This PR adds a `return_dict` argument to these modules, which defaults to `True` to maintain the previous behaviour.
Tested with:
```python
import req... | 07-24-2023 15:39:59 | 07-24-2023 15:39:59 | _The documentation is not available anymore as the PR was closed or merged._<|||||>cc @merveenoyan who highlighted the compiling issue 🙏 <|||||>@sgugger Yep! I'll update that<|||||>@sgugger Most of the custom tests aren't easy to remove, unfortunately. As MaskFormer combines hidden states from different modules -- enc... |
transformers | 25,051 | open | Add ViTMatte | # What does this PR do?
This PR adds the ViTMatte model, an elegant approach to image matting, entirely relying on the Vision Transformer backbone doing the heavy work, with a lightweight head on top.
Here's a Colab notebook showcasing inference: https://colab.research.google.com/drive/1pWTn3Iur-NR2xUIyDE31dBgng_... | 07-24-2023 14:51:36 | 07-24-2023 14:51:36 | |
transformers | 25,050 | open | Trainer does not properly read "label" column. | ### System Info
When I have a HuggingFace dataset with 'input_ids', 'attention_mask', and 'labels', the current HuggingFace Trainer does not properly read 'labels' and separate the labels from the inputs in the forward pass.
I also tried a 'label' (as opposed to 'labels') column and it does not work with this eit... | 07-24-2023 14:42:51 | 07-24-2023 14:42:51 | You are using a model which does not accept `labels` in its forward pass: `AutoModel` gives you the base model, it is only suitable to extract the last hidden state generated by the model, not for training.<|||||>By default, am I supposed to pass a model to Trainer that is able to accept "labels" in its forward pass?
... |
transformers | 25,049 | closed | Better error message when signal is not supported on OS | # What does this PR do?
This PR adds a `try`/`except` block around the logic asking the user whether they want to execute the code on a distant repo when they don't set `trust_remote_code=True` to give a helpful error message.
Fixes #25029 | 07-24-2023 14:17:52 | 07-24-2023 14:17:52 | _The documentation is not available anymore as the PR was closed or merged._ |
transformers | 25,048 | closed | [DOCS] add docstrings to TypicalLogitsWarper | # What does this PR do?
Added some doc string to TypicalLogitsWarper with some examples as well.
@gante let me know if there's anything else should be add or remove from the docs.
Fixes #24783
## Before submitting
- [x] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's... | 07-24-2023 14:17:35 | 07-24-2023 14:17:35 | @akshayamadhuri you probably need to run `make fixup` on your terminal and then commit the changes to make our CI happy :D |
transformers | 25,047 | closed | [`8bit`] Fix 8bit corner case with Blip2 8bit | # What does this PR do?
Fixes https://github.com/huggingface/transformers/issues/25011
Fixes https://github.com/huggingface/transformers/issues/25026
https://github.com/huggingface/transformers/pull/24095/ introduced a new check for retrieving the list of modules that are not needed to be quantized (e.g. LM head... | 07-24-2023 14:09:48 | 07-24-2023 14:09:48 | _The documentation is not available anymore as the PR was closed or merged._<|||||>Tests are green, merging! |
transformers | 25,046 | closed | [DOCS] add example NoBadWordsLogitsProcessor | # What does this PR do?
<!--
Congratulations! You've made it this far! You're not quite done yet though.
Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution.
Then, please replace this w... | 07-24-2023 14:09:22 | 07-24-2023 14:09:22 | _The documentation is not available anymore as the PR was closed or merged._<|||||>(@SoyGema did a minor edit on the PR header: the word "fixes" before an issue number on a PR automatically closes the issue when the PR is merged) |
transformers | 25,045 | closed | Fix some bugs for two stage training of deformable detr | Hello @amyeroberts:
There are some issues encountered when training with the two-stage method using Deformable DETR, for which I have made modifications. | 07-24-2023 13:59:25 | 07-24-2023 13:59:25 | @jypjypjypjyp Thanks for opening this PR! Could you: share a minimal code snippet in the PR which triggers the errors on main and which this PR resolves? <|||||>> @jypjypjypjyp Thanks for opening this PR! Could you: share a minimal code snippet in the PR which triggers the errors on main and which this PR resolves?
... |
transformers | 25,044 | closed | compute_loss in trainer failing to label shift for PEFT model when label smoothing enabled. | # What does this PR do?
When training LlamaForCausalLM with PEFT enabled, I noticed that the compute_loss function of the trainer with label_smoothing enabled was not shifting the labels. Further investigation found that `unwrap_model(model)._get_name()` returned "PeftModelForCausalLM", and the `MODEL_FOR_CAUSAL_LM_... | 07-24-2023 13:49:10 | 07-24-2023 13:49:10 | No we cannot add this like that, as this is not a model that lives in Transformers.
cc @younesbelkada <|||||>@njbrake thanks for the PR, can you elaborate more on the label shifting issue?
https://github.com/huggingface/transformers/blob/main/src/transformers/models/llama/modeling_llama.py#L832 should be automatical... |
transformers | 25,043 | open | Can't Reproduce GLUE scores using official BERT implementation | ### System Info
- `transformers` version: 4.32.0.dev0
- Platform: Linux-5.15.0-1036-aws-x86_64-with-glibc2.31
- Python version: 3.9.16
- Huggingface_hub version: 0.16.4
- Safetensors version: 0.3.1
- Accelerate version: 0.21.0
- Accelerate config: not found
- PyTorch version (GPU?): 2.0.1+cu117 (True)
- Ten... | 07-24-2023 13:45:40 | 07-24-2023 13:45:40 | The results you will get are very sensitive to the seed used.<|||||>Hi @sgugger , so it means that as long as I get the same results as on the huggingface README, my model is nearly identical to the paper, right?
Also a follow-up: in our paper we shall also include this score. Do you remember anyone ever reproduced th... |
transformers | 25,042 | closed | Generate - add beam indices output in contrained beam search | # What does this PR do?
Fixes #25000
This PR adds the `beam_indices` output to constrained beam search, just like in the other beam methods. The changes are (mostly) copy-paste from beam search, and they pipe `beam_indices` all the way to the output.
Script for reproducibility (didn't work before, works after ... | 07-24-2023 13:40:45 | 07-24-2023 13:40:45 | _The documentation is not available anymore as the PR was closed or merged._ |
transformers | 25,041 | open | LlamaTokenizerFast report vocab_size info not correct | ### System Info
Linux
### Who can help?
_No response_
### Information
- [ ] The official example scripts
- [ ] My own modified scripts
### Tasks
- [ ] An officially supported task in the `examples` folder (such as GLUE/SQuAD, ...)
- [ ] My own task or dataset (give details below)
### Reproduction
model = ... | 07-24-2023 13:28:37 | 07-24-2023 13:28:37 | cc @ArthurZucker <|||||>Hey! Sorry, the formatting of the issue is a bit strange I do not understand the problem.
Could you try to reformulate the issue with a minimal reproducing script using a model path? <|||||>OK , base_model=/models/WizardLM-13B-V1.0-Merged
model = AutoModelForCausalLM.from_pretrained(
... |
transformers | 25,040 | open | Add ViTMatte model | ### Model description
ViTMatte is a recently released model for alpha matting on images i.e. background removal.
The model accepts an input image and trimap (manually labelled grayscale image outlining the rough border of the foreground object) and predicts the alpha mate for each pixel.
It introduces a series... | 07-24-2023 13:17:36 | 07-24-2023 13:17:36 | |
transformers | 25,039 | closed | Add test when downloading from gated repo | Following PR after https://github.com/huggingface/transformers/pull/25034.
Goal is to add a test to check that accessing a gated repo raises a custom message for the user. Cannot be merged yet as the server returns "RepoNotFound" when user is not authenticated, even when it's a public gated repo. Once server implement... | 07-24-2023 13:17:21 | 07-24-2023 13:17:21 | _The documentation is not available anymore as the PR was closed or merged._<|||||>@sgugger The fix is merged and deployed server-side so the test can now be added in `transformers` :) |
transformers | 25,038 | closed | Add dispatch_batches to training arguments | # What does this PR do?
This PR adds the option to set `Accelerator`'s `dispatch_batches` argument through the `TrainingArguments`. This is needed in cases such as https://github.com/huggingface/transformers/issues/24999, when `dispatch_batches=False` is needed on the streaming dataset
Fixes # (issue)
Solves h... | 07-24-2023 13:01:07 | 07-24-2023 13:01:07 | The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_25038). All of your documentation changes will be reflected on that endpoint. |
transformers | 25,037 | closed | Add offload support to Bark | # What does this PR do?
Bark is a TTS model recently added by #24086.
It is made of is of 4 main sub-models, which are sequentially called during generation (`BarkModel.generate`). When a sub-model is used, the other models remain unused, taking up a lot of space on the GPU.
This PR thus propose a simple, yet... | 07-24-2023 12:56:42 | 07-24-2023 12:56:42 | _The documentation is not available anymore as the PR was closed or merged._<|||||>Why not leverage Accelerate here as is done in Diffusers pipeline? (cc @patrickvonplaten )<|||||>Hi @sgugger, thank you for taking part!
Diffusers pipeline is using [`accelerate's cpu_offload`](https://github.com/huggingface/accelerate... |
transformers | 25,036 | open | [BUG] RecursionError: maximum recursion depth exceeded when loading LLaMA-1 but success loading LLaMA-2 | ### System Info
- `transformers` version: 4.31.0
- Platform: Linux-4.18.0-425.3.1.el8.x86_64-x86_64-with-glibc2.31
- Python version: 3.10.12
- Huggingface_hub version: 0.16.4
- Safetensors version: 0.3.1
- Accelerate version: 0.21.0
- Accelerate config: not found
- PyTorch version (GPU?): 2.0.1+cu117 (True)
-... | 07-24-2023 11:22:01 | 07-24-2023 11:22:01 | I set a small recursion limit to 50 and I now got this trace back for loading LLaMA-1:
```
File "/mnt/home//Open-Assistant/model/model_training/trainer_sft.py", line 481, in <module>
main()
File "/mnt/home//Open-Assistant/model/model_training/trainer_sft.py", line 333, in main
tokenizer = get_tokenizer... |
transformers | 25,035 | closed | fix(integrations): store serialized `TrainingArgs` to `wandb.config` without sanitization. | Allows resuming training runs when reusing the wandb config.
# What does this PR do?
Currently the `WandbLogger` uses the `to_sanitized_dict()` method in `TrainingArguments` to serialize the training hyperparameters. This converts nested objects and `NoneType` objects to `str` for safe serialization. However, u... | 07-24-2023 10:31:07 | 07-24-2023 10:31:07 | _The documentation is not available anymore as the PR was closed or merged._ |
transformers | 25,034 | closed | Support GatedRepoError + use raise from | (PR started after comment from @osanseviero [on slack](https://huggingface.slack.com/archives/C03V11RNS7P/p1690185858721759?thread_ts=1689956871.406059&cid=C03V11RNS7P) -private link)
This PR adds 2 things:
- raise a more custom error in case of `GatedRepoError` when downloading a file. `GatedRepoError` is a subcla... | 07-24-2023 10:06:26 | 07-24-2023 10:06:26 | _The documentation is not available anymore as the PR was closed or merged._<|||||>@sgugger thanks for the review :)
I made the requested change and updated another error message as well to use `token` instead of `use_auth_token` (the error message for generic `RepoNotFoundError`) |
transformers | 25,033 | closed | [`logging.py`] set default `stderr` path if `None` | # What does this PR do?
Attempt to fix #24047
Thanks to contributors, seems like the issue [is known](https://github.com/pyinstaller/pyinstaller/issues/7334#issuecomment-1357447176).
Though it is not entirely related to `transformers`, adding a safeguard seems like a good practice | 07-24-2023 09:43:13 | 07-24-2023 09:43:13 | _The documentation is not available anymore as the PR was closed or merged._<|||||>Monkey patching globals like `sys.stdout` and `sys.stderr` is more of an emergency hack than a fix that libraries should be using. The proper way to handle Python windowed mode is to guard any direct usage of `sys.stderr` in `if sys.stde... |
transformers | 25,032 | open | Allow resuming of logging to WANDB with the Trainer | ### Feature request
As far as I can tell, it is currently not possible to resume a training run and continue logging to the same run on WANDB when using the Trainer. The reason is that WANDB would [require](https://github.com/wandb/wandb/blob/a32638cb1c6ab775e9ed431d9a9b4b8a30685453/wandb/sdk/wandb_init.py#L1036-L10... | 07-24-2023 09:30:15 | 07-24-2023 09:30:15 | cc @parambharat who has done a lot of work on the Wandb integration<|||||>Hi @BramVanroy , Thanks for bringing this up. If I understood the issue correctly, you want to resume a wandb run while resuming training. There are two solutions I can think of that don't require changing `TrainingArguments`. Can you try these i... |
transformers | 25,031 | closed | Fix doctest | # What does this PR do?
Fix a doctest (that is recently added): precision issue | 07-24-2023 09:27:28 | 07-24-2023 09:27:28 | _The documentation is not available anymore as the PR was closed or merged._ |
transformers | 25,030 | closed | [`generate`] Only warn users if the `generation_config`'s `max_length` is set to the default value | # What does this PR do?
Updates the condition for raising a warning in generate to warn users if the `generation_config`'s `max_length` is set to the default value. | 07-24-2023 09:15:50 | 07-24-2023 09:15:50 | _The documentation is not available anymore as the PR was closed or merged._<|||||>@sgugger as discussed on Slack with @ArthurZucker: `max_new_tokens` can't be used to set a default `generation_config` that works well out of the box -- `max_length` does. As such, let's adapt the warning to enable us (and the users) to ... |
transformers | 25,029 | closed | Bug in autotokenizer some open source models such as falcon. | ### System Info
I want to get the sentence difference and use autotokenizer a falcon model 40B and 7B but usually, I receive an attribute error bug: model 'signal' has no attribute 'SIGALRM'.
@younesbel... | 07-24-2023 07:37:22 | 07-24-2023 07:37:22 | Hey! Could you provide a full trace to know where the error come from?
I cannot reproduce the error with the script you provided. Make sure you are using the latest version of transformers too! <|||||>Thanks.
... |
transformers | 25,028 | closed | [docs] duplicate table of contents in perf_infer_gpu_one.mdx | ## Description
There are duplicate titles [**Requirements**] in `perf_infer_gpu_one.md` from line 51 and 117 causing an error occurs when moving the table of contents.
## Document / Language
`perf_infer_gpu_one.md` / en
## Suggestion
line 51
As is :
```### Requirements```
To be :
```### Requirement... | 07-24-2023 05:44:47 | 07-24-2023 05:44:47 | I can't see this on the main branch, maybe this was fixed by the recent refactor of this guide?<|||||>Good catch! I don't think this [doc](https://huggingface.co/docs/transformers/main/en/perf_infer_gpu_one) was refactored in the recent PR (it was just moved), and I'm getting the same error on the `main` branch.
Wou... |
transformers | 25,027 | closed | LIama-2 7B fine-tuning with DeepSpeed OOM error during loading the best model at end when `load_best_model_at_end` specified as True. | ### System Info
Hi Community!
I am using `run_clm.py` with `deepspeed` to fine-tune LIama 7B on `g5.12xlarge` EC2 instance (4 GPU, Total GPU memory 96 GB, vCPUs 48 with 192 GB).
* Transformer version: 4.28.1
* DeepSpeed version: 0.10.0 (lastest)
* Instance: `g5.12xlarge` EC2 instance (4 GPU, Total GPU memor... | 07-24-2023 02:38:24 | 07-24-2023 02:38:24 | Hello, I'm able to run the following minimal example with any issues:
```
export WANDB_DISABLED="true"
export CUDA_VISIBLE_DEVICES="0,1"
cd transformers
deepspeed --num_nodes 1 --num_gpus 2 --master_port 10999 /home/sourab/transformers/examples/pytorch/language-modeling/run_clm.py --model_name_or_path gpt2 ... |
transformers | 25,026 | closed | load_in_8bit=True broken with new transformers | ### System Info
- `transformers` version: 4.31.0
- Platform: Linux-5.4.0-150-generic-x86_64-with-glibc2.31
- Python version: 3.10.12
- Huggingface_hub version: 0.16.4
- Safetensors version: 0.3.1
- Accelerate version: 0.20.3
- Accelerate config: - compute_environment: LOCAL_MACHINE
- distributed_ty... | 07-23-2023 17:29:20 | 07-23-2023 17:29:20 | cc @younesbelkada <|||||>Hi @pseudotensor
Thanks for the issue and the clean reproducer, I can confirm the issue persists on the current main brach of transformers and does not occur with #25047 - once that PR merged your issue will be fixed
Also, there is no need to specify `load_in_8bit=True` and `device_map="au... |
transformers | 25,025 | open | KeyError: 'eval_loss' when doing LukeForMaskedLM | ### System Info
- `transformers` version: 4.30.2
- Platform: Linux-5.14.21-150400.24.55-default-x86_64-with-glibc2.31
- Python version: 3.10.10
- Huggingface_hub version: 0.16.4
- Safetensors version: 0.3.1
- PyTorch version (GPU?): 1.13.1+cu117 (True)
- Tensorflow version (GPU?): not installed (NA)
- Flax ve... | 07-23-2023 16:25:49 | 07-23-2023 16:25:49 | This example might need adjustments to be used on Luke, as the model has an API that is slightly different from BERT. |
transformers | 25,024 | closed | Weights of BlipModel are not initialized from the model checkpoint | ### System Info
- `transformers` version: 4.31.0.dev0
- Platform: Linux-5.15.0-76-generic-x86_64-with-debian-bullseye-sid
- Python version: 3.7.15
- Huggingface_hub version: 0.15.1
- Safetensors version: 0.3.1
- PyTorch version (GPU?): 1.13.1+cu117 (True)
- Tensorflow version (GPU?): 2.11.0 (False)
- Flax ver... | 07-23-2023 14:51:33 | 07-23-2023 14:51:33 | Also cc @ydshieh who was just discussing this internally :-)<|||||>Hi @Vibhu04
Thanks for the issue,
indeed there is a problem with `BlipModel` classes. Note that BlipModel would stand for the "pre-trained" versions of Blip to extract raw logits / hidden states from text and vision input. That class has been copied... |
transformers | 25,023 | open | 🌐 [i18n-KO] Translated `tokenizer_summary.md` to Korean | <!-- PR의 제목은 "🌐 [i18n-KO] Translated `<your_file>.md` to Korean" 으로 부탁드립니다 -->
# What does this PR do?
Translated the `<tokenizer_summary>.md` file of the documentation to Korean.
Thank you in advance for your review.
Part of https://github.com/huggingface/transformers/issues/20179
<!-- 메인 이슈에 기록이 남아요! 가짜연구소... | 07-23-2023 09:20:13 | 07-23-2023 09:20:13 | The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_25023). All of your documentation changes will be reflected on that endpoint.<|||||>리뷰를 남기고 submit을 안 했었네요 .. ㅠ<|||||>> 리뷰를 남기고 submit을 안 했었네요 .. ㅠ
ㅋㅋㅋㅋㅋㅋ 다행히 지금 번역 수정중이라서 확인했습니다!<|||||>> 나연님 항상 알기 쉬운 말로 번역해주셔서 좋아요! 게다가 이번 문서에서... |
transformers | 25,022 | closed | Incorrect padding_side Setting as 'left' in Llama Family Model | ### System Info
- `transformers` version: 4.30.2
- Platform: Linux-5.15.0-1041-azure-x86_64-with-glibc2.29
- Python version: 3.8.10
- Huggingface_hub version: 0.16.2
- Safetensors version: 0.3.1
### Who can help?
text models: @ArthurZucker and @younesbelkada generate: @gante
### Information
- [ ] The official ... | 07-23-2023 09:16:04 | 07-23-2023 09:16:04 | Hey! Indeed, as it was written in the documentation a padding token is required. Seems that by default the padding side is set to `left`. We cannot update the `tokenization` file (for backward compatibility reasons) but we can update the tokenizers online to make sure they use `padding_side = right` by default. <|||||>... |
transformers | 25,021 | open | fp16 DDP training in 4.31.0 | ### System Info
pytorch 1.13.1
transformers==4.31.0
### Who can help?
Hi @sgugger ,
I used the 4.31.0 to train a Llama model with LoRA. I observe some problems with --fp16 training and I'm not sure if it is a bug in Trainer.py:
My model is like:
```
class MyModel(nn.Module):
def __init__(self, ... | 07-23-2023 07:58:35 | 07-23-2023 07:58:35 | Similar problem here. When using fp16 to train Llama2 with LoRA, always nan. Bf16 works well, but official Llama2 uses fp16.<|||||>Oh, I understand! It doesn't use the cuda.amp but uses accelerator to automatically handle the loss scale, right?
And the reason why fp16's gradient is large is that they're scaled gradi... |
transformers | 25,020 | open | GenerationMixin: model_kwargs not passed to model in assisted decoding | ### System Info
- `transformers` version: 4.31.0
- Platform: Linux-5.15.90.1-microsoft-standard-WSL2-x86_64-with-glibc2.31
- Python version: 3.11.4
- Huggingface_hub version: 0.16.4
- Safetensors version: 0.3.1
- Accelerate version: 0.21.0
- Accelerate config: not found
- PyTorch version (GPU?): 2.0.1 (True)
... | 07-22-2023 22:25:29 | 07-22-2023 22:25:29 | I'm happy to have a go at fixing this if a maintainer is willing to support.<|||||>@sinking-point thank you for spotting it! Yes, I'd be very happy to support you in fixing this :D <|||||>@gante No problem, thank you for offering to support.
I've come up against a problem. This is from the GPT2 `prepare_inputs_for_g... |
transformers | 25,019 | closed | Add saffu langauge model to the transformers library | # What does this PR do?
We upload a language model called SAFFU (self attention feed forward unit) to the huggingface with the theme of improving the computational efficiency in computing the attention distribution
| 07-22-2023 15:18:30 | 07-22-2023 15:18:30 | |
transformers | 25,018 | closed | Fix typo in LlamaTokenizerFast docstring example | # What does this PR do?
Fix typo in LlamaTokenizerFast docstring example
<!--
Congratulations! You've made it this far! You're not quite done yet though.
Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your ... | 07-22-2023 14:45:32 | 07-22-2023 14:45:32 | The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_25018). All of your documentation changes will be reflected on that endpoint. |
transformers | 25,017 | open | 🌐 [i18n-KO] Translated `add_tensorflow_model.md` to Korean | <!-- PR의 제목은 "🌐 [i18n-KO] Translated `add_tensorflow_model.md` to Korean" 으로 부탁드립니다 -->
# What does this PR do?
Translated the `add_tensorflow_model.md` file of the documentation to Korean 😄
Thank you in advance for your review!
Part of https://github.com/huggingface/transformers/issues/20179
<!-- 메인 이슈에 기록... | 07-22-2023 14:18:38 | 07-22-2023 14:18:38 | Please do not open and close four different PRs for the same file. You can update the original PR.<|||||>공들여 번역 및 수정을 통해 훌륭한 결과물이 나오신 것 같네요! 전체적으로 잘 읽히는 것 같습니다~ |
transformers | 25,016 | closed | 🌐 [i18n-KO] Translated `add_tensorflow_model.md` to Korean | <!-- PR의 제목은 "🌐 [i18n-KO] Translated `add_tensorflow_model.md` to Korean" 으로 부탁드립니다 -->
# What does this PR do?
Translated the `add_tensorflow_model.md` file of the documentation to Korean 😄
Thank you in advance for your review!
Part of https://github.com/huggingface/transformers/issues/20179
<!-- 메인 이슈에 기록... | 07-22-2023 13:49:41 | 07-22-2023 13:49:41 | |
transformers | 25,015 | closed | 🌐 [i18n-KO] Translated `add_tensorflow_model.md` to Korean | <!-- PR의 제목은 "🌐 [i18n-KO] Translated `add_tensorflow_model.md` to Korean" 으로 부탁드립니다 -->
# What does this PR do?
Translated the `your_file.md` file of the documentation to Korean 😄
Thank you in advance for your review!
Part of https://github.com/huggingface/transformers/issues/20179
<!-- 메인 이슈에 기록이 남아요! 가짜연구... | 07-22-2023 13:48:48 | 07-22-2023 13:48:48 | |
transformers | 25,014 | closed | When I use the command "python convert_llama_weights_to_hf.py --input_dir /xxx/llama/ --model_size 70B --output_dir /xxxx/Llama-2-70b-chat-hf" killed | ### System Info
Hi,@ArthurZucker,@younesbelkada
When I use the command "python convert_llama_weights_to_hf.py --input_dir /xxx/llama/ --model_size 70B --output_dir /xxxx/Llama-2-70b-chat-hf", the following error occurred:
<img width="1342" alt="image" src="https://github.com/huggingface/transformers/assets/44772254/... | 07-22-2023 12:38:34 | 07-22-2023 12:38:34 | Hi @cm-liushaodong
The llama-70B model weights file is at least 140GB in half precision, sadly I think that you need an instance of at least that CPU memory size to download the weights and load them in CPU memory. Maybe @ArthurZucker can confirm as he has used that script<|||||>Yes, as[ the documentation mentions, ]... |
transformers | 25,013 | closed | [i18n-<languageCode>] Translating docs to <languageName>czech republic | <!--
Note: Please search to see if an issue already exists for the language you are trying to translate.
-->
Hi!
Let's bring the documentation to all the <languageName>-speaking community 🌐 (currently 0 out of 267 complete)
Who would want to translate? Please follow the 🤗 [TRANSLATING guide](https://github.com/hug... | 07-22-2023 10:15:38 | 07-22-2023 10:15:38 | @Denyweeeed I would like to contribute to the Telugu language translation<|||||>Please properly fill the template when opening such issues. |
transformers | 25,012 | closed | [check_config_docstrings.py] improve diagnostics | It's difficult to know what to do when one gets an error:
```
python utils/check_config_docstrings.py
Traceback (most recent call last):
File "utils/check_config_docstrings.py", line 92, in <module>
check_config_docstrings_have_checkpoints()
File "utils/check_config_docstrings.py", line 88, in check_c... | 07-22-2023 07:25:00 | 07-22-2023 07:25:00 | _The documentation is not available anymore as the PR was closed or merged._ |
transformers | 25,011 | closed | Transformers 4.31.0 Runtime error trying to load model saved as 8bit on HF fails | ### System Info
Transformers 4.31.0
Python 3.10.6
Linux and Windows (Same issue on both)
Bitsandbytes 0.39.1 to 0.40x
### Who can help?
_No response_
### Information
- [ ] The official example scripts
- [X] My own modified scripts
### Tasks
- [X] An officially supported task in the `examples` folder (such a... | 07-22-2023 06:25:30 | 07-22-2023 06:25:30 | cc @younesbelkada <|||||>Hi @mediocreatmybest
Thanks for the very clean reproducer, I managed to repro the issue and propose a fix in https://github.com/huggingface/transformers/pull/25047
The fix should be now live on the main branch of transformers and you should be able to use that by installing transformers from... |
transformers | 25,010 | open | 🌐 [i18n-KO] Translated `philosophy.md` to Korean | # What does this PR do?
Translated the `philosophy.md` file of the documentation to Korean.
Thank you in advance for your review.
Part of https://github.com/huggingface/transformers/issues/20179
## Before reviewing
- [x] Check for missing / redundant translations (번역 누락/중복 검사)
- [x] Grammar Check (맞춤법 검사)
... | 07-22-2023 06:08:30 | 07-22-2023 06:08:30 | The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/transformers/pr_25010). All of your documentation changes will be reflected on that endpoint. |
transformers | 25,009 | closed | uploading saffu language model to the transformers library | # What does this PR do?
In this PR, we upload a new language model **SAFFU** (Self-Attention-Feed-Forward-Unit) to the HuggingFace transformers library. This model is super efficient to use and fast to train that we derive a super efficient way of computing the self-attention matrix with an explicit mathematical sol... | 07-22-2023 05:52:45 | 07-22-2023 05:52:45 | Need to fix some issues of the code |
transformers | 25,008 | closed | [bug] `token` not supported in `AutoModel` |
I see `use_auth_token` is already deprecated and will be replaced by `token`,
https://github.com/huggingface/transformers/blob/b257c46a075419c09e5ce5c5aa39bc346ecdb9a5/src/transformers/modeling_utils.py#L2196-L2204
But `AutoModel` doesn't accept the new argument `token` yet. Especially in https://github.com/hugg... | 07-22-2023 00:41:28 | 07-22-2023 00:41:28 | Could you let us know which version of transformers you are using? I just tried this on the main branch and it seems to work fine.<|||||>@sgugger
```
$ pip freeze | grep transformers
transformers @ git+https://github.com/huggingface/transformers.git@b08f41e62a41632195cb986fcc41d428a5bf1d56
```
Error Log for `... |
transformers | 25,007 | open | [ROCM] GFX906 gpu dosent work when GFX900 gpu is also in the system | ### System Info
System:
* ROCM 5.6
* torch-2.1.0.dev20230721+rocm5.6
* GFX900 GPU (MI25) (HIP device 2)
* GFX906 GPU (MI50) (HIP device 1)
* GFX1030 GPU (rx6800xt) (HIP device 0)
* transformers @b257c46a075419c09e5ce5c5aa39bc346ecdb9a5
* Linux 6.4.3 with AMDGPU p2p activated
companion bug against rocm: http... | 07-22-2023 00:15:58 | 07-22-2023 00:15:58 | This seems more of an issue for PyTorch and AMD? We only use those libraries in Transformers.<|||||>this is correct, this issue has since been tracked down here https://github.com/ROCmSoftwarePlatform/rocBLAS/issues/1346#issuecomment-1646942417
i will keep the bug here open untill its resolved so that any one else e... |
transformers | 25,006 | open | RuntimeError: element 0 of tensors does not require grad and does not have a grad_fn | ### System Info
- `transformers` version: 4.30.2
- Platform: Linux-5.15.120+-x86_64-with-glibc2.31
- Python version: 3.10.12
- Huggingface_hub version: 0.16.4
- Safetensors version: 0.3.1
- PyTorch version (GPU?): 2.0.0+cpu (False)
- Tensorflow version (GPU?): 2.12.0 (False)
- Flax version (CPU?/GPU?/TPU?): 0... | 07-21-2023 20:59:23 | 07-21-2023 20:59:23 | Even setting the model to train model with:
`self.bert.train()`
I get the same error.<|||||>Hey 👋🏻
We need a minimal reproducing script in order to help: you are using an external library `pytorch lightning` and I have no idea what is happening inside. `transformers` also has a trainer class, we can help if a ... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.