type stringclasses 2
values | source stringclasses 4
values | report stringclasses 1
value | contract stringclasses 1
value | severity stringclasses 3
values | contract_url stringclasses 31
values | findings listlengths 0 0 ⌀ | repo stringclasses 127
values | title stringlengths 4 407 ⌀ | body stringlengths 47 3k ⌀ | url stringlengths 60 86 ⌀ |
|---|---|---|---|---|---|---|---|---|---|---|
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-08-wildcat-findings | Wrong calculation of delinquent penalty time in `updateTimeDelinquentAndGetPenaltyTime` function | # Lines of code
https://github.com/code-423n4/2024-08-wildcat/blob/main/src/libraries/FeeMath.sol#L118
# Vulnerability details
## Impact
Because of the incorrect calculation of delinquent penalty time, a borrower gets charged much lower delinquency fee than intended.
## Proof of Concept
Over time, as market operat... | https://github.com/code-423n4/2024-08-wildcat-findings/issues/19 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-08-wildcat-findings | Incorrect use of `state.isDelinquent` in `updateTimeDelinquentAndGetPenaltyTime` function - total misbehavior of applying delinquency fee | # Lines of code
https://github.com/code-423n4/2024-08-wildcat/blob/main/src/libraries/FeeMath.sol#L96
https://github.com/code-423n4/2024-08-wildcat/blob/main/src/market/WildcatMarketBase.sol#L406
# Vulnerability details
## Impact
Due to the incorrect value of `state.isDelinquent`, the `updateTimeDelinquentAndGetPen... | https://github.com/code-423n4/2024-08-wildcat-findings/issues/18 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2024-08-wildcat-findings | The protocol has not charged the protocol fee. | # Lines of code
https://github.com/code-423n4/2024-08-wildcat/blob/fe746cc0fbedc4447a981a50e6ba4c95f98b9fe1/src/libraries/MarketState.sol#L15
# Vulnerability details
## Proof of Concept
The protocol has set `accruedProtocolFees` to represent the current protocol fees and `protocolFeeBips` to represent the protocol ... | https://github.com/code-423n4/2024-08-wildcat-findings/issues/5 |
confirmed_finding | code4rena | null | null | MEDIUM | null | null | 2024-08-wildcat-findings | Upgraded Q -> 2 from #17 [1728912210729] | Judge has assessed an item in Issue #17 as 2 risk. The relevant finding follows:
[L-01] AccessControlHooks::onQueueWithdrawal missing validation | https://github.com/code-423n4/2024-08-wildcat-findings/issues/123 |
confirmed_finding | code4rena | null | null | MEDIUM | null | null | 2024-08-wildcat-findings | Users are incentivized to not withdraw immediately after the market is closed. | # Lines of code
https://github.com/code-423n4/2024-08-wildcat/blob/main/src/market/WildcatMarketBase.sol#L665
# Vulnerability details
## Impact
Users are incentivized to not withdraw immediately after market is closed.
## Proof of Concept
Within a withdraw batch, all users within said batch are paid equally - at t... | https://github.com/code-423n4/2024-08-wildcat-findings/issues/121 |
confirmed_finding | code4rena | null | null | MEDIUM | null | null | 2024-08-wildcat-findings | A borrower can create a market with disabled `hookTemplate`. | # Lines of code
https://github.com/code-423n4/2024-08-wildcat/blob/fe746cc0fbedc4447a981a50e6ba4c95f98b9fe1/src/HooksFactory.sol#L491-L516
# Vulnerability details
## Impact
Borrower creates a market with the `hookTemplate` that was disabled. This may lead to undetermined consequences as it is not intended by the ad... | https://github.com/code-423n4/2024-08-wildcat-findings/issues/106 |
confirmed_finding | code4rena | null | null | MEDIUM | null | null | 2024-08-wildcat-findings | `WildcantMarketWithdrawals.sol::executeWithdrawals` function does not have validation check for the sufficient balance is there to repay all the address in the queue | # Lines of code
https://github.com/code-423n4/2024-08-wildcat/blob/fe746cc0fbedc4447a981a50e6ba4c95f98b9fe1/src/market/WildcatMarketWithdrawals.sol#L217
# Vulnerability details
## Impact
This will revert unexpectedly and user wont be able to withdraw funds. It also dont allow other queue address to withdraw funds ... | https://github.com/code-423n4/2024-08-wildcat-findings/issues/105 |
confirmed_finding | code4rena | null | null | MEDIUM | null | null | 2024-08-wildcat-findings | originationFeeAsset can be a sanctioned asset | # Lines of code
https://github.com/code-423n4/2024-08-wildcat/blob/fe746cc0fbedc4447a981a50e6ba4c95f98b9fe1/src/HooksFactory.sol#L120
# Vulnerability details
During market deployment borrowers are required to pay a `originationFeeAsset` by specifying an already listed `originationFeeAsset`.
however the protection... | https://github.com/code-423n4/2024-08-wildcat-findings/issues/104 |
confirmed_finding | code4rena | null | null | MEDIUM | null | null | 2024-08-wildcat-findings | Delinquency fee can be totally or partially avoided due to MarketState.isDelinquent only being updated at the end of a market operation | # Lines of code
https://github.com/code-423n4/2024-08-wildcat/blob/main/src/market/WildcatMarketBase.sol#L406
https://github.com/code-423n4/2024-08-wildcat/blob/main/src/market/WildcatMarketWithdrawals.sol#L283
https://github.com/code-423n4/2024-08-wildcat/blob/main/src/market/WildcatMarket.sol#L202
# Vulnerability ... | https://github.com/code-423n4/2024-08-wildcat-findings/issues/103 |
confirmed_finding | code4rena | null | null | MEDIUM | null | null | 2024-08-wildcat-findings | Borrower can lock `lender` funds in `market` via `WildcatMarket::closeMarket` | # Lines of code
https://github.com/code-423n4/2024-08-wildcat/blob/fe746cc0fbedc4447a981a50e6ba4c95f98b9fe1/src/market/WildcatMarket.sol#L226-L287
# Vulnerability details
## Impact
The `WildcatMarket::closeMarket` is callable only by the market's `borrower` should they decide to end a formerly operating `market`. ... | https://github.com/code-423n4/2024-08-wildcat-findings/issues/101 |
confirmed_finding | code4rena | null | null | MEDIUM | null | null | 2024-08-wildcat-findings | Repaying outstanding debt by the borrower will not clear the debt in the system thus the contract still incurs more debt after calling this function | # Lines of code
https://github.com/code-423n4/2024-08-wildcat/blob/fe746cc0fbedc4447a981a50e6ba4c95f98b9fe1/src/market/WildcatMarket.sol#L179-L184
# Vulnerability details
## Impact
When a borrower calls the `repayOutstandingDebt()` function, the expected behavior is that all outstanding debts should be repaid in fu... | https://github.com/code-423n4/2024-08-wildcat-findings/issues/100 |
confirmed_finding | code4rena | null | null | MEDIUM | null | null | 2024-08-wildcat-findings | Partially repaying unpaid batches will be broken if scale factor exceeds 2 | # Lines of code
https://github.com/code-423n4/2024-08-wildcat/blob/main/src/market/WildcatMarketBase.sol#L676
# Vulnerability details
## Proof of Concept
When partially repaying an `unpaid` batch, the current `availableLiquidity` is passed as an argument to the `_applyWithdrawalBatchPayment`
```solidity
function... | https://github.com/code-423n4/2024-08-wildcat-findings/issues/98 |
confirmed_finding | code4rena | null | null | MEDIUM | null | null | 2024-08-wildcat-findings | Incorrect Interest Accrual for Expired Withdrawal Batches After Repayment | # Lines of code
https://github.com/code-423n4/2024-08-wildcat/blob/fe746cc0fbedc4447a981a50e6ba4c95f98b9fe1/src/market/WildcatMarketBase.sol#L406-L431
# Vulnerability details
## Proof of Concept
The current implementation of interest accrual for withdrawal batches can potentially lead to a situation where an expire... | https://github.com/code-423n4/2024-08-wildcat-findings/issues/97 |
confirmed_finding | code4rena | null | null | MEDIUM | null | null | 2024-08-wildcat-findings | No State Update After Transfer in repayOutstandingDebt and repayDelinquentDebt Leads to Inaccurate Interest Accrual | # Lines of code
https://github.com/code-423n4/2024-08-wildcat/blob/fe746cc0fbedc4447a981a50e6ba4c95f98b9fe1/src/market/WildcatMarket.sol#L180-L183
https://github.com/code-423n4/2024-08-wildcat/blob/fe746cc0fbedc4447a981a50e6ba4c95f98b9fe1/src/market/WildcatMarket.sol#L186-L190
# Vulnerability details
The repayOutst... | https://github.com/code-423n4/2024-08-wildcat-findings/issues/96 |
confirmed_finding | code4rena | null | null | MEDIUM | null | null | 2024-08-wildcat-findings | The `annualInterestBips` of a market hooked by a fixed-term hook can be reduced at any time even when the fixed term time of the market has not yet elapsed | # Lines of code
https://github.com/code-423n4/2024-08-wildcat/blob/main/src/access/FixedTermLoanHooks.sol#L960-L978
# Vulnerability details
## Impact
If a borrower reduces the APR of a market before its fixed term time elapses:
- No lender can opt-out
- The borrower can reduce the APR to any value with no penalty
... | https://github.com/code-423n4/2024-08-wildcat-findings/issues/95 |
confirmed_finding | code4rena | null | null | MEDIUM | null | null | 2024-08-wildcat-findings | `HooksFactory#_deployMarket()` didn't check if `originationFeeAmount` is zero or not | # Lines of code
https://github.com/code-423n4/2024-08-wildcat/blob/main/src/HooksFactory.sol#L418-L424
# Vulnerability details
## Impact
Market deployment revert if `originationFeeAsset` does not support 0 value transfer while `originationFeeAmount` is 0
## Proof of Concept
The owner of `ArchController` can add a h... | https://github.com/code-423n4/2024-08-wildcat-findings/issues/94 |
confirmed_finding | code4rena | null | null | MEDIUM | null | null | 2024-08-wildcat-findings | Inherent Delayed Delinquency Status Update in WildcatMarket Contract | # Lines of code
https://github.com/code-423n4/2024-08-wildcat/blob/fe746cc0fbedc4447a981a50e6ba4c95f98b9fe1/src/market/WildcatMarketBase.sol#L540-L542
# Vulnerability details
## Proof of Concept
The WildcatMarket contract has the mechanism where the delinquency status of the market is not immediately updated when t... | https://github.com/code-423n4/2024-08-wildcat-findings/issues/93 |
confirmed_finding | code4rena | null | null | MEDIUM | null | null | 2024-08-wildcat-findings | `HooksFactory#deployMarket()` doesn't check whether the specified `hooksTemplate` is disabled | # Lines of code
https://github.com/code-423n4/2024-08-wildcat/blob/main/src/HooksFactory.sol#L491-L516
# Vulnerability details
## Impact
A borrower can deploy a market with previous deployed hook instance even its hook template has been disabled
## Proof of Concept
The Archcontroller owner can add a hook template ... | https://github.com/code-423n4/2024-08-wildcat-findings/issues/91 |
confirmed_finding | code4rena | null | null | MEDIUM | null | null | 2024-08-wildcat-findings | Lenders' funds is locked without interest in prematurely closed fixed-term loan markets | # Lines of code
https://github.com/code-423n4/2024-08-wildcat/blob/fe746cc0fbedc4447a981a50e6ba4c95f98b9fe1/src/access/FixedTermLoanHooks.sol#L857-L859
# Vulnerability details
## Proof of Concept
The current implementation of the Wildcat protocol can lead to a situation where lenders' funds are locked without earni... | https://github.com/code-423n4/2024-08-wildcat-findings/issues/87 |
confirmed_finding | code4rena | null | null | MEDIUM | null | null | 2024-08-wildcat-findings | Role provider permission escalation | # Lines of code
https://github.com/code-423n4/2024-08-wildcat/blob/fe746cc0fbedc4447a981a50e6ba4c95f98b9fe1/src/access/FixedTermLoanHooks.sol#L404-L413
# Vulnerability details
## Proof of Concept
The [`grantRole`](https://github.com/code-423n4/2024-08-wildcat/blob/fe746cc0fbedc4447a981a50e6ba4c95f98b9fe1/src/acces... | https://github.com/code-423n4/2024-08-wildcat-findings/issues/86 |
confirmed_finding | code4rena | null | null | MEDIUM | null | null | 2024-08-wildcat-findings | Anyone can call `AccessControlHooks.onQueueWithdrawal` to DOS lender's operation | # Lines of code
https://github.com/code-423n4/2024-08-wildcat/blob/fe746cc0fbedc4447a981a50e6ba4c95f98b9fe1/src/access/AccessControlHooks.sol#L812
# Vulnerability details
## Impact
1. `AccessControlHooks.onQueueWithdrawal` has no restrictions on calling and can be called by anyone.
2. Hook supports credential val... | https://github.com/code-423n4/2024-08-wildcat-findings/issues/83 |
confirmed_finding | code4rena | null | null | MEDIUM | null | null | 2024-08-wildcat-findings | Borrower can REVOKE A USER'S CREDENTIAL by Blocking the user instead of just preventing deposits, while the unblocking function if called will not return back the User's Revoked Role. | # Lines of code
https://github.com/code-423n4/2024-08-wildcat/blob/fe746cc0fbedc4447a981a50e6ba4c95f98b9fe1/src/access/FixedTermLoanHooks.sol#L406
https://github.com/code-423n4/2024-08-wildcat/blob/fe746cc0fbedc4447a981a50e6ba4c95f98b9fe1/src/access/FixedTermLoanHooks.sol#L482-L491
https://github.com/code-423n4/2024-0... | https://github.com/code-423n4/2024-08-wildcat-findings/issues/81 |
confirmed_finding | code4rena | null | null | MEDIUM | null | null | 2024-08-wildcat-findings | Borrowers can sidestep paying the needed APR for some supported assets | # Lines of code
https://github.com/code-423n4/2024-08-wildcat/blob/fe746cc0fbedc4447a981a50e6ba4c95f98b9fe1/README.md#L262
# Vulnerability details
### Proof of Concept
First, per the readMe, we should assume rebasing tokens are in scope, see https://github.com/code-423n4/2024-08-wildcat/blob/fe746cc0fbedc4447a981a... | https://github.com/code-423n4/2024-08-wildcat-findings/issues/80 |
confirmed_finding | code4rena | null | null | MEDIUM | null | null | 2024-08-wildcat-findings | `AccessControlHooks::onQueueWithdrawal` Missing Access Control Check | # Lines of code
https://github.com/code-423n4/2024-08-wildcat/blob/fe746cc0fbedc4447a981a50e6ba4c95f98b9fe1/src/access/AccessControlHooks.sol#L812
# Vulnerability details
## Proof of Concept
`AccessControlHooks::onQueueWithdrawal` is missing access verification. To exploit this call the function and pass the addres... | https://github.com/code-423n4/2024-08-wildcat-findings/issues/78 |
confirmed_finding | code4rena | null | null | MEDIUM | null | null | 2024-08-wildcat-findings | `FixedTermLoanHooks` allow Borrower to update Annual Interest before end of the "Fixed Term Period" | # Lines of code
https://github.com/code-423n4/2024-08-wildcat/blob/main/src/access/FixedTermLoanHooks.sol#L857-L859
https://github.com/code-423n4/2024-08-wildcat/blob/main/src/access/FixedTermLoanHooks.sol#L960-L978
# Vulnerability details
## Summary
While the documentation states that in case of 'fixed term' marke... | https://github.com/code-423n4/2024-08-wildcat-findings/issues/77 |
confirmed_finding | code4rena | null | null | MEDIUM | null | null | 2024-08-wildcat-findings | Inconsistent Interest Accrual After Withdrawal Batch Expiry | # Lines of code
https://github.com/code-423n4/2024-08-wildcat/blob/fe746cc0fbedc4447a981a50e6ba4c95f98b9fe1/src/market/WildcatMarketBase.sol#L476
# Vulnerability details
## Summary
The Wildcat protocol manages lending markets, tracking their state using the MarketState struct (). A key aspecat of this state is the... | https://github.com/code-423n4/2024-08-wildcat-findings/issues/76 |
confirmed_finding | code4rena | null | null | MEDIUM | null | null | 2024-08-wildcat-findings | `addRoleProvider` will revert if `providerAddress` is an EOA, while documentation state provider can be an EOA | # Lines of code
https://github.com/code-423n4/2024-08-wildcat/blob/main/src/access/AccessControlHooks.sol#L220-L220
https://github.com/code-423n4/2024-08-wildcat/blob/main/src/access/FixedTermLoanHooks.sol#L257-L257
# Vulnerability details
## Summary
`addRoleProvider` will revert if `providerAddress` is an EOA, whi... | https://github.com/code-423n4/2024-08-wildcat-findings/issues/74 |
confirmed_finding | code4rena | null | null | MEDIUM | null | null | 2024-08-wildcat-findings | `repayDeliquentDebt` is not effective, as the market will become delinquent again on next block | # Lines of code
https://github.com/code-423n4/2024-08-wildcat/blob/main/src/market/WildcatMarket.sol#L172-L172
https://github.com/code-423n4/2024-08-wildcat/blob/main/src/market/WildcatMarketBase.sol#L541-L542
# Vulnerability details
## Summary
`repayDelinquentDebt` allow a borrower to repay the exact amount necess... | https://github.com/code-423n4/2024-08-wildcat-findings/issues/73 |
confirmed_finding | code4rena | null | null | MEDIUM | null | null | 2024-08-wildcat-findings | The repayment is made after the market state is update in the `WildcatMarket.repayOutstandingDebt` and `WildcatMarket.repayDelinquentDebt` functions thus putting the borrower at a disadvantage | # Lines of code
https://github.com/code-423n4/2024-08-wildcat/blob/main/src/market/WildcatMarket.sol#L205-L208
https://github.com/code-423n4/2024-08-wildcat/blob/main/src/market/WildcatMarket.sol#L186-L187
https://github.com/code-423n4/2024-08-wildcat/blob/main/src/market/WildcatMarket.sol#L179-L180
https://github.com... | https://github.com/code-423n4/2024-08-wildcat-findings/issues/72 |
confirmed_finding | code4rena | null | null | MEDIUM | null | null | 2024-08-wildcat-findings | Invalid `hooks templates` could be used for market deployments in the `HooksFactory.deployMarket` function | # Lines of code
https://github.com/code-423n4/2024-08-wildcat/blob/main/src/HooksFactory.sol#L506-L515
https://github.com/code-423n4/2024-08-wildcat/blob/main/src/HooksFactory.sol#L530-L544
# Vulnerability details
## Vulnerability Details
The `HooksFactory.deployMarketAndHooks` function is used to deploy a hooks i... | https://github.com/code-423n4/2024-08-wildcat-findings/issues/71 |
confirmed_finding | code4rena | null | null | MEDIUM | null | null | 2024-08-wildcat-findings | Borrowers could still deploy market while the template is diabled | # Lines of code
https://github.com/code-423n4/2024-08-wildcat/blob/main/src/HooksFactory.sol#L506
# Vulnerability details
## Impact
Borrowers could still deploy market while the template is diabled, since HooksFactory.sol:deployMarket() doesn't check if HooksTemplate is existed and enbled.
## Proof of Concept
Arc... | https://github.com/code-423n4/2024-08-wildcat-findings/issues/67 |
confirmed_finding | code4rena | null | null | MEDIUM | null | null | 2024-08-wildcat-findings | Blacklisted Assets Can Be Used as Origination Fee Assets in Hooks Templates | # Lines of code
https://github.com/code-423n4/2024-08-wildcat/blob/fe746cc0fbedc4447a981a50e6ba4c95f98b9fe1/src/HooksFactory.sol#L120
# Vulnerability details
## Impact
The HooksFactory contract allows blacklisted assets to be set as origination fee assets when creating or updating hooks templates. This bypasses the... | https://github.com/code-423n4/2024-08-wildcat-findings/issues/66 |
confirmed_finding | code4rena | null | null | MEDIUM | null | null | 2024-08-wildcat-findings | FIFO queue is not strict enough | # Lines of code
https://github.com/code-423n4/2024-08-wildcat/blob/main/src/market/WildcatMarketBase.sol#L460
# Vulnerability details
## Impact
Current implementation slightly favours current expiry batch over unpaid old ones.
## Proof of Concept
Within `_getUpdateState`, there's a check if there's an outstanding ... | https://github.com/code-423n4/2024-08-wildcat-findings/issues/63 |
confirmed_finding | code4rena | null | null | MEDIUM | null | null | 2024-08-wildcat-findings | Inconsistency across multiple repaying functions causing lender to pay extra fees. | # Lines of code
https://github.com/code-423n4/2024-08-wildcat/blob/main/src/market/WildcatMarket.sol#L226
# Vulnerability details
## Impact
Inconsistency across multiple functions can cause borrower to pay extra fees
## Proof of Concept
Within functions such as `repay` and `repayAndProcessUnpaidWithdrawalBatches`,... | https://github.com/code-423n4/2024-08-wildcat-findings/issues/62 |
confirmed_finding | code4rena | null | null | MEDIUM | null | null | 2024-08-wildcat-findings | `FixedTermLoanHook` looks at `block.timestamp` instead of `expiry` | # Lines of code
https://github.com/code-423n4/2024-08-wildcat/blob/main/src/access/FixedTermLoanHooks.sol#L848
# Vulnerability details
## Impact
`FixedTermLoanHook` looks at `block.timestamp` instead of `expiry`
## Proof of Concept
The idea of `FixedTermLoanHook` is to only allow for withdrawals after a certain te... | https://github.com/code-423n4/2024-08-wildcat-findings/issues/60 |
confirmed_finding | code4rena | null | null | MEDIUM | null | null | 2024-08-wildcat-findings | Role providers can bypass intended restrictions and lower expiry set by other providers | # Lines of code
https://github.com/code-423n4/2024-08-wildcat/blob/main/src/access/FixedTermLoanHooks.sol#L413
# Vulnerability details
## Proof of Concept
If we look at the code comments, we'll see that role providers can update a user's credential only if at least one of the 3 is true:
- the previous credential's ... | https://github.com/code-423n4/2024-08-wildcat-findings/issues/57 |
confirmed_finding | code4rena | null | null | MEDIUM | null | null | 2024-08-wildcat-findings | Improper validation on the `HooksFactory::_validateFees` function precisely on the `OriginationFee`and `ProtocolFeeBips` parameters, Leading to a borrower deploying a market without paying the Origination Fee. | # Lines of code
https://github.com/code-423n4/2024-08-wildcat/blob/fe746cc0fbedc4447a981a50e6ba4c95f98b9fe1/src/HooksFactory.sol#L153-L170
# Vulnerability details
## Proof of Concept
In the wildcat protocol the archController adds a hook template with some key parameters `address hooksTemplate,string calldata na... | https://github.com/code-423n4/2024-08-wildcat-findings/issues/56 |
confirmed_finding | code4rena | null | null | MEDIUM | null | null | 2024-08-wildcat-findings | The penalty APR to be returned can be manipulated | # Lines of code
https://github.com/code-423n4/2024-08-wildcat/blob/fe746cc0fbedc4447a981a50e6ba4c95f98b9fe1/src/libraries/FeeMath.sol#L121
# Vulnerability details
## Impact
The penalty APR that is meant to be incurred can potentially be manipulated.
In certain scenarios, a borrower or another party could deliberate... | https://github.com/code-423n4/2024-08-wildcat-findings/issues/55 |
confirmed_finding | code4rena | null | null | MEDIUM | null | null | 2024-08-wildcat-findings | A `borrower` can remove itself from role providers of Hooks | # Lines of code
https://github.com/code-423n4/2024-08-wildcat/blob/main/src/access/AccessControlHooks.sol#L249-L259
https://github.com/code-423n4/2024-08-wildcat/blob/main/src/access/FixedTermLoanHooks.sol#L286-L296
# Vulnerability details
## Impact
Once the borrower is removed from the role providers, it cannot be... | https://github.com/code-423n4/2024-08-wildcat-findings/issues/53 |
confirmed_finding | code4rena | null | null | MEDIUM | null | null | 2024-08-wildcat-findings | No lender is able to exit even after the market is closed | # Lines of code
https://github.com/code-423n4/2024-08-wildcat/blob/main/src/access/FixedTermLoanHooks.sol#L848-L868
https://github.com/code-423n4/2024-08-wildcat/blob/main/src/access/FixedTermLoanHooks.sol#L943-L946
# Vulnerability details
## Impact
Lenders might not be able to exit even after the market is closed
... | https://github.com/code-423n4/2024-08-wildcat-findings/issues/52 |
confirmed_finding | code4rena | null | null | MEDIUM | null | null | 2024-08-wildcat-findings | `WildcatMarketConfig#nukeFromOrbit()` reverts even if the lender has been marked as sanctioned | # Lines of code
https://github.com/code-423n4/2024-08-wildcat/blob/main/src/market/WildcatMarketConfig.sol#L82-L88
# Vulnerability details
## Impact
The borrower of the market might not be able to force the sanctioned lender into a withdrawal request.
## Proof of Concept
When a borrower creates a market hooked by ... | https://github.com/code-423n4/2024-08-wildcat-findings/issues/51 |
confirmed_finding | code4rena | null | null | MEDIUM | null | null | 2024-08-wildcat-findings | Role providers cannot be EOAs as stated in the documentation. | # Lines of code
https://github.com/code-423n4/2024-08-wildcat/blob/fe746cc0fbedc4447a981a50e6ba4c95f98b9fe1/src/access/AccessControlHooks.sol#L220
https://github.com/code-423n4/2024-08-wildcat/blob/fe746cc0fbedc4447a981a50e6ba4c95f98b9fe1/src/access/FixedTermLoanHooks.sol#L254
# Vulnerability details
## Impact
The... | https://github.com/code-423n4/2024-08-wildcat-findings/issues/49 |
confirmed_finding | code4rena | null | null | MEDIUM | null | null | 2024-08-wildcat-findings | Reserved assets for withdrawals can be lower than they should | # Lines of code
https://github.com/code-423n4/2024-08-wildcat/blob/fe746cc0fbedc4447a981a50e6ba4c95f98b9fe1/src/market/WildcatMarket.sol#L59
https://github.com/code-423n4/2024-08-wildcat/blob/fe746cc0fbedc4447a981a50e6ba4c95f98b9fe1/src/market/WildcatMarketBase.sol#L430
# Vulnerability details
## Impact
Deposited a... | https://github.com/code-423n4/2024-08-wildcat-findings/issues/47 |
confirmed_finding | code4rena | null | null | MEDIUM | null | null | 2024-08-wildcat-findings | Accounts blocked from deposits can ultimately mimic the exact state as a depositor | # Lines of code
https://github.com/code-423n4/2024-08-wildcat/blob/fe746cc0fbedc4447a981a50e6ba4c95f98b9fe1/src/market/WildcatMarketToken.sol#L41
# Vulnerability details
## Proof of Concept
Invariant states the following:
*Accounts which are blocked from deposits, or which do not have a credential on markets which... | https://github.com/code-423n4/2024-08-wildcat-findings/issues/44 |
confirmed_finding | code4rena | null | null | MEDIUM | null | null | 2024-08-wildcat-findings | Excessive Interest and Fees Due to Multiple Repayments | # Lines of code
https://github.com/code-423n4/2024-08-wildcat/blob/main/src/market/WildcatMarket.sol#L202
# Vulnerability details
## Vulnerability Detail
The Wildcat protocol design stipulates that borrowers should pay lenders an agreed-upon Annual Percentage Rate (APR). For instance, if a lender deposits 100,000 ... | https://github.com/code-423n4/2024-08-wildcat-findings/issues/43 |
confirmed_finding | code4rena | null | null | MEDIUM | null | null | 2024-08-wildcat-findings | Inconsistent Access Control Allows Known Lenders to Bypass Deposit Restrictions via Transfers | # Lines of code
https://github.com/code-423n4/2024-08-wildcat/blob/fe746cc0fbedc4447a981a50e6ba4c95f98b9fe1/src/access/AccessControlHooks.sol#L769-L804
# Vulnerability details
## Proof of Concept
There is a inconsistency in how the isBlockedFromDeposits status is checked between deposit and transfer functions in th... | https://github.com/code-423n4/2024-08-wildcat-findings/issues/40 |
confirmed_finding | code4rena | null | null | MEDIUM | null | null | 2024-08-wildcat-findings | Borrower Can Permanently Invalidate Push Provider Credentials Through Block/Unblock Actions | # Lines of code
https://github.com/code-423n4/2024-08-wildcat/blob/fe746cc0fbedc4447a981a50e6ba4c95f98b9fe1/src/access/AccessControlHooks.sol#L447-L449
# Vulnerability details
The current implementation allows the borrower to permanently invalidate credentials provided by push providers through a sequence of blocki... | https://github.com/code-423n4/2024-08-wildcat-findings/issues/39 |
confirmed_finding | code4rena | null | null | MEDIUM | null | null | 2024-08-wildcat-findings | `onExecuteWithdrawal` hook uses an incorrect function signature definition | # Lines of code
https://github.com/code-423n4/2024-08-wildcat/blob/fe746cc0fbedc4447a981a50e6ba4c95f98b9fe1/src/types/HooksConfig.sol#L374-L426
https://github.com/code-423n4/2024-08-wildcat/blob/fe746cc0fbedc4447a981a50e6ba4c95f98b9fe1/src/market/WildcatMarketWithdrawals.sol#L255
https://github.com/code-423n4/2024-08-... | https://github.com/code-423n4/2024-08-wildcat-findings/issues/38 |
confirmed_finding | code4rena | null | null | MEDIUM | null | null | 2024-08-wildcat-findings | Sanctioned Addresses Can Bypass Checks Due to Incorrect Assembly Code | # Lines of code
https://github.com/code-423n4/2024-08-wildcat/blob/fe746cc0fbedc4447a981a50e6ba4c95f98b9fe1/src/market/WildcatMarketBase.sol#L254-L273
https://github.com/code-423n4/2024-08-wildcat/blob/fe746cc0fbedc4447a981a50e6ba4c95f98b9fe1/src/market/WildcatMarketBase.sol#L769-L792
# Vulnerability details
The `... | https://github.com/code-423n4/2024-08-wildcat-findings/issues/37 |
confirmed_finding | code4rena | null | null | MEDIUM | null | null | 2024-08-wildcat-findings | Increasing APR when reserve ratio is zero and borrower uses all the funds moves the account to delinquency | # Lines of code
https://github.com/code-423n4/2024-08-wildcat/blob/main/src/market/WildcatMarketConfig.sol#L123
# Vulnerability details
## Vulnerability Details
The Wildcat lending protocol allows borrowers to increase the Annual Percentage Rate (APR) of a market using the setAnnualInterestAndReserveRatioBips funct... | https://github.com/code-423n4/2024-08-wildcat-findings/issues/35 |
confirmed_finding | code4rena | null | null | MEDIUM | null | null | 2024-08-wildcat-findings | Lack of validation of the `FixedTermLoanHooks.setFixedTermEndTime` function can lead to unintended behaviour | # Lines of code
https://github.com/code-423n4/2024-08-wildcat/blob/main/src/access/FixedTermLoanHooks.sol#L188-L192
https://github.com/code-423n4/2024-08-wildcat/blob/main/src/access/FixedTermLoanHooks.sol#L238-L240
# Vulnerability details
## Proof of Concept
The `FixedTermLoanHooks.setFixedTermEndTime` function i... | https://github.com/code-423n4/2024-08-wildcat-findings/issues/33 |
confirmed_finding | code4rena | null | null | MEDIUM | null | null | 2024-08-wildcat-findings | Memory Corruption Risk in LibStoredInitCode Due to Scratch Space Overuse | # Lines of code
https://github.com/code-423n4/2024-08-wildcat/blob/main/src/libraries/LibStoredInitCode.sol#L60-L78
# Vulnerability details
## Vulnerability Description:
In the function `calculateCreate2Address` within the `LibStoredInitCode` library, the `create2Prefix, salt, and initCodeHash` are written to mem... | https://github.com/code-423n4/2024-08-wildcat-findings/issues/31 |
confirmed_finding | code4rena | null | null | MEDIUM | null | null | 2024-08-wildcat-findings | Allowed amounts for Deposit, Transfer, and Withdrawal are increasing as the scale factor increases with accumulated interest thus DoS the smaller fund operations | # Lines of code
https://github.com/code-423n4/2024-08-wildcat/blob/main/src/libraries/MarketState.sol#L76-L78
https://github.com/code-423n4/2024-08-wildcat/blob/main/src/market/WildcatMarket.sol#L67-L68
https://github.com/code-423n4/2024-08-wildcat/blob/main/src/market/WildcatMarketToken.sol#L74-L76
https://github.com... | https://github.com/code-423n4/2024-08-wildcat-findings/issues/30 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2023-01-biconomy-findings | SmartAccountFactory.sol - Account can be created for an owner and setting any entryPoint | # Lines of code
https://github.com/code-423n4/2023-01-biconomy/blob/main/scw-contracts/contracts/smart-contract-wallet/SmartAccountFactory.sol#L33
https://github.com/code-423n4/2023-01-biconomy/blob/main/scw-contracts/contracts/smart-contract-wallet/SmartAccount.sol#L166
# Vulnerability details
## Impact
Detailed d... | https://github.com/code-423n4/2023-01-biconomy-findings/issues/536 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2023-01-biconomy-findings | Relayers can steal extra fees from smart contract wallets on every transaction | # Lines of code
https://github.com/code-423n4/2023-01-biconomy/blob/53c8c3823175aeb26dee5529eeefa81240a406ba/scw-contracts/contracts/smart-contract-wallet/SmartAccount.sol#L192-L219
# Vulnerability details
## Impact
Relayers can take signed transactions and append zeroes to the signature parameter to artificially i... | https://github.com/code-423n4/2023-01-biconomy-findings/issues/535 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2023-01-biconomy-findings | Frontrunning `deployCounterFactualWallet` | # Lines of code
https://github.com/code-423n4/2023-01-biconomy/blob/main/scw-contracts/contracts/smart-contract-wallet/SmartAccountFactory.sol#L26-L39
# Vulnerability details
`_entryPoint` and `_handler` are not included in the salt, so a front-running attack could be possible for the same `_owner` and `_index` (sa... | https://github.com/code-423n4/2023-01-biconomy-findings/issues/522 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2023-01-biconomy-findings | Frontrunning of smart wallet deployment | # Lines of code
https://github.com/code-423n4/2023-01-biconomy/blob/53c8c3823175aeb26dee5529eeefa81240a406ba/scw-contracts/contracts/smart-contract-wallet/SmartAccountFactory.sol#L33-L75
# Vulnerability details
## Impact
Detailed description of the impact of this finding.
An attacker could obtain information about... | https://github.com/code-423n4/2023-01-biconomy-findings/issues/518 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2023-01-biconomy-findings | Failed transactions may lead to fund loss via replay attacks | # Lines of code
https://github.com/code-423n4/2023-01-biconomy/blob/main/scw-contracts/contracts/smart-contract-wallet/SmartAccount.sol#L192-L245
# Vulnerability details
## Impact
Failed transactions inside ```executeTransaction()``` will revert and make the nonces[] remain intact. Thus a replay attack with signatu... | https://github.com/code-423n4/2023-01-biconomy-findings/issues/514 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2023-01-biconomy-findings | The isContract function in LibAddress that uses EXTCODESIZE can be vulnerable to the "Contract Creation Code Execution" attack | # Lines of code
https://github.com/code-423n4/2023-01-biconomy/blob/main/scw-contracts/contracts/smart-contract-wallet/SmartAccount.sol#L121
# Vulnerability details
## Impact
It will allow the attacker to potentially execute malicious code in the _implementation contract at https://github.com/code-423n4/2023-01-bic... | https://github.com/code-423n4/2023-01-biconomy-findings/issues/510 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2023-01-biconomy-findings | Front-running of the relayers transaction | # Lines of code
https://github.com/code-423n4/2023-01-biconomy/blob/5df2e8f8c0fd3393b9ecdad9ef356955f07fbbdd/scw-contracts/contracts/smart-contract-wallet/aa-4337/core/EntryPoint.sol#L68
# Vulnerability details
## Description
While the relayer has a positive outcome from the execution of some of the user operation... | https://github.com/code-423n4/2023-01-biconomy-findings/issues/508 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2023-01-biconomy-findings | Destruction of the `SmartAccount` implementation | # Lines of code
https://github.com/code-423n4/2023-01-biconomy/blob/53c8c3823175aeb26dee5529eeefa81240a406ba/scw-contracts/contracts/smart-contract-wallet/SmartAccount.sol#L166
https://github.com/code-423n4/2023-01-biconomy/blob/53c8c3823175aeb26dee5529eeefa81240a406ba/scw-contracts/contracts/smart-contract-wallet/Sma... | https://github.com/code-423n4/2023-01-biconomy-findings/issues/496 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2023-01-biconomy-findings | Unsigned `tokenGasPriceFactor` parameter | # Lines of code
https://github.com/code-423n4/2023-01-biconomy/blob/5df2e8f8c0fd3393b9ecdad9ef356955f07fbbdd/scw-contracts/contracts/smart-contract-wallet/SmartAccount.sol#L239
https://github.com/code-423n4/2023-01-biconomy/blob/5df2e8f8c0fd3393b9ecdad9ef356955f07fbbdd/scw-contracts/contracts/smart-contract-wallet/Sma... | https://github.com/code-423n4/2023-01-biconomy-findings/issues/492 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2023-01-biconomy-findings | Uninialized or front-runnable `.init` function in proxy implementation contract | # Lines of code
https://github.com/code-423n4/2023-01-biconomy/blob/main/scw-contracts/contracts/smart-contract-wallet/SmartAccount.sol#L166
https://github.com/code-423n4/2023-01-biconomy/blob/main/scw-contracts/contracts/smart-contract-wallet/SmartAccountFactory.sol#L17
# Vulnerability details
# Uninialized or fro... | https://github.com/code-423n4/2023-01-biconomy-findings/issues/491 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2023-01-biconomy-findings | Theft of funds under relaying the transaction | # Lines of code
https://github.com/code-423n4/2023-01-biconomy/blob/main/scw-contracts/contracts/smart-contract-wallet/SmartAccount.sol#L200
https://github.com/code-423n4/2023-01-biconomy/blob/main/scw-contracts/contracts/smart-contract-wallet/SmartAccount.sol#L239
https://github.com/code-423n4/2023-01-biconomy/blob/m... | https://github.com/code-423n4/2023-01-biconomy-findings/issues/489 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2023-01-biconomy-findings | Lack of owner verification in EIP-1271 signature check | # Lines of code
https://github.com/code-423n4/2023-01-biconomy/blob/53c8c3823175aeb26dee5529eeefa81240a406ba/scw-contracts/contracts/smart-contract-wallet/SmartAccount.sol#L218
https://github.com/code-423n4/2023-01-biconomy/blob/53c8c3823175aeb26dee5529eeefa81240a406ba/scw-contracts/contracts/smart-contract-wallet/Sma... | https://github.com/code-423n4/2023-01-biconomy-findings/issues/486 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2023-01-biconomy-findings | Replay attack on different batchId | # Lines of code
https://github.com/code-423n4/2023-01-biconomy/blob/53c8c3823175aeb26dee5529eeefa81240a406ba/scw-contracts/contracts/smart-contract-wallet/SmartAccount.sol#L194
https://github.com/code-423n4/2023-01-biconomy/blob/53c8c3823175aeb26dee5529eeefa81240a406ba/scw-contracts/contracts/smart-contract-wallet/Sma... | https://github.com/code-423n4/2023-01-biconomy-findings/issues/485 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2023-01-biconomy-findings | Front-running "deployCounterFactualWallet" | # Lines of code
https://github.com/code-423n4/2023-01-biconomy/blob/main/scw-contracts/contracts/smart-contract-wallet/SmartAccountFactory.sol#L33
# Vulnerability details
## Description
The `deployCounterFactualWallet` function deploys a smart wallet using the `create2` function with a salt value that depends on t... | https://github.com/code-423n4/2023-01-biconomy-findings/issues/482 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2023-01-biconomy-findings | Attacker can take control over each SmartAccount proxy and steal all users' funds | # Lines of code
https://github.com/code-423n4/2023-01-biconomy/blob/main/scw-contracts/contracts/smart-contract-wallet/SmartAccount.sol#L342
# Vulnerability details
# Attacker can take control over each SmartAccount proxy and steal all users' funds
## Impact
All users' funds can be stolen by a single attacker (tx ... | https://github.com/code-423n4/2023-01-biconomy-findings/issues/477 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2023-01-biconomy-findings | SmartAccount implementation contract can be destroyed by anyone | # Lines of code
https://github.com/code-423n4/2023-01-biconomy/blob/main/scw-contracts/contracts/smart-contract-wallet/SmartAccount.sol#L192
https://github.com/code-423n4/2023-01-biconomy/blob/main/scw-contracts/contracts/smart-contract-wallet/SmartAccount.sol#L302-L353
https://github.com/code-423n4/2023-01-biconomy/b... | https://github.com/code-423n4/2023-01-biconomy-findings/issues/476 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2023-01-biconomy-findings | SmartAccount implementation contract can be destroyed by owner | # Lines of code
https://github.com/code-423n4/2023-01-biconomy/blob/main/scw-contracts/contracts/smart-contract-wallet/SmartAccountFactory.sol#L17
# Vulnerability details
# SmartAccount implementation contract can be destroyed by owner
## Impact
Locking users' funds forever due to DoS for all deployed smart accoun... | https://github.com/code-423n4/2023-01-biconomy-findings/issues/474 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2023-01-biconomy-findings | The owner's address is not declared as payable | # Lines of code
https://github.com/code-423n4/2023-01-biconomy/blob/main/scw-contracts/contracts/smart-contract-wallet/SmartAccount.sol#L51
https://github.com/code-423n4/2023-01-biconomy/blob/main/scw-contracts/contracts/smart-contract-wallet/SmartAccount.sol#L172
# Vulnerability details
## Impact
If someone sends ... | https://github.com/code-423n4/2023-01-biconomy-findings/issues/471 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2023-01-biconomy-findings | when the 'v' value from a signature is 0, checkSignatures function can be tricked | # Lines of code
https://github.com/code-423n4/2023-01-biconomy/blob/53c8c3823175aeb26dee5529eeefa81240a406ba/scw-contracts/contracts/smart-contract-wallet/SmartAccount.sol#L314-L343
# Vulnerability details
## Impact
when the v value of a signature is = 0, the 'checkSignatures' in entryPoint function doesn't check i... | https://github.com/code-423n4/2023-01-biconomy-findings/issues/470 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2023-01-biconomy-findings | Signature Replay Attack when EntryPoint contract is changed | # Lines of code
https://github.com/code-423n4/2023-01-biconomy/blob/main/scw-contracts/contracts/smart-contract-wallet/paymasters/verifying/singleton/VerifyingSingletonPaymaster.sol#L77-L90
# Vulnerability details
# Signature Replay Attack when EntryPoint contract is changed
## Impact
User operations can be replay... | https://github.com/code-423n4/2023-01-biconomy-findings/issues/469 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2023-01-biconomy-findings | Deny of service in `SmartAccountFactory` | # Lines of code
https://github.com/code-423n4/2023-01-biconomy/blob/53c8c3823175aeb26dee5529eeefa81240a406ba/scw-contracts/contracts/smart-contract-wallet/SmartAccountFactory.sol#L34
# Vulnerability details
## Impact
The `salt` used for create2 does not include information from the `init` method, so it is vulnerabl... | https://github.com/code-423n4/2023-01-biconomy-findings/issues/464 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2023-01-biconomy-findings | Attacker can gain control of counterfactual wallet | # Lines of code
https://github.com/code-423n4/2023-01-biconomy/blob/main/scw-contracts/contracts/smart-contract-wallet/SmartAccountFactory.sol#L33-L45
# Vulnerability details
A counterfactual wallet can be used by pre-generating its address using the `SmartAccountFactory.getAddressForCounterfactualWallet` function.... | https://github.com/code-423n4/2023-01-biconomy-findings/issues/460 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2023-01-biconomy-findings | SmartAccount wallet creation can be backdoored | # Lines of code
https://github.com/code-423n4/2023-01-biconomy/blob/main/scw-contracts/contracts/smart-contract-wallet/SmartAccountFactory.sol#L53
# Vulnerability details
At wallet creation time, an attacker can temporarily swap the address of the entrypoint to install a backdoor in the form of a registered module ... | https://github.com/code-423n4/2023-01-biconomy-findings/issues/458 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2023-01-biconomy-findings | An attacker can create a smart contract wallet with a malicious config and the address that the user expects his smart contract to have | # Lines of code
https://github.com/code-423n4/2023-01-biconomy/blob/main/scw-contracts/contracts/smart-contract-wallet/SmartAccountFactory.sol#L33
# Vulnerability details
## Issue
A deployCounterFactualWallet function in the SmartAccountFactory.sol uses create2 command to deploy a smart contract wallet with the add... | https://github.com/code-423n4/2023-01-biconomy-findings/issues/456 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2023-01-biconomy-findings | SmartAccount authorization can be bypassed using a contract signature | # Lines of code
https://github.com/code-423n4/2023-01-biconomy/blob/main/scw-contracts/contracts/smart-contract-wallet/SmartAccount.sol#L314-L343
# Vulnerability details
# SmartAccount authorization can be bypassed using a contract signature
The `SmartAccount` wallet supports contract signatures defined by EIP1271... | https://github.com/code-423n4/2023-01-biconomy-findings/issues/449 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2023-01-biconomy-findings | `tokenGasPriceFactor` in `FeeRefund` struct can be malleable in calls to `execTransaction` | # Lines of code
https://github.com/code-423n4/2023-01-biconomy/blob/main/scw-contracts/contracts/smart-contract-wallet/SmartAccount.sol#L424-L446
# Vulnerability details
The `execTransaction` function present in the `SmartAccount` contract is susceptible to a malleability attack.
This is due to the fact that the `... | https://github.com/code-423n4/2023-01-biconomy-findings/issues/447 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2023-01-biconomy-findings | SmartAccount implementation can be destroyed by a bad actor | # Lines of code
https://github.com/code-423n4/2023-01-biconomy/blob/main/scw-contracts/contracts/smart-contract-wallet/SmartAccount.sol#L166
# Vulnerability details
The SmartAccount wallet architecture is mainly defined by a `Proxy` contract that delegates functionality to a common reusable `SmartAccount` implement... | https://github.com/code-423n4/2023-01-biconomy-findings/issues/443 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2023-01-biconomy-findings | Attacker can bypass signature validation and send arbitrary transactions to be executed by smart wallet. | # Lines of code
https://github.com/code-423n4/2023-01-biconomy/blob/53c8c3823175aeb26dee5529eeefa81240a406ba/scw-contracts/contracts/smart-contract-wallet/SmartAccount.sol#L314-L343
# Vulnerability details
## Impact
On `SmartAccount.sol` logic to handle contract signatures there is no validation of which contracts ... | https://github.com/code-423n4/2023-01-biconomy-findings/issues/433 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2023-01-biconomy-findings | The Smart Account can be generated in duplicate, and the attacker uses it by frontrunning the wallet generation process. | # Lines of code
https://github.com/code-423n4/2023-01-biconomy/blob/53c8c3823175aeb26dee5529eeefa81240a406ba/scw-contracts/contracts/smart-contract-wallet/SmartAccountFactory.sol#L33-L45
https://github.com/code-423n4/2023-01-biconomy/blob/53c8c3823175aeb26dee5529eeefa81240a406ba/scw-contracts/contracts/smart-contract-... | https://github.com/code-423n4/2023-01-biconomy-findings/issues/426 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2023-01-biconomy-findings | Transaction replay is possible due to the use of mapping of nonces | # Lines of code
https://github.com/code-423n4/2023-01-biconomy/blob/53c8c3823175aeb26dee5529eeefa81240a406ba/scw-contracts/contracts/smart-contract-wallet/SmartAccount.sol#L204-L219
# Vulnerability details
## Impact
Due to the use of a mapping of nonces, instead of a single one, on certain cases transaction replay ... | https://github.com/code-423n4/2023-01-biconomy-findings/issues/424 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2023-01-biconomy-findings | Replay attack on UserOperation if the smart account is not deployed before | # Lines of code
https://github.com/code-423n4/2023-01-biconomy/blob/5df2e8f8c0fd3393b9ecdad9ef356955f07fbbdd/scw-contracts/contracts/smart-contract-wallet/BaseSmartAccount.sol#L64
# Vulnerability details
## Impact
During handling an UserOperation, if the smart account is not deployed already, it will be created an... | https://github.com/code-423n4/2023-01-biconomy-findings/issues/420 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2023-01-biconomy-findings | `tokenGasPriceFactor` can be changed to either maximize gas refund or minimize it | # Lines of code
https://github.com/code-423n4/2023-01-biconomy/blob/main/scw-contracts/contracts/smart-contract-wallet/SmartAccount.sol#L431-L443
# Vulnerability details
## Description
`tokenGasPriceFactor` is used to calculate how much tokens that are going to be returned to cover gas costs:
```javascript
File: S... | https://github.com/code-423n4/2023-01-biconomy-findings/issues/414 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2023-01-biconomy-findings | Owner could brick all proxies by overwriting the implementation contract and making `updateImplementation` unusable | # Lines of code
https://github.com/code-423n4/2023-01-biconomy/blob/53c8c3823175aeb26dee5529eeefa81240a406ba/scw-contracts/contracts/smart-contract-wallet/SmartAccount.sol#L120-L125
https://github.com/code-423n4/2023-01-biconomy/blob/53c8c3823175aeb26dee5529eeefa81240a406ba/scw-contracts/contracts/smart-contract-walle... | https://github.com/code-423n4/2023-01-biconomy-findings/issues/412 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2023-01-biconomy-findings | A malicious user can make other's smart wallet invoke any external contract by deploying the smart wallet | # Lines of code
https://github.com/code-423n4/2023-01-biconomy/blob/53c8c3823175aeb26dee5529eeefa81240a406ba/scw-contracts/contracts/smart-contract-wallet/SmartAccountFactory.sol#L33
https://github.com/code-423n4/2023-01-biconomy/blob/53c8c3823175aeb26dee5529eeefa81240a406ba/scw-contracts/contracts/smart-contract-wall... | https://github.com/code-423n4/2023-01-biconomy-findings/issues/407 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2023-01-biconomy-findings | Deploy wallet for another user with fake entityPoint or handler | # Lines of code
https://github.com/code-423n4/2023-01-biconomy/blob/53c8c3823175aeb26dee5529eeefa81240a406ba/scw-contracts/contracts/smart-contract-wallet/SmartAccountFactory.sol#L33
https://github.com/code-423n4/2023-01-biconomy/blob/53c8c3823175aeb26dee5529eeefa81240a406ba/scw-contracts/contracts/smart-contract-wall... | https://github.com/code-423n4/2023-01-biconomy-findings/issues/404 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2023-01-biconomy-findings | User pays more to unstake | # Lines of code
https://github.com/code-423n4/2023-01-biconomy/blob/53c8c3823175aeb26dee5529eeefa81240a406ba/scw-contracts/contracts/smart-contract-wallet/aa-4337/core/StakeManager.sol#L48
# Vulnerability details
## Impact
In function:
function depositTo(address account) public payable {
internalIn... | https://github.com/code-423n4/2023-01-biconomy-findings/issues/401 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2023-01-biconomy-findings | Wrong verification of isContract | # Lines of code
https://github.com/code-423n4/2023-01-biconomy/blob/53c8c3823175aeb26dee5529eeefa81240a406ba/scw-contracts/contracts/smart-contract-wallet/paymasters/verifying/singleton/VerifyingSingletonPaymaster.sol#L49
# Vulnerability details
## Impact
Bypass security concerns from the protocol in terms of using... | https://github.com/code-423n4/2023-01-biconomy-findings/issues/394 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2023-01-biconomy-findings | EIP-1271 contract signing lets anyone execute any tx from the wallet | # Lines of code
https://github.com/code-423n4/2023-01-biconomy/blob/main/scw-contracts/contracts/smart-contract-wallet/SmartAccount.sol#L314-L343
# Vulnerability details
## Description
The `checkSignatures` in `SmartAccount` is copied from [Gnosis](https://github.com/safe-global/safe-contracts/blob/main/contracts/G... | https://github.com/code-423n4/2023-01-biconomy-findings/issues/382 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2023-01-biconomy-findings | Meeting the requirement for an individual nonce for signatures | # Lines of code
https://github.com/code-423n4/2023-01-biconomy/blob/53c8c3823175aeb26dee5529eeefa81240a406ba/scw-contracts/contracts/smart-contract-wallet/SmartAccount.sol#L192
https://github.com/code-423n4/2023-01-biconomy/blob/53c8c3823175aeb26dee5529eeefa81240a406ba/scw-contracts/contracts/smart-contract-wallet/Sma... | https://github.com/code-423n4/2023-01-biconomy-findings/issues/371 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2023-01-biconomy-findings | `userOperation` with `initCode` can be frontran | # Lines of code
https://github.com/code-423n4/2023-01-biconomy/blob/main/scw-contracts/contracts/smart-contract-wallet/SmartAccountFactory.sol#L38
https://github.com/code-423n4/2023-01-biconomy/blob/main/scw-contracts/contracts/smart-contract-wallet/SmartAccountFactory.sol#L40
# Vulnerability details
## Impact
Ever... | https://github.com/code-423n4/2023-01-biconomy-findings/issues/369 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2023-01-biconomy-findings | An attacker can execute any transaction by passed own contract signature validator | # Lines of code
https://github.com/code-423n4/2023-01-biconomy/blob/53c8c3823175aeb26dee5529eeefa81240a406ba/scw-contracts/contracts/smart-contract-wallet/SmartAccount.sol#L196
https://github.com/code-423n4/2023-01-biconomy/blob/53c8c3823175aeb26dee5529eeefa81240a406ba/scw-contracts/contracts/smart-contract-wallet/Sma... | https://github.com/code-423n4/2023-01-biconomy-findings/issues/367 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2023-01-biconomy-findings | deployCounterFactualWallet frontrunning/pre-deployment risks | # Lines of code
https://github.com/code-423n4/2023-01-biconomy/blob/53c8c3823175aeb26dee5529eeefa81240a406ba/scw-contracts/contracts/smart-contract-wallet/base/FallbackManager.sol#L32-L52
https://github.com/code-423n4/2023-01-biconomy/blob/53c8c3823175aeb26dee5529eeefa81240a406ba/scw-contracts/contracts/smart-contract... | https://github.com/code-423n4/2023-01-biconomy-findings/issues/364 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2023-01-biconomy-findings | Bypass Authentication | # Lines of code
https://github.com/code-423n4/2023-01-biconomy/blob/main/scw-contracts/contracts/smart-contract-wallet/SmartAccount.sol#L342
# Vulnerability details
## Impact
By using a smart contract to return the expected magic value an operator can bypass authentication checks in `SmartAccount`.
Bypassing the a... | https://github.com/code-423n4/2023-01-biconomy-findings/issues/358 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2023-01-biconomy-findings | Attacker can selfdestruct the code/logic of SmartAccount's implementation contract, leading to permanent loss of funds, of the owner of SmartAccount | # Lines of code
1. init() which gives ownership to attacker: https://github.com/code-423n4/2023-01-biconomy/blob/main/scw-contracts/contracts/smart-contract-wallet/SmartAccount.sol#L166
2. execFromEntryPoint() which will be called, to delegate calls to malicious contract: https://github.com/code-423n4/2023-01-biconomy... | https://github.com/code-423n4/2023-01-biconomy-findings/issues/357 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2023-01-biconomy-findings | SmartAccount.checkSignatures() does not check correctly when v is 0 | # Lines of code
https://github.com/code-423n4/2023-01-biconomy/blob/53c8c3823175aeb26dee5529eeefa81240a406ba/scw-contracts/contracts/smart-contract-wallet/SmartAccount.sol#L302
# Vulnerability details
## Impact
All SmartAccount contracts can be hacked, assets can be stolen, arbitrary functions can be called by hack... | https://github.com/code-423n4/2023-01-biconomy-findings/issues/347 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2023-01-biconomy-findings | Missing EIP1271 _signer validation | # Lines of code
https://github.com/code-423n4/2023-01-biconomy/blob/53c8c3823175aeb26dee5529eeefa81240a406ba/scw-contracts/contracts/smart-contract-wallet/SmartAccount.sol#L314-L343
# Vulnerability details
## Impact
SmartAccount.execTransaction allows the execution of a transaction signed by the owner. If the owner... | https://github.com/code-423n4/2023-01-biconomy-findings/issues/334 |
confirmed_finding | code4rena | null | null | HIGH | null | null | 2023-01-biconomy-findings | Attackers can control any smart contract wallet by deploying it | # Lines of code
https://github.com/code-423n4/2023-01-biconomy/blob/53c8c3823175aeb26dee5529eeefa81240a406ba/scw-contracts/contracts/smart-contract-wallet/SmartAccount.sol#L166-L176
https://github.com/code-423n4/2023-01-biconomy/blob/53c8c3823175aeb26dee5529eeefa81240a406ba/scw-contracts/contracts/smart-contract-walle... | https://github.com/code-423n4/2023-01-biconomy-findings/issues/331 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.