Sandpies Claude Opus 5 commited on
Commit
37dbe80
·
1 Parent(s): a60407d

Say which ComfyUI this needs, because it is a hard floor

Browse files

The registry had no compatibility metadata for this pack at all, so Manager
would offer it to anyone. It does not work on anyone: h3_ref_chain.py imports
MiniMaxH3AddGuide at module load and refuses to start without it, and that node
first appears in ComfyUI v0.34.0. On v0.30.0 through v0.33.1 -- which do have
H3, and do have the other two Core nodes this pack calls -- the install fails at
import with a message that now names the version instead of leaving the reader
to work it out.

`requires-comfyui = ">=0.34.0"` is what comfy-cli reads into
supported_comfyui_version.

No upper bound, and that is a measured claim rather than optimism. Master
reorders MiniMaxH3ReferenceToVideo -- vae and audio_vae move from positions 2-3
to defaulted keywords at the end -- which is exactly the change that broke a
user once. Binding this pack's keyword set against master's signature succeeds;
binding the old positional form raises "multiple values for argument
'ref_image_size'", the same error that prompted check_core_calls.py. The
parameter NAMES have been identical from v0.30.0 to master.

Not published: 2.0.0 is immutable and currently Pending, so this metadata takes
effect in whatever version ships next.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PLXmbwfdXirQ5oFreXPcMi

Files changed (2) hide show
  1. h3_ref_chain.py +3 -2
  2. pyproject.toml +11 -0
h3_ref_chain.py CHANGED
@@ -60,8 +60,9 @@ except ImportError as _exc: # pragma: no cover - depends on the host build
60
  # refuses to load -- it just says why.
61
  raise ImportError(
62
  "Hand Tie Clips needs MiniMax H3 support in ComfyUI itself "
63
- "(comfy_extras/nodes_minimax_h3.py, ComfyUI PR #15439). Update ComfyUI "
64
- "to a build that ships it, then restart. Original error: %s" % _exc
 
65
  ) from _exc
66
  from nodes import VAEDecode
67
 
 
60
  # refuses to load -- it just says why.
61
  raise ImportError(
62
  "Hand Tie Clips needs MiniMax H3 support in ComfyUI itself "
63
+ "(comfy_extras/nodes_minimax_h3.py, ComfyUI PR #15439), v0.34.0 or "
64
+ "newer -- MiniMaxH3AddGuide does not exist before that. Update "
65
+ "ComfyUI, then restart. Original error: %s" % _exc
66
  ) from _exc
67
  from nodes import VAEDecode
68
 
pyproject.toml CHANGED
@@ -24,6 +24,17 @@ Documentation = "https://github.com/dntpi/ComfyUI-Hand-Tie-Clips/blob/main/PROMP
24
  # and immutable -- it is in the registry URL -- so it is not a field to tidy.
25
  # Neither it nor Repository is needed to install the pack by hand or from a zip.
26
  [tool.comfy]
 
 
 
 
 
 
 
 
 
 
 
27
  PublisherId = "sandpies"
28
  DisplayName = "Hand Tie Clips"
29
  # Square, 400x400. The specifications page requires square and <=400x400; the
 
24
  # and immutable -- it is in the registry URL -- so it is not a field to tidy.
25
  # Neither it nor Repository is needed to install the pack by hand or from a zip.
26
  [tool.comfy]
27
+ # The registry reads this as supported_comfyui_version. 0.34.0 is a HARD floor,
28
+ # not a preference: h3_ref_chain.py imports MiniMaxH3AddGuide at module load and
29
+ # refuses to start without it, and that node first appears in v0.34.0. The other
30
+ # two Core nodes this pack calls go back to v0.30.0, where H3 support landed, but
31
+ # AddGuide is the binding one.
32
+ #
33
+ # No upper bound. Core's parameter ORDER is not a contract and has already moved
34
+ # once -- master reorders MiniMaxH3ReferenceToVideo so vae/audio_vae come last
35
+ # and optional -- but every call here is by NAME, and the names have been stable
36
+ # from v0.30.0 through master. tools/check_core_calls.py is what keeps that true.
37
+ requires-comfyui = ">=0.34.0"
38
  PublisherId = "sandpies"
39
  DisplayName = "Hand Tie Clips"
40
  # Square, 400x400. The specifications page requires square and <=400x400; the