id stringlengths 40 40 | instruction stringlengths 68 308 | input stringlengths 17 33.4k | output stringlengths 100 30k |
|---|---|---|---|
bc86120a85ebf553180946e8854d1993f074e9f5 | Analyze and fix the following issue in the Linux kernel code: [PATCH] SCSI GFP fixes | Problem Details:
Somebody forgot that | has higher priority than ?:. As the result,
allocation is done with bogus flags - instead of GFP_ATOMIC + possibly
GFP_DMA we always get GFP_DMA and no GFP_ATOMIC.
Signed-off-by: Al Viro <viro@parcelfarce.linux.theplanet.co.uk>
Signed-off-by: Linus Torvalds <torvalds@osdl.org> | ```diff
diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c
index 1a135f38e78d..2bf1ee2b47b6 100644
--- a/drivers/scsi/scsi_error.c
+++ b/drivers/scsi/scsi_error.c
@@ -584,7 +584,7 @@ static int scsi_request_sense(struct scsi_cmnd *scmd)
memcpy(scmd->cmnd, generic_sense, sizeof(generic_sense));
- s... |
9719b0c298bd6a4a608843dc989a5f94cd0a7c13 | Analyze and fix the following issue in the Linux kernel code: [PATCH] USB: Fix for ati_remote | Problem Details:
when stealing code from ati_remote for a GPL-driver of my usbradio (because of
its neat usb int transfers) I found out, that the inbuf is freed twice.
I don't have the ati-remote, so I don't know it is a problem at all, but it
looks strange to me anyway. Also I don't know if it has been fixed already ... | ```diff
diff --git a/drivers/usb/input/ati_remote.c b/drivers/usb/input/ati_remote.c
index 355add5c29f5..860df26323b1 100644
--- a/drivers/usb/input/ati_remote.c
+++ b/drivers/usb/input/ati_remote.c
@@ -619,7 +619,7 @@ static void ati_remote_delete(struct ati_remote *ati_remote)
if (ati_remote->outbuf)
usb_buf... |
f3fae6ed6aafe71826e03876ad3d4e1d3f238ec8 | Analyze and fix the following issue in the Linux kernel code: [PATCH] USB: better usbnet zaurus/mdlm/... fix | Problem Details:
This is a somewhat more comprehensive fix for the problem of devices
like the newer Zaurii ... or in this case some Motorola cell phones.
To recap, the problem's root cause is that these devices aren't using
standard USB class specifications for their network links, and so far
we've had to add lots of... | ```diff
diff --git a/drivers/usb/net/usbnet.c b/drivers/usb/net/usbnet.c
index 0eefc14449aa..1748159e462e 100644
--- a/drivers/usb/net/usbnet.c
+++ b/drivers/usb/net/usbnet.c
@@ -1,6 +1,6 @@
/*
* USB Networking Links
- * Copyright (C) 2000-2003 by David Brownell <dbrownell@users.sourceforge.net>
+ * Copyright (C) 20... |
b19dcd9341a81ff6e04fcec396f77eeb91570584 | Analyze and fix the following issue in the Linux kernel code: [PATCH] USB: scripts/mod/file2alias.c: handle numeric ranges for USB bcdDevice | Problem Details:
Another attempt at that...
The attached patch fixes the longstanding problem with USB bcdDevice
numeric ranges incorrectly converted into patterns for MODULE_ALIAS
generation. Previously it put both the lower and the upper limits into
the pattern, dlXdhY, making it impossible to fnmatch against excep... | ```diff
diff --git a/scripts/mod/file2alias.c b/scripts/mod/file2alias.c
index d54b52d3bb6f..32197efe67ed 100644
--- a/scripts/mod/file2alias.c
+++ b/scripts/mod/file2alias.c
@@ -47,32 +47,31 @@ do { \
sprintf(str + strlen(str), "*"); ... |
35ecc486a3f1811b85b7b22196b8b7422d713b51 | Analyze and fix the following issue in the Linux kernel code: [PATCH] USB: fix up the HP49G+ Calculator USB Serial driver | Problem Details:
Fix compiler warnings, and remove unneeded #includes
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/usb/serial/hp4x.c b/drivers/usb/serial/hp4x.c
index 020f9a15605b..64d55fbd206e 100644
--- a/drivers/usb/serial/hp4x.c
+++ b/drivers/usb/serial/hp4x.c
@@ -2,7 +2,7 @@
* HP4x Calculators Serial USB driver
*
* Copyright (C) 2005 Arthur Huillet (ahuillet@users.sf.net)
- * Copyright (C) 20... |
35f4a0c4416b4fd789f94328dc5940e79e1507b0 | Analyze and fix the following issue in the Linux kernel code: [PATCH] USB: clean up all iPod models in unusual_devs.h | Problem Details:
Phil Dibowitz wrote:
> 1. You're adding product IDs 1202, 1203, 1204, and 1205. 1203 was
> already there, but you remove it, OK, but 1205 is already there, so
> you'll need to fix that.
I was not removing 1203, it's just the extension of the bcd range. You are
right about 1205, as I wrote, it was a p... | ```diff
diff --git a/drivers/usb/storage/unusual_devs.h b/drivers/usb/storage/unusual_devs.h
index fa68dea6bc6f..bbda63c24c4d 100644
--- a/drivers/usb/storage/unusual_devs.h
+++ b/drivers/usb/storage/unusual_devs.h
@@ -517,14 +517,32 @@ UNUSUAL_DEV( 0x05ab, 0x5701, 0x0100, 0x0110,
0 ),
#endif
+/* Submitted by Sv... |
df6c6804ce1d383c878ab071bce8125125d96abc | Analyze and fix the following issue in the Linux kernel code: [IA64] Fix build errors for !HOTPLUG case. | Problem Details:
Signed-off-by: Ashok Raj <ashok.raj@intel.com>
Signed-off-by: Tony Luck <tony.luck@intel.com> | ```diff
diff --git a/arch/ia64/kernel/head.S b/arch/ia64/kernel/head.S
index 0d535d65eea6..8d3a9291b47f 100644
--- a/arch/ia64/kernel/head.S
+++ b/arch/ia64/kernel/head.S
@@ -95,6 +95,10 @@ RestRR: \
add _idx1=1,_idx1;; \
br.cloop.sptk.few RestRR
+#define SET_AREA_FOR_BOOTING_CPU(reg1, reg2) \
+ m... |
7130667107cd3ab9d6802b69bab63c7d22f20bd4 | Analyze and fix the following issue in the Linux kernel code: [IA64] ia32_signal.c: erroneous use of memset/memcpy | Problem Details:
Found by Alexander Nyberg, improved by Bjorn Helgaas.
- Fix the incorrect argument to sizeof()
- looks like memcpy() code pass was dervived from code that used
copy_from_user(). But in this case we are doing to kernel space
to kernel space copy, so memcpy is the right routine, but it
doesn't re... | ```diff
diff --git a/arch/ia64/ia32/ia32_signal.c b/arch/ia64/ia32/ia32_signal.c
index 19b02adce68c..ebb89be2aa2d 100644
--- a/arch/ia64/ia32/ia32_signal.c
+++ b/arch/ia64/ia32/ia32_signal.c
@@ -460,10 +460,9 @@ __ia32_rt_sigsuspend (compat_sigset_t *sset, unsigned int sigsetsize, struct sig
sigset_t oldset, set;
... |
efab7739d99eae948971140b2aa3dddf7f72c900 | Analyze and fix the following issue in the Linux kernel code: [PATCH] x86_64: fix new out of line put_user() | Problem Details:
The labels after the last put_user patch were misplaced so
exceptions on the real mov instructions would not be handled.
Noted by Brian Gerst <bgerst@didntduck.org> | ```diff
diff --git a/arch/x86_64/lib/putuser.S b/arch/x86_64/lib/putuser.S
index d9d3e5ec9ad1..5828b8191667 100644
--- a/arch/x86_64/lib/putuser.S
+++ b/arch/x86_64/lib/putuser.S
@@ -49,8 +49,8 @@ __put_user_2:
jc 20f
cmpq threadinfo_addr_limit(%r8),%rcx
jae 20f
-2: decq %rcx
- movw %dx,(%rcx)
+ decq %rcx
+2: mov... |
623f41eb923d7f34888cbd9e4f50a7b1a79d0ae5 | Analyze and fix the following issue in the Linux kernel code: [SPARC64]: In sunsu driver, make sure to fully init chip for kbd/ms | Problem Details:
We were forgetting to call sunsu_change_speed(). The reason
that replugging in the mouse cable "fixes things" is that
causes a BREAK interrupt which in turn caused a call to
sunsu_change_speed() which would get the chip setup properly.
Signed-off-by: David S. Miller <davem@davemloft.net> | ```diff
diff --git a/drivers/serial/sunsu.c b/drivers/serial/sunsu.c
index 23d19d394320..ddc97c905e14 100644
--- a/drivers/serial/sunsu.c
+++ b/drivers/serial/sunsu.c
@@ -1285,6 +1285,7 @@ static struct uart_driver sunsu_reg = {
static int __init sunsu_kbd_ms_init(struct uart_sunsu_port *up, int channel)
{
+ int qu... |
b4bca26c0160f48b4eb04f21d31a229832732013 | Analyze and fix the following issue in the Linux kernel code: [SPARC]: Provide generic ioctls in Sparc RTC driver. | Problem Details:
Provide support for drivers/char/rtc.c ioctls in the
Mostek rtc driver as well as the Sparc specific RTCGET
and RTCSET.
This allows userspace to be much less messy. Currently
util-linux and other spots jump through hoops trying
various ioctl variants until it hits the right one whatever
driver actual... | ```diff
diff --git a/arch/sparc64/kernel/time.c b/arch/sparc64/kernel/time.c
index 6a717d4d2bc5..c60785c046be 100644
--- a/arch/sparc64/kernel/time.c
+++ b/arch/sparc64/kernel/time.c
@@ -48,7 +48,7 @@
DEFINE_SPINLOCK(mostek_lock);
DEFINE_SPINLOCK(rtc_lock);
-unsigned long mstk48t02_regs = 0UL;
+void * __iomem mstk4... |
5c5d281a93e9816966b6131ccec19519dab0e103 | Analyze and fix the following issue in the Linux kernel code: [XFRM]: Fix existence lookup in xfrm_state_find | Problem Details:
Use 'daddr' instead of &tmpl->id.daddr, since the latter
might be zero. Also, only perform the lookup when
tmpl->id.spi is non-zero.
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net> | ```diff
diff --git a/net/xfrm/xfrm_state.c b/net/xfrm/xfrm_state.c
index 1db59f11f37d..d11747c2a763 100644
--- a/net/xfrm/xfrm_state.c
+++ b/net/xfrm/xfrm_state.c
@@ -357,8 +357,9 @@ xfrm_state_find(xfrm_address_t *daddr, xfrm_address_t *saddr,
x = best;
if (!x && !error && !acquire_in_progress) {
- x0 = afinfo-... |
1c8594b48b00a98d12477355e944e165a5f64cd5 | Analyze and fix the following issue in the Linux kernel code: [TG3]: Fix bug in tg3_set_eeprom() | Problem Details:
Fix a bug in tg3_set_eeprom() when the length is less than 4 and the
offset is not 4-byte aligned.
Signed-off-by: Michael Chan <mchan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net> | ```diff
diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c
index 301546425736..fb3eb6f8a737 100644
--- a/drivers/net/tg3.c
+++ b/drivers/net/tg3.c
@@ -6560,10 +6560,12 @@ static int tg3_set_eeprom(struct net_device *dev, struct ethtool_eeprom *eeprom,
start = cpu_to_le32(start);
len += b_offset;
offset &= ~3;
... |
8c6bda1a89c148f3a28edc09a76dac9bff57d8ee | Analyze and fix the following issue in the Linux kernel code: [TG3]: Fix tg3_set_power_state() | Problem Details:
Fix tg3_set_power_state to drive GPIOs properly based on the
TG3_FLAG_EEPROM_WRITE_PROTECT flag. Some delays are also added after D0
and D3 power state changes.
Signed-off-by: Michael Chan <mchan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net> | ```diff
diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c
index 742340aebf7e..f0b5dc7766bb 100644
--- a/drivers/net/tg3.c
+++ b/drivers/net/tg3.c
@@ -1005,8 +1005,13 @@ static int tg3_set_power_state(struct tg3 *tp, int state)
pci_write_config_word(tp->pdev,
pm + PCI_PM_CTRL,
power_control);
-... |
85e94cedc44d1c2c1663b5b18f703ca5e7316e59 | Analyze and fix the following issue in the Linux kernel code: [TG3]: Minor 5752 fixes | Problem Details:
Some minor 5752 fixes mostly for correctness and add 5752 PHY ID.
Signed-off-by: Michael Chan <mchan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net> | ```diff
diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c
index c1881976927d..f22f19bbf11a 100644
--- a/drivers/net/tg3.c
+++ b/drivers/net/tg3.c
@@ -1094,7 +1094,7 @@ static int tg3_set_power_state(struct tg3 *tp, int state)
CLOCK_CTRL_ALTCLK |
CLOCK_CTRL_PWRDOWN_PLL133);
udelay(40);
- } else if (!... |
1cff94c6fecdc54d6f022ae5a22888f8272804a1 | Analyze and fix the following issue in the Linux kernel code: [PATCH] fix subarch breakage in amd dual core updates | Problem Details:
The patch to arch/i386/kernel/cpu/amd.c relies on the variable
cpu_core_id which is defined in i386/kernel/smpboot.c. This means it is
only present if CONFIG_X86_SMP is defined, not CONFIG_SMP (alternative
SMP harnesses won't have it, which is why it breaks voyager).
Signed-off-by: James Bottomley <J... | ```diff
diff --git a/arch/i386/kernel/cpu/amd.c b/arch/i386/kernel/cpu/amd.c
index 8d182e875cd7..16dbc4151be4 100644
--- a/arch/i386/kernel/cpu/amd.c
+++ b/arch/i386/kernel/cpu/amd.c
@@ -24,7 +24,7 @@ __asm__(".align 4\nvide: ret");
static void __init init_amd(struct cpuinfo_x86 *c)
{
-#ifdef CONFIG_SMP
+#ifdef CON... |
62b56faa43a7e672e659d14f38f553ed8b40ea70 | Analyze and fix the following issue in the Linux kernel code: [PATCH] Fix tgafb.c compile failure | Problem Details:
The untested patch below should fix this compile error.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
Signed-off-by: Linus Torvalds <torvalds@osdl.org> | ```diff
diff --git a/drivers/video/tgafb.c b/drivers/video/tgafb.c
index 3099630d0c3d..9d9d2009ad8c 100644
--- a/drivers/video/tgafb.c
+++ b/drivers/video/tgafb.c
@@ -45,9 +45,7 @@ static void tgafb_fillrect(struct fb_info *, const struct fb_fillrect *);
static void tgafb_copyarea(struct fb_info *, const struct fb_cop... |
e4ec0f23c878f761cf33f3cbb66c66d6c05931ba | Analyze and fix the following issue in the Linux kernel code: [PATCH] Fix non-legacy ISO receive regression | Problem Details:
Fix non-legacy multichannel ISO receive, broken by Parag Wardukar's
allocation fix. Multichannel ISO receive still sucks; it should be possible
to use both legacy and non-legacy modes at the same time, but with this
patch, things are no worse than they were in 2.6.11 and allocation is
still done at th... | ```diff
diff --git a/drivers/ieee1394/ohci1394.c b/drivers/ieee1394/ohci1394.c
index 72830e6fde45..6cb0b586c297 100644
--- a/drivers/ieee1394/ohci1394.c
+++ b/drivers/ieee1394/ohci1394.c
@@ -539,10 +539,8 @@ static void ohci_initialize(struct ti_ohci *ohci)
initialize_dma_trm_ctx(&ohci->at_req_context);
initialize_... |
bd6ae2f6d61da0f90c6b66e9a4ab6c53ef8c159a | Analyze and fix the following issue in the Linux kernel code: [SCSI] zfcp: fix compile error | Problem Details:
Signed-off-by: Andreas Herrmann <aherrman@de.ibm.com>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com> | ```diff
diff --git a/drivers/s390/scsi/zfcp_aux.c b/drivers/s390/scsi/zfcp_aux.c
index 1f9aeb4accc6..68d151aaa474 100644
--- a/drivers/s390/scsi/zfcp_aux.c
+++ b/drivers/s390/scsi/zfcp_aux.c
@@ -52,7 +52,7 @@ static inline int zfcp_sg_list_copy_from_user(struct zfcp_sg_list *,
static inline int zfcp_sg_list_copy_to_us... |
821376bf15e692941f9235f13a14987009fd0b10 | Analyze and fix the following issue in the Linux kernel code: [IA64] fix fls() | Problem Details:
The ia64-version of fls() never worked as intended (the bitnumbering
was off by 1 and fls(0) was undefined). This patch fixes the problem
by using a popcnt-based fls(), which on McKinley-derived cores is
slightly faster than both ia64_fls() and generic_fls(). The resulting
code, however, is bigger (7... | ```diff
diff --git a/include/asm-ia64/bitops.h b/include/asm-ia64/bitops.h
index 925d54cee475..7232528e2d0c 100644
--- a/include/asm-ia64/bitops.h
+++ b/include/asm-ia64/bitops.h
@@ -314,8 +314,8 @@ __ffs (unsigned long x)
#ifdef __KERNEL__
/*
- * find_last_zero_bit - find the last zero bit in a 64 bit quantity
- *... |
d8470b7c13e11c18cf14a7e3180f0b00e715e4f0 | Analyze and fix the following issue in the Linux kernel code: [PATCH] fix for ISDN ippp filtering | Problem Details:
We do not longer use DLT_LINUX_SLL for activ/pass filters but
DLT_PPP_WITHDIRECTION witch need 1 as outbound flag.
Signed-off-by: Karsten Keil <kkeil@suse.de>
Signed-off-by: Linus Torvalds <torvalds@osdl.org> | ```diff
diff --git a/drivers/isdn/i4l/isdn_ppp.c b/drivers/isdn/i4l/isdn_ppp.c
index 3c092117a8ea..260a323a96d3 100644
--- a/drivers/isdn/i4l/isdn_ppp.c
+++ b/drivers/isdn/i4l/isdn_ppp.c
@@ -1151,7 +1151,7 @@ isdn_ppp_push_higher(isdn_net_dev * net_dev, isdn_net_local * lp, struct sk_buff
{
u_int16_t *p = (u_int16... |
3a6fd752a50af92765853879f4a11cc0cfcd0320 | Analyze and fix the following issue in the Linux kernel code: [PATCH] x86_64: Bug in new out of line put_user() | Problem Details:
The new out of line put_user() assembly on x86_64 changes %rcx without
telling GCC about it causing things like:
http://bugme.osdl.org/show_bug.cgi?id=4515
See to it that %rcx is not changed (made it consistent with get_user()).
Signed-off-by: Alexander Nyberg <alexn@telia.com>
Signed-off-by: ak@su... | ```diff
diff --git a/arch/x86_64/lib/getuser.S b/arch/x86_64/lib/getuser.S
index f94ea8a44051..f80bafee8669 100644
--- a/arch/x86_64/lib/getuser.S
+++ b/arch/x86_64/lib/getuser.S
@@ -78,9 +78,9 @@ __get_user_4:
__get_user_8:
GET_THREAD_INFO(%r8)
addq $7,%rcx
- jc bad_get_user
+ jc 40f
cmpq threadinfo_addr_limit(... |
858eaca169ed5e7b1b14eebb889323e75a02af0e | Analyze and fix the following issue in the Linux kernel code: [PATCH] Fix aic7xxx_osm.c compile with older gcc's | Problem Details:
My version of gcc doesn't warn about this error (declaration in the
middle of a set of statements).
The fix is simple (this also corrects return code; for init functions it
should be zero or error). | ```diff
diff --git a/drivers/scsi/aic7xxx/aic7xxx_osm.c b/drivers/scsi/aic7xxx/aic7xxx_osm.c
index d74b99dab7ec..e60f9338e44a 100644
--- a/drivers/scsi/aic7xxx/aic7xxx_osm.c
+++ b/drivers/scsi/aic7xxx/aic7xxx_osm.c
@@ -3605,9 +3605,8 @@ ahc_linux_init(void)
ahc_linux_transport_template = spi_attach_transport(&ahc_lin... |
fd92833a52b972aafacced959f4a3f7541936a9b | Analyze and fix the following issue in the Linux kernel code: [IPV6]: Fix a branch prediction | Problem Details:
From: Tushar Gohad <tgohad@mvista.com>
Signed-off-by: Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>
Signed-off-by: David S. Miller <davem@davemloft.net> | ```diff
diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
index 5ffde14ddc09..7196ac2f2d16 100644
--- a/net/ipv6/addrconf.c
+++ b/net/ipv6/addrconf.c
@@ -571,7 +571,7 @@ ipv6_add_addr(struct inet6_dev *idev, const struct in6_addr *addr, int pfxlen,
out2:
read_unlock_bh(&addrconf_lock);
- if (unlikely(err == 0... |
cdfb82fff33cf3b1a367a427e5d89a012dc568b1 | Analyze and fix the following issue in the Linux kernel code: [PATCH] freepgt: arm26 FIRST_USER_ADDRESS PAGE_SIZE | Problem Details:
ARM26 define FIRST_USER_ADDRESS as PAGE_SIZE (beyond the machine vectors when
they are mapped low), and use that definition in place of locally defined
MIN_MAP_ADDR. Previously, ARM26 permitted user mappings at 0 if the machine
vectors were mapped high; but that's inconsistent with ARM, and
FIRST_USER... | ```diff
diff --git a/arch/arm26/kernel/sys_arm.c b/arch/arm26/kernel/sys_arm.c
index e7edd201579a..85457897b8a9 100644
--- a/arch/arm26/kernel/sys_arm.c
+++ b/arch/arm26/kernel/sys_arm.c
@@ -64,10 +64,10 @@ inline long do_mmap2(
flags &= ~(MAP_EXECUTABLE | MAP_DENYWRITE);
/*
- * If we are doing a fixed mapping, ... |
e2cdef8c847b480529b7e26991926aab4be008e6 | Analyze and fix the following issue in the Linux kernel code: [PATCH] freepgt: free_pgtables from FIRST_USER_ADDRESS | Problem Details:
The patches to free_pgtables by vma left problems on any architectures which
leave some user address page table entries unencapsulated by vma. Andi has
fixed the 32-bit vDSO on x86_64 to use a vma. Now fix arm (and arm26), whose
first PAGE_SIZE is reserved (perhaps) for machine vectors.
Our calls to... | ```diff
diff --git a/mm/mmap.c b/mm/mmap.c
index 0fa87a5ae2cc..ac6e694c3b61 100644
--- a/mm/mmap.c
+++ b/mm/mmap.c
@@ -1612,6 +1612,11 @@ static void unmap_vma_list(struct mm_struct *mm, struct vm_area_struct *vma)
validate_mm(mm);
}
+#ifndef FIRST_USER_ADDRESS /* temporary hack */
+#define THIS_IS_ARM FIRST_USER... |
ee39b37b23da0b6ec53a8ebe90ff41c016f8ae27 | Analyze and fix the following issue in the Linux kernel code: [PATCH] freepgt: remove MM_VM_SIZE(mm) | Problem Details:
There's only one usage of MM_VM_SIZE(mm) left, and it's a troublesome macro
because mm doesn't contain the (32-bit emulation?) info needed. But it too is
only needed because we ignore the end from the vma list.
We could make flush_pgtables return that end, or unmap_vmas. Choose the
latter, since it'... | ```diff
diff --git a/include/asm-ia64/processor.h b/include/asm-ia64/processor.h
index 8769dd9df369..2807f8d766d4 100644
--- a/include/asm-ia64/processor.h
+++ b/include/asm-ia64/processor.h
@@ -42,14 +42,6 @@
*/
#define TASK_SIZE (current->thread.task_size)
-/*
- * MM_VM_SIZE(mm) gives the maximum address (plus ... |
e0da382c92626ad1d7f4b7527d19b80104d67a83 | Analyze and fix the following issue in the Linux kernel code: [PATCH] freepgt: free_pgtables use vma list | Problem Details:
Recent woes with some arches needing their own pgd_addr_end macro; and 4-level
clear_page_range regression since 2.6.10's clear_page_tables; and its
long-standing well-known inefficiency in searching throughout the higher-level
page tables for those few entries to clear and free: all can be blamed on
i... | ```diff
diff --git a/arch/i386/mm/pgtable.c b/arch/i386/mm/pgtable.c
index 0742d54f8bb0..dd81479ff88a 100644
--- a/arch/i386/mm/pgtable.c
+++ b/arch/i386/mm/pgtable.c
@@ -255,6 +255,6 @@ void pgd_free(pgd_t *pgd)
if (PTRS_PER_PMD > 1)
for (i = 0; i < USER_PTRS_PER_PGD; ++i)
kmem_cache_free(pmd_cache, (void *)_... |
e3b7df65e089f143b9228472b80fb96c495fb634 | Analyze and fix the following issue in the Linux kernel code: [PATCH] aoe 9/12: add note about the need for deadlock-free sk_buff allocation | Problem Details:
add note about the need for deadlock-free sk_buff allocation
Signed-off-by: Ed L. Cashin <ecashin@coraid.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/Documentation/aoe/todo.txt b/Documentation/aoe/todo.txt
new file mode 100644
index 000000000000..7fee1e1165bc
--- /dev/null
+++ b/Documentation/aoe/todo.txt
@@ -0,0 +1,14 @@
+There is a potential for deadlock when allocating a struct sk_buff for
+data that needs to be written out to aoe storage. I... |
7b558637b0efc6ab3f3ca08f0b9cc0191665e9db | Analyze and fix the following issue in the Linux kernel code: [PATCH] debugfs: fix !debugfs prototypes | Problem Details:
- Fix prototypes for debugfs functions (in configurations where
debugfs is disabled).
Signed-off-by: Michal Ostrowski <mostrows@speakeasy.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/include/linux/debugfs.h b/include/linux/debugfs.h
index dcf847cdb5ce..a5fa6a6eede8 100644
--- a/include/linux/debugfs.h
+++ b/include/linux/debugfs.h
@@ -75,21 +75,21 @@ static inline struct dentry *debugfs_create_u8(const char *name, mode_t mode,
static inline struct dentry *debugfs_create_u16(... |
1694145854a309bebd12a5cce63c9b398304e3bb | Analyze and fix the following issue in the Linux kernel code: [PATCH] 2.6.12-rc1-mm3 Fix ver_linux script for no udev utils. | Problem Details:
Without the attached patch, the ver_linux script gives
the following if udev utils are not present.
./scripts/ver_linux: line 90: udevinfo: command not found
The patch causes ver_linux to be silent in the case of
no udevinfo command.
Signed-off-by: Steven Cole <elenstev@mesatop.com>
Signed-off-by: G... | ```diff
diff --git a/scripts/ver_linux b/scripts/ver_linux
index bb195a1c0f2d..a28c279c49dd 100755
--- a/scripts/ver_linux
+++ b/scripts/ver_linux
@@ -87,7 +87,7 @@ loadkeys -V 2>&1 | awk \
expr --v 2>&1 | awk 'NR==1{print "Sh-utils ", $NF}'
-udevinfo -V | awk '{print "udev ", $3}'
+u... |
1d66c64c3cee10a465cd3f8bd9191bbeb718f650 | Analyze and fix the following issue in the Linux kernel code: [PATCH] I2C: Fix incorrect sysfs file permissions in it87 and via686a drivers | Problem Details:
The it87 and via686a hardware monitoring drivers each create a sysfs
file named "alarms" in R/W mode, while they should really create it in
read-only mode. Since we don't provide a store function for these files,
write attempts to these files will do something undefined (I guess) and
bad (I am sure). M... | ```diff
diff --git a/drivers/i2c/chips/it87.c b/drivers/i2c/chips/it87.c
index 3d484a7aff12..cf7e6898754f 100644
--- a/drivers/i2c/chips/it87.c
+++ b/drivers/i2c/chips/it87.c
@@ -668,7 +668,7 @@ static ssize_t show_alarms(struct device *dev, char *buf)
struct it87_data *data = it87_update_device(dev);
return sprint... |
8523ff45672a5c9209ab7459142e37e7cd393e6c | Analyze and fix the following issue in the Linux kernel code: [PATCH] w1: real fix for big endian machines. | Problem Details:
Real fix for big endian machines - crc must be calculated
using little endian byte order.
Signed-off-by: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c
index fd630cec0e79..8d7821899cc1 100644
--- a/drivers/w1/w1.c
+++ b/drivers/w1/w1.c
@@ -522,10 +522,11 @@ void w1_slave_found(unsigned long data, u64 rn)
slave_count++;
}
- if (slave_count == dev->slave_count && rn ) {
- tmp = cpu_to_le64(rn);
- if(((rn... |
e838a0d4d5260bce452c96914a6e86b217c53c55 | Analyze and fix the following issue in the Linux kernel code: [PATCH] USB: fix AIPTEK input doesn`t register `device` & `driver` section in sysfs (/sys/class/input/event#) | Problem Details:
PROBLEM: aiptek input doesn`t register `device` & `driver` section in sysfs (/sys/class/input/event#)
REASON: `dev` - field not filled...
SOLUTION: in linux/drivers/usb/input/aiptek.c write
aiptek->inputdev.dev = &intf->dev;
before calling
input_register_device(&aiptek->inputdev);
From: "Viktor A. D... | ```diff
diff --git a/drivers/usb/input/aiptek.c b/drivers/usb/input/aiptek.c
index d7fea9ea301b..2d76be62f4e0 100644
--- a/drivers/usb/input/aiptek.c
+++ b/drivers/usb/input/aiptek.c
@@ -2138,6 +2138,7 @@ aiptek_probe(struct usb_interface *intf, const struct usb_device_id *id)
aiptek->inputdev.id.vendor = le16_to_cpu... |
6cdee106e7571751ecc0e9f96606322f88b64a8d | Analyze and fix the following issue in the Linux kernel code: [PATCH] usb gadget: ethernet/rndis updates | Problem Details:
Updates to the Ethernet/RNDIS gadget driver (mostly for RNDIS):
- Fix brown-paper bag goof with RNDIS packet TX ... the wrong length
field got set, so Windows would ignore data packets it received.
- More consistent handling of CDC output filters (but not yet hooking
things up so RNDIS us... | ```diff
diff --git a/drivers/usb/gadget/ether.c b/drivers/usb/gadget/ether.c
index cff9fb0b73cc..3993156c2e82 100644
--- a/drivers/usb/gadget/ether.c
+++ b/drivers/usb/gadget/ether.c
@@ -100,6 +100,8 @@ static const char driver_desc [] = DRIVER_DESC;
/* CDC and RNDIS support the same host-chosen outgoing packet filt... |
1bc3c9e1e44c2059fe2ffa6ff70ad0a925d7b05f | Analyze and fix the following issue in the Linux kernel code: [PATCH] USB: kfree cleanup for drivers/usb/* - no need to check for NULL | Problem Details:
Get rid of a bunch of redundant NULL pointer checks in drivers/usb/*,
there's no need to check a pointer for NULL before calling kfree() on it.
Signed-off-by: Jesper Juhl <juhl-lkml@dif.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Index: gregkh-2.6/drivers/usb/class/audio.c
===============... | ```diff
diff --git a/drivers/usb/class/audio.c b/drivers/usb/class/audio.c
index f432b7d5b235..f8f21567cc22 100644
--- a/drivers/usb/class/audio.c
+++ b/drivers/usb/class/audio.c
@@ -649,14 +649,10 @@ static void usbin_stop(struct usb_audiodev *as)
}
}
set_current_state(TASK_RUNNING);
- if (u->durb[0].urb->trans... |
97bb13ec5bc156352cca8af90080597e04299a73 | Analyze and fix the following issue in the Linux kernel code: [PATCH] pl2303 - status line | Problem Details:
I'm attaching a patch to fix status when using Siemens X65
mobile. This mobile use first byte instead of normal UART_STATE
byte.
From: Flavio Leitner <fbl@conectiva.com.br>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Index: gregkh-2.6/drivers/usb/serial/pl2303.c
=============================... | ```diff
diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c
index a52115407ea1..dceda2e43c15 100644
--- a/drivers/usb/serial/pl2303.c
+++ b/drivers/usb/serial/pl2303.c
@@ -817,15 +817,40 @@ static void pl2303_shutdown (struct usb_serial *serial)
}
}
+static void pl2303_update_line_status(struc... |
0e4987639a774d08b69c1c58774f3430f6083d4f | Analyze and fix the following issue in the Linux kernel code: [PATCH] USB: OHCI on Compaq Aramada 7400 | Problem Details:
This adds a quirk to the OHCI driver that lets it work with an old
Compaq implementation. It also removes some needless strings from
the non-debug version of the driver.
Signed-off-by: Chris Clayton <chris_clayton@f1internet.com>
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Signed-... | ```diff
diff --git a/drivers/usb/host/ohci-pci.c b/drivers/usb/host/ohci-pci.c
index f30118b5f9aa..57fd07d00549 100644
--- a/drivers/usb/host/ohci-pci.c
+++ b/drivers/usb/host/ohci-pci.c
@@ -54,7 +54,7 @@ ohci_pci_start (struct usb_hcd *hcd)
if (pdev->vendor == PCI_VENDOR_ID_AMD
&& pdev->device == 0x740c) {
... |
e4334fa4c5cb62f26d7e9a0a581126bcbe0dedcf | Analyze and fix the following issue in the Linux kernel code: [PATCH] Fix GO_SLOW delay | Problem Details:
This patch changes the delay for the US_FL_GO_SLOW patch from 110us to 125.
Some delays need this extra delay includign Jan De Luyck's drive which spawned
the original increase from 110 to 110us. 125 is a microframe, so this delay
seems to make sense more than just be a random delay (thanks to David Br... | ```diff
diff --git a/drivers/usb/storage/transport.c b/drivers/usb/storage/transport.c
index d2c3d2fa082e..9743e289cd3b 100644
--- a/drivers/usb/storage/transport.c
+++ b/drivers/usb/storage/transport.c
@@ -996,7 +996,7 @@ int usb_stor_Bulk_transport(struct scsi_cmnd *srb, struct us_data *us)
* command phase and the... |
403a98176a5866217eb12ca6bb283e635ced2dd0 | Analyze and fix the following issue in the Linux kernel code: [PATCH] USB: usbnet printk warning fix | Problem Details:
On ppc64:
drivers/usb/net/usbnet.c: In function `skb_return':
drivers/usb/net/usbnet.c:429: warning: int format, different type arg (arg 3)
drivers/usb/net/usbnet.c:429: warning: int format, different type arg (arg 3)
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Greg Kroah-Hartman <gre... | ```diff
diff --git a/drivers/usb/net/usbnet.c b/drivers/usb/net/usbnet.c
index 3e341b1ffdb1..0ebb79c2937f 100644
--- a/drivers/usb/net/usbnet.c
+++ b/drivers/usb/net/usbnet.c
@@ -426,7 +426,7 @@ static void skb_return (struct usbnet *dev, struct sk_buff *skb)
dev->stats.rx_bytes += skb->len;
if (netif_msg_rx_stat... |
668a9541a56af5ebb3ad0babdc2cd73511c9e1e9 | Analyze and fix the following issue in the Linux kernel code: [PATCH] USB: bug fix in usbdevfs | Problem Details:
I am sorry that the last patch about 32 bit compat ioctl on
64 bit kernel actually breaks the usbdevfs. That is on the current
BK tree. I am retarded.
Here is the patch to fix it. Tested with USB hard disk and webcam
in both 32bit compatible mode and native 64bit mode.
Again, sorry about that.
Fro... | ```diff
diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c
index a047bc392983..923e5185c036 100644
--- a/drivers/usb/core/devio.c
+++ b/drivers/usb/core/devio.c
@@ -1032,15 +1032,15 @@ static int processcompl(struct async *as, void __user * __user *arg)
if (put_user(urb->error_count, &userurb->error_cou... |
a81e7ecca369afee0b07b4758d8c32542ffc587a | Analyze and fix the following issue in the Linux kernel code: [PATCH] USB: revert "fix" to usb_set_interface() | Problem Details:
This reverts a recent change to usb_set_interface(). The change worked
around a quirk in certain devices, but doing this in usbcore creates
needless regressions for other devices. More appropriate fixes won't
put such handling in usbcore.
Basically it's tricky to do a full software reset of USB devi... | ```diff
diff --git a/drivers/usb/core/message.c b/drivers/usb/core/message.c
index 40bdb38e7bcb..e12c5be1e0a3 100644
--- a/drivers/usb/core/message.c
+++ b/drivers/usb/core/message.c
@@ -1133,29 +1133,10 @@ int usb_set_interface(struct usb_device *dev, int interface, int alternate)
/* prevent submissions using previo... |
6d5e8254bf488a40b7ae2faafbffa232ab19d541 | Analyze and fix the following issue in the Linux kernel code: [PATCH] USB: fix up some sparse warnings about static functions that aren't static. | Problem Details:
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Index: gregkh-2.6/drivers/usb/core/usb.h
=================================================================== | ```diff
diff --git a/drivers/usb/core/config.c b/drivers/usb/core/config.c
index 0b092bdf98f3..99595e07b653 100644
--- a/drivers/usb/core/config.c
+++ b/drivers/usb/core/config.c
@@ -10,7 +10,8 @@
#include <linux/slab.h>
#include <linux/device.h>
#include <asm/byteorder.h>
-
+#include "usb.h"
+#include "hcd.h"
#d... |
ba9d35fb01852e195f2a4ca975fdcd6578b52c78 | Analyze and fix the following issue in the Linux kernel code: [PATCH] USB: fix up remaining pm_message_t usages | Problem Details:
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> | ```diff
diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
index 94f7d2d1faf6..15ac4d168862 100644
--- a/drivers/usb/core/hub.c
+++ b/drivers/usb/core/hub.c
@@ -1456,7 +1456,7 @@ static void hub_port_logical_disconnect(struct usb_hub *hub, int port1)
/* FIXME let caller ask to power down the port:
* - s... |
9a5d3e98dd31abcecbf4533b81866d440cc0f106 | Analyze and fix the following issue in the Linux kernel code: [PATCH] USB: hcd suspend uses pm_message_t | Problem Details:
This patch includes minor "sparse -Wbitwise" updates for the PCI based
HCDs. Almost all of them involve just changing the second parameter of the
suspend() method to a pm_message_t ... the others relate to how the EHCI
code walks in-memory data structures. (There's a minor bug fixed there too
... a... | ```diff
diff --git a/drivers/usb/core/hcd.h b/drivers/usb/core/hcd.h
index 6c625b35fa0c..f67cf1e634fc 100644
--- a/drivers/usb/core/hcd.h
+++ b/drivers/usb/core/hcd.h
@@ -177,7 +177,7 @@ struct hc_driver {
* a whole, not just the root hub; they're for bus glue.
*/
/* called after all devices were suspended */
-... |
c6053ecffb895f6c0e0ec9c1d298e35cffc1f7a6 | Analyze and fix the following issue in the Linux kernel code: [PATCH] usb resume fixes | Problem Details:
This has a variety of updates to the shared suspend/resume code for
PCI based USB host controllers.
- Cope with pm_message_t replacing the target system state.
This is actually a loss of functionality; PCI D1 and D2
states will no longer be used, and it's no longer knowable
that ... | ```diff
diff --git a/drivers/usb/core/hcd-pci.c b/drivers/usb/core/hcd-pci.c
index b9a3dae07036..71b4a8d66318 100644
--- a/drivers/usb/core/hcd-pci.c
+++ b/drivers/usb/core/hcd-pci.c
@@ -33,7 +33,7 @@
#include "hcd.h"
-/* PCI-based HCs are normal, but custom bus glue should be ok */
+/* PCI-based HCs are common, b... |
84d79cb8db2811140c911df7ce3e3354cfa018c4 | Analyze and fix the following issue in the Linux kernel code: [PATCH] USB: usb_cdc build fix | Problem Details:
With older gcc's:
In file included from drivers/usb/class/cdc-acm.c:63:
include/linux/usb_cdc.h:117: field `bDetailData' has incomplete type
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
diff -puN include/linux/usb_cdc.h~usb_cdc-build-fix include/lin... | ```diff
diff --git a/include/linux/usb_cdc.h b/include/linux/usb_cdc.h
index 1b68c122279a..f22d6beecc73 100644
--- a/include/linux/usb_cdc.h
+++ b/include/linux/usb_cdc.h
@@ -114,7 +114,7 @@ struct usb_cdc_mdlm_detail_desc {
/* type is associated with mdlm_desc.bGUID */
__u8 bGuidDescriptorType;
- __u8 bDetailDat... |
0ba4da03cc84f54b2574e1abcdaa18ef8456a9fb | Analyze and fix the following issue in the Linux kernel code: [PATCH] sparc64: Fix stat | Problem Details:
Like Alpha, sparc64's struct stat was defined before we had the
nanosecond et al. fields added. So like Alpha I have to cons up a
struct stat64 to get this stuff. I'll work on the glibc bits soon.
Also, we were forgetting to fill in the nanosecond fields in the sparc
compat stat64 syscalls.
Sign... | ```diff
diff --git a/arch/sparc64/kernel/sys_sparc32.c b/arch/sparc64/kernel/sys_sparc32.c
index 567c91c77b20..1d3aa588df8a 100644
--- a/arch/sparc64/kernel/sys_sparc32.c
+++ b/arch/sparc64/kernel/sys_sparc32.c
@@ -352,11 +352,11 @@ int cp_compat_stat(struct kstat *stat, struct compat_stat __user *statbuf)
err |= put... |
7aaef27bafdfa10351726a1d383bdde33422072c | Analyze and fix the following issue in the Linux kernel code: qla2xxx: fix compiler warning in qla_attr.c | Problem Details:
CC [M] drivers/scsi/qla2xxx/qla_attr.o
drivers/scsi/qla2xxx/qla_attr.c: In function `qla2x00_sysfs_write_fw_dump':
drivers/scsi/qla2xxx/qla_attr.c:65: warning: implicit declaration of function `vfree'
drivers/scsi/qla2xxx/qla_attr.c:83: warning: implicit declaration of function `vmalloc'
drivers/scsi/... | ```diff
diff --git a/drivers/scsi/qla2xxx/qla_attr.c b/drivers/scsi/qla2xxx/qla_attr.c
index 56770fac4d14..2240a0cde583 100644
--- a/drivers/scsi/qla2xxx/qla_attr.c
+++ b/drivers/scsi/qla2xxx/qla_attr.c
@@ -18,7 +18,7 @@
*/
#include "qla_def.h"
-#include <linux/version.h>
+#include <linux/vmalloc.h>
#include <scs... |
83021920e733aa706926046b6ab61912c0d63943 | Analyze and fix the following issue in the Linux kernel code: [PATCH] qla2xxx: cleanup DMA mappings... | Problem Details:
Don't use cmd->request->nr_hw_segments as it may not be initialized
(SG_IO in particular bypasses anything that initializes this and just
uses scsi_do_req to insert a scsi_request directly on the head of the
queue) and a bogus value here can trip up the checks to make sure that
the number of se... | ```diff
diff --git a/drivers/scsi/qla2xxx/qla_iocb.c b/drivers/scsi/qla2xxx/qla_iocb.c
index 59d62cbb994e..af964bb3d870 100644
--- a/drivers/scsi/qla2xxx/qla_iocb.c
+++ b/drivers/scsi/qla2xxx/qla_iocb.c
@@ -216,18 +216,7 @@ void qla2x00_build_scsi_iocbs_32(srb_t *sp, cmd_entry_t *cmd_pkt,
cur_seg++;
}
} else {... |
238628edb6cd427454fb54994e2605e191bfc26a | Analyze and fix the following issue in the Linux kernel code: [PATCH] sched: fix signed comparisons of long long | Problem Details:
Signed-off-by: Jesper Juhl <juhl-lkml@dif.dk>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Linus Torvalds <torvalds@osdl.org> | ```diff
diff --git a/kernel/sched.c b/kernel/sched.c
index f69c4a5361e3..9bb7489ee645 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -2648,9 +2648,9 @@ need_resched_nonpreemptible:
schedstat_inc(rq, sched_cnt);
now = sched_clock();
- if (likely((long long)now - prev->timestamp < NS_MAX_SLEEP_AVG)) {
+ if (li... |
219f0817038cabc722968e914490adf6b686499e | Analyze and fix the following issue in the Linux kernel code: [PATCH] SELinux: fix deadlock on dcache lock | Problem Details:
This fixes a deadlock on the dcache lock detected during testing at IBM
by moving the logging of the current executable information from the
SELinux avc_audit function to audit_log_exit (via an audit_log_task_info
helper) for processing upon syscall exit.
For consistency, the patch also removes the l... | ```diff
diff --git a/kernel/auditsc.c b/kernel/auditsc.c
index 8c454852d6a5..6f1931381bc9 100644
--- a/kernel/auditsc.c
+++ b/kernel/auditsc.c
@@ -610,6 +610,33 @@ static inline void audit_free_context(struct audit_context *context)
printk(KERN_ERR "audit: freed %d contexts\n", count);
}
+static void audit_log_ta... |
2bc474c3646efba67bdc83b7fc7d8ee7562e0106 | Analyze and fix the following issue in the Linux kernel code: [PATCH] kill old EH constants | Problem Details:
Fix up two drivers that incorrectly were using the old return values for
their new-style EH methods and kill off scsi_obsolete.h that defined the
constants. The initio driver has all these constansts defined locally
and uses them internally, I'll fix that up some time later.
Signed-off-by: James Bott... | ```diff
diff --git a/drivers/scsi/scsi.h b/drivers/scsi/scsi.h
index 6e7bb068220f..e2360c26ef01 100644
--- a/drivers/scsi/scsi.h
+++ b/drivers/scsi/scsi.h
@@ -60,12 +60,6 @@ struct scatterlist;
#define scsi_to_pci_dma_dir(scsi_dir) ((int)(scsi_dir))
#define scsi_to_sbus_dma_dir(scsi_dir) ((int)(scsi_dir))
-/*
- * T... |
15e8869943060780b79b242851b0692286fc7d18 | Analyze and fix the following issue in the Linux kernel code: [PATCH] x86: fix acpi compile without CONFIG_ACPI_BUS | Problem Details:
The recent acpi boot patch breaks for me: acpi_fadt needs CONFIG_ACPI_BUS.
Signed-off-By: Chris Wedgwood <cw@f00f.org>
Acked-by: Andi Kleen <ak@suse.de>
Signed-off-by: Linus Torvalds <torvalds@osdl.org> | ```diff
diff --git a/arch/i386/kernel/acpi/boot.c b/arch/i386/kernel/acpi/boot.c
index 040451e90a04..53eb5cfd5b63 100644
--- a/arch/i386/kernel/acpi/boot.c
+++ b/arch/i386/kernel/acpi/boot.c
@@ -608,9 +608,11 @@ static int __init acpi_parse_fadt(unsigned long phys, unsigned long size)
acpi_fadt.sci_int = fadt->sci_in... |
9c7d3b3a6b6aaeded9d9e5c5111dbcc65b0b0f91 | Analyze and fix the following issue in the Linux kernel code: [PATCH] sparc64: Fix copy_sigingo_to_user32() | Problem Details:
The compat routine to copy over this data structure was not
handling SI_POLL correctly, breaking various fcntl() variants
in compat tasks.
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Linus Torvalds <torvalds@osdl.org> | ```diff
diff --git a/arch/sparc64/kernel/signal32.c b/arch/sparc64/kernel/signal32.c
index 859255cf6762..9a375e975cff 100644
--- a/arch/sparc64/kernel/signal32.c
+++ b/arch/sparc64/kernel/signal32.c
@@ -192,10 +192,13 @@ int copy_siginfo_to_user32(compat_siginfo_t __user *to, siginfo_t *from)
err |= __put_user(from... |
fb65b9619b756793d824df7501c895a2c2871f40 | Analyze and fix the following issue in the Linux kernel code: [PATCH] sparc: Fix PTRACE_CONT bogosity | Problem Details:
SunOS aparently had this weird PTRACE_CONT semantic which
we copied. If the addr argument is something other than
1, it sets the process program counter to whatever that
value is.
This is different from every other Linux architecture, which
don't do anything with the addr and data args.
This differe... | ```diff
diff --git a/arch/sparc/kernel/ptrace.c b/arch/sparc/kernel/ptrace.c
index fc4ad69357b8..c4f93bd2daf2 100644
--- a/arch/sparc/kernel/ptrace.c
+++ b/arch/sparc/kernel/ptrace.c
@@ -530,18 +530,6 @@ asmlinkage void do_ptrace(struct pt_regs *regs)
pt_error_return(regs, EIO);
goto out_tsk;
}
- if (addr !... |
1d4d5b325315f064e8cd4efaefbe50cdda0357c7 | Analyze and fix the following issue in the Linux kernel code: [PATCH] revert fs/char_dev.c CONFIG_BASE_FULL change | Problem Details:
This reverts a fs/char_dev.c patch that was merged into BK on March 3.
The problem is that it breaks things ... __register_chrdev_region() has
a block of code, commented "temporary" for over two years now, which
fails rudely during PCMCIA initialization or other register_chrdev()
calls, because it doe... | ```diff
diff --git a/fs/char_dev.c b/fs/char_dev.c
index 7357a9127df1..a745b1d9e545 100644
--- a/fs/char_dev.c
+++ b/fs/char_dev.c
@@ -26,8 +26,7 @@
static struct kobj_map *cdev_map;
-/* degrade to linked list for small systems */
-#define MAX_PROBE_HASH (CONFIG_BASE_SMALL ? 1 : 255)
+#define MAX_PROBE_HASH 255 /*... |
cc56449f53ba45646c6f0a2edf77c4acb342caed | Analyze and fix the following issue in the Linux kernel code: [PATCH] ARM: fix debug macros | Problem Details:
Fix debug EBSA285 and RiscPC debugging macros to detect whether the
MMU is enabled.
Signed-off-by: Russell King <rmk@arm.linux.org.uk> | ```diff
diff --git a/include/asm-arm/arch-ebsa285/debug-macro.S b/include/asm-arm/arch-ebsa285/debug-macro.S
index 237853db6e2f..97d15fc629af 100644
--- a/include/asm-arm/arch-ebsa285/debug-macro.S
+++ b/include/asm-arm/arch-ebsa285/debug-macro.S
@@ -45,9 +45,12 @@
.equ dc21285_low, ARMCSR_BASE & 0x00ffffff
.m... |
652a12ef98d16ccd1ee5cdf2c832ce5411ed3262 | Analyze and fix the following issue in the Linux kernel code: [PATCH] ARM: showregs | Problem Details:
Fix show_regs() to provide a backtrace. Provide a new __show_regs()
function which implements the common subset of show_regs() and die().
Add prototypes to asm-arm/system.h
Signed-off-by: Russell King <rmk@arm.linux.org.uk> | ```diff
diff --git a/arch/arm/kernel/process.c b/arch/arm/kernel/process.c
index dbd8ca89b385..26eacd3e5def 100644
--- a/arch/arm/kernel/process.c
+++ b/arch/arm/kernel/process.c
@@ -168,12 +168,11 @@ void machine_restart(char * __unused)
EXPORT_SYMBOL(machine_restart);
-void show_regs(struct pt_regs * regs)
+void... |
58c02ec4701c94c671a41e1e5d50c582e859851f | Analyze and fix the following issue in the Linux kernel code: [PATCH] ARM: h3600_irda_set_speed arguments | Problem Details:
h3600_irda_set_speed() had the wrong type for the "speed" argument.
Fix this.
Signed-off-by: Russell King <rmk@arm.linux.org.uk> | ```diff
diff --git a/arch/arm/mach-sa1100/h3600.c b/arch/arm/mach-sa1100/h3600.c
index 9788d3aefa73..84c86543501a 100644
--- a/arch/arm/mach-sa1100/h3600.c
+++ b/arch/arm/mach-sa1100/h3600.c
@@ -130,7 +130,7 @@ static int h3600_irda_set_power(struct device *dev, unsigned int state)
return 0;
}
-static void h3600_i... |
0db7157ca47e21c7623a59e710b807ad06fce161 | Analyze and fix the following issue in the Linux kernel code: [PATCH] kill old EH constants | Problem Details:
Fix up two drivers that incorrectly were using the old return values for
their new-style EH methods and kill off scsi_obsolete.h that defined the
constants. The initio driver has all these constansts defined locally
and uses them internally, I'll fix that up some time later.
Signed-off-by: James Bott... | ```diff
diff --git a/drivers/scsi/scsi.h b/drivers/scsi/scsi.h
index 6e7bb068220f..e2360c26ef01 100644
--- a/drivers/scsi/scsi.h
+++ b/drivers/scsi/scsi.h
@@ -60,12 +60,6 @@ struct scatterlist;
#define scsi_to_pci_dma_dir(scsi_dir) ((int)(scsi_dir))
#define scsi_to_sbus_dma_dir(scsi_dir) ((int)(scsi_dir))
-/*
- * T... |
c2a9331c62216e222a08de8dd58559367fef0af6 | Analyze and fix the following issue in the Linux kernel code: updates for CFQ oops fix | Problem Details:
- add a comment to the device structure that the device_busy field
is now protected by the request_queue->queue_lock
- null out sdev->request_queue after the queue is released to trap
any (and there shouldn't be any) use after the queue is freed.
Signed-off-by: James Bottomley <James.Bottomley@Ste... | ```diff
diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c
index 134d3a3e4222..e75ee4671ee3 100644
--- a/drivers/scsi/scsi_sysfs.c
+++ b/drivers/scsi/scsi_sysfs.c
@@ -171,6 +171,9 @@ void scsi_device_dev_release(struct device *dev)
if (sdev->request_queue) {
sdev->request_queue->queuedata = NULL;
... |
152587deb8903c0edf483a5b889f975bc6bea7e0 | Analyze and fix the following issue in the Linux kernel code: [PATCH] fix NMI lockup with CFQ scheduler | Problem Details:
The current problem seen is that the queue lock is actually in the
SCSI device structure, so when that structure is freed on device
release, we go boom if the queue tries to access the lock again.
The fix here is to move the lock from the scsi_device to the queue.
Signed-off-by: James Bottomley <Jame... | ```diff
diff --git a/drivers/block/ll_rw_blk.c b/drivers/block/ll_rw_blk.c
index 46e54b441663..11ef9d9ea139 100644
--- a/drivers/block/ll_rw_blk.c
+++ b/drivers/block/ll_rw_blk.c
@@ -1715,6 +1715,15 @@ request_queue_t *blk_init_queue(request_fn_proc *rfn, spinlock_t *lock)
if (blk_init_free_list(q))
goto out_init;... |
56fece20086ebe32bce2c0d74ceadd516b56baae | Analyze and fix the following issue in the Linux kernel code: [PATCH] finally fix 53c700 to use the generic iomem infrastructure | Problem Details:
This driver has had it's own different infrastructure for doing this for
ages, but it's time it used the common one.
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com> | ```diff
diff --git a/drivers/scsi/53c700.c b/drivers/scsi/53c700.c
index a591fcb8aab1..4b1bb529f676 100644
--- a/drivers/scsi/53c700.c
+++ b/drivers/scsi/53c700.c
@@ -389,8 +389,7 @@ NCR_700_detect(struct scsi_host_template *tpnt,
host->max_lun = NCR_700_MAX_LUNS;
BUG_ON(NCR_700_transport_template == NULL);
host-... |
cb59e840838193957a84ad22f7e1465a06a7c10c | Analyze and fix the following issue in the Linux kernel code: [PATCH] sg.c: update | Problem Details:
The attachment combines the most recent patch from
Yum Rayan <yum.rayan@gmail.com> (to reduce sg stack
usage), Adrian Bunk <bunk@stusta.de> (to fix check
after use) and me (fix elapsed time calculation
(duration) on ia64 machines).
I have modified the patch from Yum Rayan so kmalloc()
in sg_read() is ... | ```diff
diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c
index fd72d73bb244..32de9aabcb99 100644
--- a/drivers/scsi/sg.c
+++ b/drivers/scsi/sg.c
@@ -18,8 +18,8 @@
*
*/
-static int sg_version_num = 30532; /* 2 digits for each component */
-#define SG_VERSION_STR "3.5.32"
+static int sg_version_num = 30533; /* 2 ... |
a757e64cfa400391041ed7953f0290c34a820c93 | Analyze and fix the following issue in the Linux kernel code: [PATCH] md: remove a number of misleading calls to MD_BUG | Problem Details:
The conditions that cause these calls to MD_BUG are not kernel bugs, just
oddities in what userspace is asking for.
Also convert analyze_sbs to return void, and the value it returned was
always 0.
Signed-off-by: Neil Brown <neilb@cse.unsw.edu.au>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-of... | ```diff
diff --git a/drivers/md/md.c b/drivers/md/md.c
index 44a164965546..97af857d8a88 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -1387,7 +1387,7 @@ abort_free:
*/
-static int analyze_sbs(mddev_t * mddev)
+static void analyze_sbs(mddev_t * mddev)
{
int i;
struct list_head *tmp;
@@ -1441,7 +1441,6... |
23907eb8c22e39bcf3d7e7a35a2db1e416157adb | Analyze and fix the following issue in the Linux kernel code: [PATCH] serial: fix comments in 8250.c | Problem Details:
Fix the formatting of some comments in 8250.c, and add a note that the
register_serial / unregister_serial shouldn't be used in new code.
We do this here in preference to adding to linux/serial.h, since that is used
by a number of non-8250 drivers which pretend to be 8250. It is not known
whether it ... | ```diff
diff --git a/drivers/serial/8250.c b/drivers/serial/8250.c
index 201c3b9924f4..218b69372c0b 100644
--- a/drivers/serial/8250.c
+++ b/drivers/serial/8250.c
@@ -1065,8 +1065,10 @@ receive_chars(struct uart_8250_port *up, int *status, struct pt_regs *regs)
tty_flip_buffer_push(tty);
spin_lock(&up->port.l... |
c907132d534c10b4f34a60383c8384403cb424a4 | Analyze and fix the following issue in the Linux kernel code: [PATCH] nfsd4: fix struct file leak | Problem Details:
We were failing to close on an error path, resulting in a leak of struct files
which could take a v4 server down fairly quickly.... So call
nfs4_close_delegation instead of just open-coding parts of it.
Simplify the cleanup on delegation failure while we're at it.
Signed-off-by: J. Bruce Fields <bfi... | ```diff
diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
index 579f7fea7968..75e8b137580c 100644
--- a/fs/nfsd/nfs4state.c
+++ b/fs/nfsd/nfs4state.c
@@ -190,7 +190,8 @@ nfs4_close_delegation(struct nfs4_delegation *dp)
dp->dl_vfs_file = NULL;
/* The following nfsd_close may not actually close the file,
* b... |
9e416052f1462801ca857c7536288bac0621615e | Analyze and fix the following issue in the Linux kernel code: [PATCH] nfsd: clear signals before exiting the nfsd() thread | Problem Details:
Fixes the error "RPC: failed to contact portmap (errno -512)." when the server
later tries to unregister from the portmapper.
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
Signed-off-by: Neil Brown <neilb@cse.unsw.edu.au>
Signed-off... | ```diff
diff --git a/fs/nfsd/nfssvc.c b/fs/nfsd/nfssvc.c
index 39551657e656..02ded7cfbdcf 100644
--- a/fs/nfsd/nfssvc.c
+++ b/fs/nfsd/nfssvc.c
@@ -258,6 +258,8 @@ nfsd(struct svc_rqst *rqstp)
break;
err = signo;
}
+ /* Clear signals before calling lockd_down() and svc_exit_thread() */
+ flush_signals(current)... |
d13df84ff7f3f3e26a9643c1d3cbf94cef9b5b59 | Analyze and fix the following issue in the Linux kernel code: [PATCH] jbd dirty buffer leak fix | Problem Details:
This fixes the lots-of-fsx-linux-instances-cause-a-slow-leak bug.
It's been there since 2.6.6, caused by:
ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.5/2.6.5-mm4/broken-out/jbd-move-locked-buffers.patch
That patch moves under-writeout ordered-data buffers onto a separate journa... | ```diff
diff --git a/fs/jbd/transaction.c b/fs/jbd/transaction.c
index 932e7c1ef4a1..77b7662b840b 100644
--- a/fs/jbd/transaction.c
+++ b/fs/jbd/transaction.c
@@ -1812,7 +1812,17 @@ static int journal_unmap_buffer(journal_t *journal, struct buffer_head *bh)
}
}
} else if (transaction == journal->j_committing_t... |
08aeb14e5f6c28878266b01c87cc5ce31101afa8 | Analyze and fix the following issue in the Linux kernel code: [PATCH] IB/mthca: map context for RDMA responder in mem-free mode | Problem Details:
Fix RDMA in mem-free mode: we need to make sure that the RDMA context memory
is mapped for the HCA.
Signed-off-by: Roland Dreier <roland@topspin.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org> | ```diff
diff --git a/drivers/infiniband/hw/mthca/mthca_dev.h b/drivers/infiniband/hw/mthca/mthca_dev.h
index 616a0de54b40..d014b443dc3c 100644
--- a/drivers/infiniband/hw/mthca/mthca_dev.h
+++ b/drivers/infiniband/hw/mthca/mthca_dev.h
@@ -222,6 +222,7 @@ struct mthca_qp_table {
struct mthca_array qp;
struct mt... |
6bd6228eed52ef188ebe46865ccff72da936c968 | Analyze and fix the following issue in the Linux kernel code: [PATCH] IB/mthca: tweaks to mthca_cmd.c | Problem Details:
Minor tweaks to firmware command handling: kill off an unused get of a value,
and add a little more info to debug output.
Signed-off-by: Roland Dreier <roland@topspin.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org> | ```diff
diff --git a/drivers/infiniband/hw/mthca/mthca_cmd.c b/drivers/infiniband/hw/mthca/mthca_cmd.c
index a18468015f38..3c1cfc466522 100644
--- a/drivers/infiniband/hw/mthca/mthca_cmd.c
+++ b/drivers/infiniband/hw/mthca/mthca_cmd.c
@@ -989,7 +989,6 @@ int mthca_QUERY_DEV_LIM(struct mthca_dev *dev,
dev_lim->hca.ar... |
44ea66879d5638cfed5b5ecf628badfd8ec26f36 | Analyze and fix the following issue in the Linux kernel code: [PATCH] IB/mthca: fix MTT allocation in mem-free mode | Problem Details:
Fix bug in MTT allocation in mem-free mode.
I misunderstood the MTT size value returned by the firmware -- it is really
the size of a single MTT entry, since mem-free mode does not segment the MTT
as the original firmware did. This meant that our MTT addresses ended up
being off by a factor of 8. Th... | ```diff
diff --git a/drivers/infiniband/hw/mthca/mthca_cmd.c b/drivers/infiniband/hw/mthca/mthca_cmd.c
index 1bc1ce758165..244d37c5bf6a 100644
--- a/drivers/infiniband/hw/mthca/mthca_cmd.c
+++ b/drivers/infiniband/hw/mthca/mthca_cmd.c
@@ -990,7 +990,6 @@ int mthca_QUERY_DEV_LIM(struct mthca_dev *dev,
MTHCA_GET(field... |
b87dcfbacee9c57b39738f43f32834f02ec302d5 | Analyze and fix the following issue in the Linux kernel code: [PATCH] IB/mthca: fix format of CQ number for CQ events | Problem Details:
CQ numbers are only 24 bits, so only print 6 hex digits and mask off reserved
part when reporting a CQ event.
Signed-off-by: Roland Dreier <roland@topspin.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org> | ```diff
diff --git a/drivers/infiniband/hw/mthca/mthca_eq.c b/drivers/infiniband/hw/mthca/mthca_eq.c
index 623daab5c92b..b6f2a46fc84b 100644
--- a/drivers/infiniband/hw/mthca/mthca_eq.c
+++ b/drivers/infiniband/hw/mthca/mthca_eq.c
@@ -344,10 +344,10 @@ static int mthca_eq_int(struct mthca_dev *dev, struct mthca_eq *eq)... |
55645e9b0ae202f9bd58e68eb141d7594163935f | Analyze and fix the following issue in the Linux kernel code: [PATCH] IB/mthca: fix MR allocation error path | Problem Details:
Fix error handling in MR allocation for mem-free mode: mthca_free must get an
MR index, not a key.
Signed-off-by: Michael S. Tsirkin <mst@mellanox.co.il>
Signed-off-by: Roland Dreier <roland@topspin.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org> | ```diff
diff --git a/drivers/infiniband/hw/mthca/mthca_mr.c b/drivers/infiniband/hw/mthca/mthca_mr.c
index 5eb6e07f35bb..66656379ea7b 100644
--- a/drivers/infiniband/hw/mthca/mthca_mr.c
+++ b/drivers/infiniband/hw/mthca/mthca_mr.c
@@ -231,7 +231,7 @@ err_out_table:
mthca_table_put(dev, dev->mr_table.mpt_table, key);... |
3fba231754eef768f6ca83900b726ecf4bc9dc5f | Analyze and fix the following issue in the Linux kernel code: [PATCH] IB/mthca: fix posting sends with immediate data | Problem Details:
When posting a work request with immediate data, put the immediate data in the
immediate data field of the hardware's work request (rather than overwriting
the flags field).
Signed-off-by: Roland Dreier <roland@topspin.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <to... | ```diff
diff --git a/drivers/infiniband/hw/mthca/mthca_qp.c b/drivers/infiniband/hw/mthca/mthca_qp.c
index 7e4bbbd31f07..1992effe3f8b 100644
--- a/drivers/infiniband/hw/mthca/mthca_qp.c
+++ b/drivers/infiniband/hw/mthca/mthca_qp.c
@@ -1465,7 +1465,7 @@ int mthca_tavor_post_send(struct ib_qp *ibqp, struct ib_send_wr *wr... |
17ead2f5cc81c4658e7b495014c2c6856a6f6b88 | Analyze and fix the following issue in the Linux kernel code: [PATCH] IB/mthca: fix calculation of RDB shift | Problem Details:
Fix calculation of rdb_shift by using original number of QPs, not
their slot in profile[] (which will be rearranged when we sort it).
Signed-off-by: Roland Dreier <roland@topspin.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org> | ```diff
diff --git a/drivers/infiniband/hw/mthca/mthca_profile.c b/drivers/infiniband/hw/mthca/mthca_profile.c
index 7881a8a919ca..9ffe76e23a9e 100644
--- a/drivers/infiniband/hw/mthca/mthca_profile.c
+++ b/drivers/infiniband/hw/mthca/mthca_profile.c
@@ -208,8 +208,7 @@ u64 mthca_make_profile(struct mthca_dev *dev,
... |
0df3bb131f789f5929f7a239869e9945e4a5a734 | Analyze and fix the following issue in the Linux kernel code: [PATCH] IB: Fix user MAD registrations with class 0 | Problem Details:
Fix handling of MAD agent registrations with mgmt_class == 0. In this case
ib_umad should pass a NULL registration request to the MAD core rather than a
request with mgmt_class set to 0.
Signed-off-by: Roland Dreier <roland@topspin.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linu... | ```diff
diff --git a/drivers/infiniband/core/user_mad.c b/drivers/infiniband/core/user_mad.c
index 54b4f33b0bf9..56b9c2fa2ecc 100644
--- a/drivers/infiniband/core/user_mad.c
+++ b/drivers/infiniband/core/user_mad.c
@@ -389,15 +389,17 @@ static int ib_umad_reg_agent(struct ib_umad_file *file, unsigned long arg)
goto o... |
de0d9641c4f164009b62ecc342f9776d44e78b6a | Analyze and fix the following issue in the Linux kernel code: [PATCH] IB: Fix FMR pool crash | Problem Details:
Mask bits correctly from jhash result in ib_fmr_hash() so that the
computed bucket index is within our hash table. This fixes an SDP
crash.
Signed-off-by: Roland Dreier <roland@topspin.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org> | ```diff
diff --git a/drivers/infiniband/core/fmr_pool.c b/drivers/infiniband/core/fmr_pool.c
index 2e9469f18926..59ee001ff05b 100644
--- a/drivers/infiniband/core/fmr_pool.c
+++ b/drivers/infiniband/core/fmr_pool.c
@@ -103,9 +103,8 @@ struct ib_fmr_pool {
static inline u32 ib_fmr_hash(u64 first_page)
{
- return jha... |
e6ded99cbbbfef2cef537d717ad61d2f77f4dfd6 | Analyze and fix the following issue in the Linux kernel code: [PATCH] IPoIB: fix static rate calculation | Problem Details:
Correct and simplify calculation of static rate. We need to round up the
quotient of (local_rate - path_rate) / path_rate. To round up we add
(path_rate - 1) to the numerator, so the quotient simplifies to (local_rate -
1) / path_rate.
No idea how I came up with the old formula.
Signed-off-by: Rola... | ```diff
diff --git a/drivers/infiniband/ulp/ipoib/ipoib_main.c b/drivers/infiniband/ulp/ipoib/ipoib_main.c
index 5a3b5c6a4494..8d35475a1d56 100644
--- a/drivers/infiniband/ulp/ipoib/ipoib_main.c
+++ b/drivers/infiniband/ulp/ipoib/ipoib_main.c
@@ -302,11 +302,10 @@ static void path_rec_completion(int status,
.sl ... |
62241eb497721be7640e5d9330e60f4a88a4db46 | Analyze and fix the following issue in the Linux kernel code: [PATCH] IPoIB: set skb->mac.raw on receive | Problem Details:
Set skb->mac.raw on receive. This fixes crashes when this is
dereferenced, for example by netfilter or when PF_PACKET is used.
Signed-off-by: Hal Rosenstock <halr@voltaire.com>
Signed-off-by: Roland Dreier <roland@topspin.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds... | ```diff
diff --git a/drivers/infiniband/ulp/ipoib/ipoib_ib.c b/drivers/infiniband/ulp/ipoib/ipoib_ib.c
index c5a1d45e0ac5..8238766746b2 100644
--- a/drivers/infiniband/ulp/ipoib/ipoib_ib.c
+++ b/drivers/infiniband/ulp/ipoib/ipoib_ib.c
@@ -201,7 +201,7 @@ static void ipoib_ib_handle_wc(struct net_device *dev,
if (wc... |
5960f3a63394c091b17682aed3bd8fdd994a1b93 | Analyze and fix the following issue in the Linux kernel code: [PATCH] arm: fix floppy disk dependencies | Problem Details:
Both the RiscPC and (optionally) EBSA285 have floppy disk support. Allow this
option to be selected on these ARM platforms again.
Signed-off-by: Russell King <rmk@arm.linux.org.uk>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org> | ```diff
diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig
index e83a1e2e8b15..e830be1a3ae6 100644
--- a/drivers/block/Kconfig
+++ b/drivers/block/Kconfig
@@ -6,7 +6,7 @@ menu "Block devices"
config BLK_DEV_FD
tristate "Normal floppy disk support"
- depends on (!ARCH_S390 && !M68K && !IA64 && !UML) || Q40 ... |
b52402c783d8c16b11f146a244bb21086a94bf84 | Analyze and fix the following issue in the Linux kernel code: [PATCH] pci enumeration on ixp2000: overflow in kernel/resource.c | Problem Details:
IXP2000 (ARM-based) platforms use a separate 'struct resource' for PCI MEM
space. Resource allocation for PCI BARs always fails because the 'root'
resource (the IXP2000 PCI MEM resource) always has the entire address space
(00000000-ffffffff) free, and find_resource() calculates the size of that
range... | ```diff
diff --git a/kernel/resource.c b/kernel/resource.c
index 35c99ac02c7c..52f696f11adf 100644
--- a/kernel/resource.c
+++ b/kernel/resource.c
@@ -266,7 +266,7 @@ static int find_resource(struct resource *root, struct resource *new,
new->start = (new->start + align - 1) & ~(align - 1);
if (alignf)
alignf(... |
d390493b11e1fc790e3840ed191a0f88e3a54ba7 | Analyze and fix the following issue in the Linux kernel code: [PATCH] opl3sa2: MODULE_PARM_DESC | Problem Details:
opl3sa2: Fix "irq"-parameter name typo for parameter description.
Signed-off-by: Magnus Damm <damm@opensource.se>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org> | ```diff
diff --git a/sound/oss/opl3sa2.c b/sound/oss/opl3sa2.c
index 7b4996e71576..2efbd865109b 100644
--- a/sound/oss/opl3sa2.c
+++ b/sound/oss/opl3sa2.c
@@ -199,7 +199,7 @@ module_param(mpu_io, int, 0);
MODULE_PARM_DESC(mpu_io, "Set MIDI I/O base (0x330 or other. Address must be even and must be from 0x300 to 0x334)... |
c41f5eb3b8feb8772561f0e34cfee4de1fa433ec | Analyze and fix the following issue in the Linux kernel code: [PATCH] efi: eliminate bad section references | Problem Details:
Randy please double check especially this one.
there may be a better solution.
Fix efi section references:
remove __initdata for struct efi efi_phys
and struct efi_memory_map memmap
Error: ./arch/i386/kernel/efi.o .text refers to 000000d3 R_386_32
.init.data
Error: ./arch/i386/kernel/efi.o .text r... | ```diff
diff --git a/arch/i386/kernel/efi.c b/arch/i386/kernel/efi.c
index 9e5e0d8bd36e..f732f427b418 100644
--- a/arch/i386/kernel/efi.c
+++ b/arch/i386/kernel/efi.c
@@ -46,8 +46,8 @@ extern efi_status_t asmlinkage efi_call_phys(void *, ...);
struct efi efi;
EXPORT_SYMBOL(efi);
-static struct efi efi_phys __initda... |
fca44804508d544b0b9d9d85279e5eea778e4e32 | Analyze and fix the following issue in the Linux kernel code: [PATCH] hd: eliminate bad section references | Problem Details:
Fix hd section references:
make parse_hd_setup() __init
Error: ./drivers/ide/legacy/hd.o .text refers to 00000943 R_386_PC32
.init.text
Signed-off-by: maximilian attems <janitor@sternwelten.at>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org> | ```diff
diff --git a/drivers/ide/legacy/hd.c b/drivers/ide/legacy/hd.c
index c4090550ec13..e884cd4b22fd 100644
--- a/drivers/ide/legacy/hd.c
+++ b/drivers/ide/legacy/hd.c
@@ -851,7 +851,7 @@ Enomem:
goto out;
}
-static int parse_hd_setup (char *line) {
+static int __init parse_hd_setup (char *line) {
int ints[6]... |
ffbe5523a8e7f808681007aaea282da9a316a699 | Analyze and fix the following issue in the Linux kernel code: [PATCH] pnpbios: eliminate bad section references | Problem Details:
one of the last buildcheck errors on i386, thanks Randy again for double
checking.
Fix pnpbios section references:
make dmi_system_id pnpbios_dmi_table __initdata
Error: ./drivers/pnp/pnpbios/core.o .data refers to 00000100 R_386_32
.init.text
Error: ./drivers/pnp/pnpbios/core.o .data refers to 00000... | ```diff
diff --git a/drivers/pnp/pnpbios/core.c b/drivers/pnp/pnpbios/core.c
index 0f6330b3af12..e939c93a931c 100644
--- a/drivers/pnp/pnpbios/core.c
+++ b/drivers/pnp/pnpbios/core.c
@@ -512,7 +512,7 @@ static int __init exploding_pnp_bios(struct dmi_system_id *d)
return 0;
}
-static struct dmi_system_id pnpbios_d... |
e1ba0dab261c1941fdf0db28868eaf459aaea089 | Analyze and fix the following issue in the Linux kernel code: [PATCH] Fix comment in list.h that refers to nonexistent API | Problem Details:
The hlist_for_each_entry_rcu() comment block refers to a nonexistent
hlist_add_rcu() API, needs to change to hlist_add_head_rcu().
Signed-off-by: Paul E. McKenney <paulmck@us.ibm.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org> | ```diff
diff --git a/include/linux/list.h b/include/linux/list.h
index dd7cd54fa831..399b51d17218 100644
--- a/include/linux/list.h
+++ b/include/linux/list.h
@@ -692,7 +692,7 @@ static inline void hlist_add_after(struct hlist_node *n,
* @member: the name of the hlist_node within the struct.
*
* This list-travers... |
29504ff3be784372c4e2f7e31681a3e0292c4d9a | Analyze and fix the following issue in the Linux kernel code: [PATCH] Direct IO async short read fix | Problem Details:
The direct I/O code is mapping the read request to the file system block. If
the file size was not on a block boundary, the result would show the the read
reading past EOF. This was only happening for the AIO case. The non-AIO case
truncates the result to match file size (in direct_io_worker). This... | ```diff
diff --git a/fs/direct-io.c b/fs/direct-io.c
index 5a674a0c7146..1d55e7e67342 100644
--- a/fs/direct-io.c
+++ b/fs/direct-io.c
@@ -66,6 +66,7 @@ struct dio {
struct bio *bio; /* bio under assembly */
struct inode *inode;
int rw;
+ loff_t i_size; /* i_size when submitted */
int lock_type; /* doesn't... |
1f08ad02379530e1c970d3d104343b9907b4d1b4 | Analyze and fix the following issue in the Linux kernel code: [PATCH] undo do_readv_writev() behavior change | Problem Details:
Bugme bug 4326: http://bugme.osdl.org/show_bug.cgi?id=4326 reports:
executing the systemcall readv with Bad argument
->len == -1) it gives out error EFAULT instead of EINVAL
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org> | ```diff
diff --git a/fs/read_write.c b/fs/read_write.c
index 6be4b1a1956b..c4c2bee373ed 100644
--- a/fs/read_write.c
+++ b/fs/read_write.c
@@ -467,10 +467,10 @@ static ssize_t do_readv_writev(int type, struct file *file,
void __user *buf = iov[seg].iov_base;
ssize_t len = (ssize_t)iov[seg].iov_len;
- if (unlik... |
e821d94d34af23a31a16ead78e8b685b750c8c3d | Analyze and fix the following issue in the Linux kernel code: [PATCH] quota: possible bug in quota format v2 support | Problem Details:
Don't put root block of quota tree to the free list (when quota file is
completely empty). That should not actually happen anyway (somebody should
get accounted for the filesystem root and so quota file should never be
empty) but better prevent it here than solve magical quota file
corruption.
Signed... | ```diff
diff --git a/fs/quota_v2.c b/fs/quota_v2.c
index 19bdb7b86ca7..7afcbb1b9376 100644
--- a/fs/quota_v2.c
+++ b/fs/quota_v2.c
@@ -503,7 +503,8 @@ static int remove_tree(struct dquot *dquot, uint *blk, int depth)
int i;
ref[GETIDINDEX(dquot->dq_id, depth)] = cpu_to_le32(0);
for (i = 0; i < V2_DQBLKSIZE && ... |
31e7ad6ac919761f0486f7781b02ff3ab54b6ef1 | Analyze and fix the following issue in the Linux kernel code: [PATCH] quota: fix possible oops on quotaoff | Problem Details:
Remove dquot structures from quota file on quotaon - quota code does not
expect them to be there.
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org> | ```diff
diff --git a/fs/dquot.c b/fs/dquot.c
index 11048e0b32c9..3995ce7907cc 100644
--- a/fs/dquot.c
+++ b/fs/dquot.c
@@ -1443,6 +1443,7 @@ static int vfs_quota_on_inode(struct inode *inode, int type, int format_id)
oldflags = inode->i_flags & (S_NOATIME | S_IMMUTABLE | S_NOQUOTA);
inode->i_flags |= S_NOQUOTA | S_... |
e072c6f2af57fb8ad9e0f29bfff3f79edf7bdd55 | Analyze and fix the following issue in the Linux kernel code: [PATCH] ext2 corruption - regression between 2.6.9 and 2.6.10 | Problem Details:
Whilst trying to stress test a Promise SX8 card, we stumbled across
some nasty filesystem corruption in ext2. Our tests involved
creating an ext2 partition, mounting, running several concurrent
fsx's over it, umounting, and fsck'ing, all scripted[1]. The fsck
would always return with errors.
This regr... | ```diff
diff --git a/fs/ext2/ext2.h b/fs/ext2/ext2.h
index 9f1a40e7945c..8f0fd726c3f1 100644
--- a/fs/ext2/ext2.h
+++ b/fs/ext2/ext2.h
@@ -116,6 +116,7 @@ extern unsigned long ext2_count_free (struct buffer_head *, unsigned);
/* inode.c */
extern void ext2_read_inode (struct inode *);
extern int ext2_write_inode (st... |
614a7d6a76b7fb37bb399047eb3ccf86cafbf60d | Analyze and fix the following issue in the Linux kernel code: [PATCH] fix up newly added jsm driver | Problem Details:
- plug various leaks and use after frees in the remove and
initialization failure path (some still left)
- remove useless global list of boards and use pci_set_drvdata instead
- unobsfucate init path by merging functions together
- kill various totally useless state variables
- .. probably more ... | ```diff
diff --git a/drivers/serial/jsm/jsm.h b/drivers/serial/jsm/jsm.h
index b12ee02a0f7c..e0717611c940 100644
--- a/drivers/serial/jsm/jsm.h
+++ b/drivers/serial/jsm/jsm.h
@@ -93,28 +93,6 @@ enum {
#define JSM_VERSION "jsm: 1.1-1-INKERNEL"
#define JSM_PARTNUM "40002438_A-INKERNEL"
-/*
- * All the possible states... |
975e046cc06005bafe0c5ce81d55a1b1eb84f5a1 | Analyze and fix the following issue in the Linux kernel code: [PATCH] fix module_param_string() calls | Problem Details:
This patch fix 3 calls to module_param_string() in
driver/media/video/tuner-core.c and drivers/media/video/tda9887.c. In all
three places, the len and the perm parameter was switched.
Signed-off-by: Bert Wesarg <wesarg@informatik.uni-halle.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-b... | ```diff
diff --git a/drivers/media/video/tda9887.c b/drivers/media/video/tda9887.c
index d9c3169f9a04..debef1910c37 100644
--- a/drivers/media/video/tda9887.c
+++ b/drivers/media/video/tda9887.c
@@ -478,9 +478,9 @@ static int tda9887_set_pinnacle(struct tda9887 *t, char *buf)
/* ---------------------------------------... |
31143a12044caa3521edafd736e3bc18c098d2fd | Analyze and fix the following issue in the Linux kernel code: [PATCH] kernel/param.c: don't use .max when .num is NULL in param_array_set() | Problem Details:
there seems to be a bug, at least for me, in kernel/param.c for arrays with
.num == NULL. If .num == NULL, the function param_array_set() uses &.max
for the call to param_array(), wich alters the .max value to the number of
arguments. The result is, you can't set more array arguments as the last
time... | ```diff
diff --git a/kernel/params.c b/kernel/params.c
index 5538608bd339..5513844bec13 100644
--- a/kernel/params.c
+++ b/kernel/params.c
@@ -314,9 +314,10 @@ int param_array(const char *name,
int param_array_set(const char *val, struct kernel_param *kp)
{
struct kparam_array *arr = kp->arg;
+ unsigned int temp_nu... |
fc9c9ab22d5650977c417ef2032d02f455011b23 | Analyze and fix the following issue in the Linux kernel code: [PATCH] AYSNC IO using singals other than SIGIO | Problem Details:
A question on sigwaitinfo based IO mechanism in multithreaded applications.
I am trying to use RT signals to notify me of IO events using RT signals
instead of SIGIO in a multithreaded applications. I noticed that there was
some discussion on lkml during november 1999 with the subject of the
discussi... | ```diff
diff --git a/fs/fcntl.c b/fs/fcntl.c
index c1708066bf55..3e7ab16ed154 100644
--- a/fs/fcntl.c
+++ b/fs/fcntl.c
@@ -437,7 +437,7 @@ static void send_sigio_to_task(struct task_struct *p,
else
si.si_band = band_table[reason - POLL_IN];
si.si_fd = fd;
- if (!send_sig_info(fown->signum, &si, p))
+ ... |
4a534f93b371e8e6e87ae302757365f0f583e06b | Analyze and fix the following issue in the Linux kernel code: [PATCH] possible use-after-free of bio | Problem Details:
There is a possibility that a bio will be accessed after it has been freed
on SCSI. It happens if you submit a bio with BIO_SYNC marked and the
auto-unplugging kicks the request_fn, SCSI re-enables interrupts in-between
so if the request completes between the add_request() in __make_request()
and the ... | ```diff
diff --git a/drivers/block/ll_rw_blk.c b/drivers/block/ll_rw_blk.c
index 02242e8ba996..2d6934a02867 100644
--- a/drivers/block/ll_rw_blk.c
+++ b/drivers/block/ll_rw_blk.c
@@ -2559,7 +2559,7 @@ EXPORT_SYMBOL(__blk_attempt_remerge);
static int __make_request(request_queue_t *q, struct bio *bio)
{
struct reque... |
9c340d80f66faaea3522812d0d8c91d6a1b48a22 | Analyze and fix the following issue in the Linux kernel code: [PATCH] uml: fix compilation for __CHOOSE_MODE addition | Problem Details:
I had added the __CHOOSE_MODE syntax to fix some warnings with newer GCC's
in the uml-fix-cond-expr-as-lvalues-warning patch.
Here is the update from the version I sent to make it work also when only
one mode (TT or SKAS) is enabled.
Signed-off-by: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.i... | ```diff
diff --git a/arch/um/include/choose-mode.h b/arch/um/include/choose-mode.h
index 8e6b62f5e9ac..f25fa83a5da6 100644
--- a/arch/um/include/choose-mode.h
+++ b/arch/um/include/choose-mode.h
@@ -11,6 +11,13 @@
#if defined(UML_CONFIG_MODE_TT) && defined(UML_CONFIG_MODE_SKAS)
#define CHOOSE_MODE(tt, skas) (mode_tt ... |
43117a08280e40be43e181c51cce296ef4b4c7e5 | Analyze and fix the following issue in the Linux kernel code: [PATCH] swsusp: SMP fix | Problem Details:
Fix some smp_processor_id-in-preemptible warnings
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org> | ```diff
diff --git a/kernel/power/smp.c b/kernel/power/smp.c
index 7fa7f6e2b7fb..cba3584b80fe 100644
--- a/kernel/power/smp.c
+++ b/kernel/power/smp.c
@@ -46,13 +46,13 @@ static cpumask_t oldmask;
void disable_nonboot_cpus(void)
{
- printk("Freezing CPUs (at %d)", smp_processor_id());
oldmask = current->cpus_allo... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.