id
stringlengths
40
40
instruction
stringlengths
68
308
input
stringlengths
17
33.4k
output
stringlengths
100
30k
bf2049f983eb47f9463d3dd54abd82e3e58846f9
Analyze and fix the following issue in the Linux kernel code: [PATCH] fix few remaining u32 vs. pm_message_t problems
Problem Details: This fixes remaining u32 vs. pm_message_t confusions in -rc2-mm3. [There are usb changes, too; they went to Greg on his request.] Signed-off-by: Pavel Machek <pavel@suse.cz> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/drivers/macintosh/via-pmu.c b/drivers/macintosh/via-pmu.c index aefc0c1a862c..fdea1a3a631d 100644 --- a/drivers/macintosh/via-pmu.c +++ b/drivers/macintosh/via-pmu.c @@ -2371,7 +2371,7 @@ pmac_suspend_devices(void) * use this but still... This will take care of sysdev's as well, so * we exit ...
3bfffd97ef913045080861d1898286ac8975c22a
Analyze and fix the following issue in the Linux kernel code: [PATCH] fix u32 vs. pm_message_t in rest of the tree
Problem Details: This fixes u32 vs. pm_message_t confusion in remaining places. Fortunately there's few of them. Signed-off-by: Pavel Machek <pavel@suse.cz> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/arch/sh/kernel/cpu/bus.c b/arch/sh/kernel/cpu/bus.c index ace82f4b4a59..d4fee2a79373 100644 --- a/arch/sh/kernel/cpu/bus.c +++ b/arch/sh/kernel/cpu/bus.c @@ -31,7 +31,7 @@ static int sh_bus_match(struct device *dev, struct device_driver *drv) return shdev->dev_id == shdrv->dev_id; } -static in...
9bfd354b1b9c2f4faee121892bdfbc1490b51ab5
Analyze and fix the following issue in the Linux kernel code: [PATCH] fix u32 vs. pm_message_t in driver/video
Problem Details: This fixes u32 vs. pm_message_t confusion in drivers/video. Should change no code. Signed-off-by: Pavel Machek <pavel@suse.cz> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/drivers/video/backlight/corgi_bl.c b/drivers/video/backlight/corgi_bl.c index 3c026b036c86..353cb3f73cf2 100644 --- a/drivers/video/backlight/corgi_bl.c +++ b/drivers/video/backlight/corgi_bl.c @@ -81,7 +81,7 @@ static void corgibl_blank(int blank) } #ifdef CONFIG_PM -static int corgibl_suspend...
0370affeec3e751412e917aab931d8ba52680578
Analyze and fix the following issue in the Linux kernel code: [PATCH] fix u32 vs. pm_message_t in drivers/
Problem Details: -rc2-mm1 still contains few places where u32 and pm_message_t. This fixes drivers/serial [should change no code]. Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/drivers/serial/amba-pl010.c b/drivers/serial/amba-pl010.c index ac57fdc8711b..484f6fb900b5 100644 --- a/drivers/serial/amba-pl010.c +++ b/drivers/serial/amba-pl010.c @@ -772,7 +772,7 @@ static int pl010_remove(struct amba_device *dev) return 0; } -static int pl010_suspend(struct amba_device *d...
b1c42851b006398dda77a068275e8741e33761f1
Analyze and fix the following issue in the Linux kernel code: [PATCH] u32 vs. pm_message_t in ppc and radeon
Problem Details: This fixes pm_message_t vs. u32 confusion in ppc and aty (I *hope* that's basically radeon code...). I was not able to test most of these, but I'm not really changing anything, so it should be okay. Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/arch/ppc64/kernel/of_device.c b/arch/ppc64/kernel/of_device.c index b27a75f1b986..f4c825a69fa0 100644 --- a/arch/ppc64/kernel/of_device.c +++ b/arch/ppc64/kernel/of_device.c @@ -104,7 +104,7 @@ static int of_device_remove(struct device *dev) return 0; } -static int of_device_suspend(struct dev...
7f4927c1b505eb4e679ab506bf7626af6258e6b6
Analyze and fix the following issue in the Linux kernel code: [PATCH] fix u32 vs. pm_message_t in PCI, PCIE
Problem Details: This fixes drivers/pci (mostly pcie stuff). Signed-off-by: Pavel Machek <pavel@suse.cz> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/drivers/pci/hotplug/pciehp_core.c b/drivers/pci/hotplug/pciehp_core.c index 8a5b2b51bde4..72baf749e65e 100644 --- a/drivers/pci/hotplug/pciehp_core.c +++ b/drivers/pci/hotplug/pciehp_core.c @@ -578,7 +578,7 @@ static void pciehp_remove (struct pcie_device *device) } #ifdef CONFIG_PM -static int...
f45139044db870835b53a0fea41da2e04c3958d0
Analyze and fix the following issue in the Linux kernel code: [PATCH] fix u32 vs. pm_message_t in drivers/macintosh
Problem Details: I thought I'm done with fixing u32 vs. pm_message_t ... unfortunately that turned out not to be the case as Russel King pointed out. Here are fixes for drivers/macintosh. Signed-off-by: Pavel Machek <pavel@suse.cz> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds...
```diff diff --git a/drivers/macintosh/macio_asic.c b/drivers/macintosh/macio_asic.c index 3a609ecd251b..d0bda7e3e6aa 100644 --- a/drivers/macintosh/macio_asic.c +++ b/drivers/macintosh/macio_asic.c @@ -106,7 +106,7 @@ static void macio_device_shutdown(struct device *dev) drv->shutdown(macio_dev); } -static int m...
0b9c33a7d6b9f1a72b2dc63bb6b8f055203d9bcb
Analyze and fix the following issue in the Linux kernel code: [PATCH] Fix u32 vs. pm_message_t in x86-64
Problem Details: I thought I'm done with fixing u32 vs. pm_message_t ... unfortunately that turned out not to be the case... Here are fixes x86-64. Signed-off-by: Pavel Machek <pavel@suse.cz> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/arch/x86_64/kernel/apic.c b/arch/x86_64/kernel/apic.c index 9826f03dc9a3..7e13545748e0 100644 --- a/arch/x86_64/kernel/apic.c +++ b/arch/x86_64/kernel/apic.c @@ -457,7 +457,7 @@ static struct { unsigned int apic_thmr; } apic_pm_state; -static int lapic_suspend(struct sys_device *dev, u32 state...
e2d53566a757c8d12246d8daf8c5a2f21a0c4293
Analyze and fix the following issue in the Linux kernel code: [PATCH] fix pm_message_t vs. u32 in alsa
Problem Details: I thought I'm done with fixing u32 vs. pm_message_t ... unfortunately that turned out not to be the case as Russel King pointed out. This fixes last few bits in alsa. Signed-off-by: Pavel Machek <pavel@suse.cz> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osd...
```diff diff --git a/sound/core/init.c b/sound/core/init.c index 3f1fa8eabb72..d72f58f450ce 100644 --- a/sound/core/init.c +++ b/sound/core/init.c @@ -744,7 +744,7 @@ struct snd_generic_device { #define SND_GENERIC_NAME "snd_generic_pm" -static int snd_generic_suspend(struct device *dev, u32 state, u32 level); +st...
e5378ca8c0ab684bd9339dc6827dd5a042f9e6fc
Analyze and fix the following issue in the Linux kernel code: [PATCH] fix u32 vs. pm_message_t in drivers/mmc,mtd,scsi
Problem Details: This fixes u32 vs. pm_message_t in drivers/mmc, drivers/mtd and drivers/scsi. Signed-off-by: Pavel Machek <pavel@suse.cz> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c index e40026328251..eeb9f6668e69 100644 --- a/drivers/mmc/mmc.c +++ b/drivers/mmc/mmc.c @@ -884,7 +884,7 @@ EXPORT_SYMBOL(mmc_free_host); * @host: mmc host * @state: suspend mode (PM_SUSPEND_xxx) */ -int mmc_suspend_host(struct mmc_host *host, u32 state) ...
8d189f729829369edb2e797e9a6ebc2b01b359d0
Analyze and fix the following issue in the Linux kernel code: [PATCH] fix u32 vs. pm_message_t in drivers/message
Problem Details: This fixes u32 vs. pm_message_t in drivers/message. Signed-off-by: Pavel Machek <pavel@suse.cz> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/drivers/message/fusion/mptbase.c b/drivers/message/fusion/mptbase.c index 942cc1c2a186..8b22630f1aef 100644 --- a/drivers/message/fusion/mptbase.c +++ b/drivers/message/fusion/mptbase.c @@ -1429,7 +1429,7 @@ mptbase_shutdown(struct device * dev) * */ static int -mptbase_suspend(struct pci_dev ...
a291068991c4d0cc4c2bd533094422bf417c86dd
Analyze and fix the following issue in the Linux kernel code: [PATCH] fix u32 vs. pm_message_t in drivers/media
Problem Details: Here are fixes for drivers/media. Signed-off-by: Pavel Machek <pavel@suse.cz> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/drivers/media/dvb/cinergyT2/cinergyT2.c b/drivers/media/dvb/cinergyT2/cinergyT2.c index f1f539761371..28d4d926de3e 100644 --- a/drivers/media/dvb/cinergyT2/cinergyT2.c +++ b/drivers/media/dvb/cinergyT2/cinergyT2.c @@ -879,7 +879,7 @@ static void cinergyt2_disconnect (struct usb_interface *intf) k...
8bf28030f3683f69669d08cb5b32bc46db3d22ae
Analyze and fix the following issue in the Linux kernel code: [PATCH] fix u32 vs. pm_message_t in pcmcia
Problem Details: This fixes u32 vs. pm_message_t in pcmcia. Signed-off-by: Pavel Machek <pavel@suse.cz> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/drivers/pcmcia/au1000_generic.c b/drivers/pcmcia/au1000_generic.c index 9fa7f15d89e5..0a5c95807cf2 100644 --- a/drivers/pcmcia/au1000_generic.c +++ b/drivers/pcmcia/au1000_generic.c @@ -518,7 +518,7 @@ static int au1x00_drv_pcmcia_probe(struct device *dev) } -static int au1x00_drv_pcmcia_suspe...
05adc3b7458e97a1d0180828000207a403083389
Analyze and fix the following issue in the Linux kernel code: [PATCH] u32 vs. pm_message_t fixes for drivers/net
Problem Details: This fixes remaining u32s in drivers/ net. Signed-off-by: Pavel Machek <pavel@suse.cz> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/drivers/net/8139cp.c b/drivers/net/8139cp.c index 58c6a85c3aa2..d639cb8dc461 100644 --- a/drivers/net/8139cp.c +++ b/drivers/net/8139cp.c @@ -1824,7 +1824,7 @@ static void cp_remove_one (struct pci_dev *pdev) } #ifdef CONFIG_PM -static int cp_suspend (struct pci_dev *pdev, u32 state) +static in...
4fd416c14c583ee6ff1e2b17ab05e7e02e170e4c
Analyze and fix the following issue in the Linux kernel code: [PATCH] Fix u32 vs. pm_message_t in drivers/char
Problem Details: Here are fixes for drivers/char. Signed-off-by: Pavel Machek <pavel@suse.cz> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/drivers/char/agp/efficeon-agp.c b/drivers/char/agp/efficeon-agp.c index 52c0a097118c..2a87cecdc912 100644 --- a/drivers/char/agp/efficeon-agp.c +++ b/drivers/char/agp/efficeon-agp.c @@ -408,7 +408,7 @@ static void __devexit agp_efficeon_remove(struct pci_dev *pdev) agp_put_bridge(bridge); } -s...
438510f6f079e94df294936b5bd8a7fd679cd1c9
Analyze and fix the following issue in the Linux kernel code: [PATCH] pm_message_t: more fixes in common and i386
Problem Details: I thought I'm done with fixing u32 vs. pm_message_t ... unfortunately that turned out not to be the case as Russel King pointed out. Here are fixes for Documentation and common code (mainly system devices). Signed-off-by: Pavel Machek <pavel@suse.cz> Signed-off-by: Andrew Morton <akpm@osdl.org> Sig...
```diff diff --git a/Documentation/driver-model/bus.txt b/Documentation/driver-model/bus.txt index dd62c7b80b3f..5001b7511626 100644 --- a/Documentation/driver-model/bus.txt +++ b/Documentation/driver-model/bus.txt @@ -18,7 +18,7 @@ struct bus_type { int (*match)(struct device * dev, struct device_driver * drv); i...
74ad74c1581c9a27582945ca01ffdb88fc774171
Analyze and fix the following issue in the Linux kernel code: [PATCH] h8300 header update
Problem Details: - page.h: fix build error - unistd.h: _syscall macro cleanup. Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/include/asm-h8300/page.h b/include/asm-h8300/page.h index 58b053f1ef3b..e3b7960d445b 100644 --- a/include/asm-h8300/page.h +++ b/include/asm-h8300/page.h @@ -79,7 +79,7 @@ extern unsigned long memory_end; #ifndef __ASSEMBLY__ -#define __pa(vaddr) virt_to_phys((void *)vaddr) +#define __pa(vadd...
d31ddaa1722793228b364e87b6c589023b348798
Analyze and fix the following issue in the Linux kernel code: [PATCH] x86, x86_64: dual core proc-cpuinfo and sibling-map fix
Problem Details: - broken sibling_map setup in x86_64 - grouping all the core and HT related cpuinfo fields. We are reasonably sure that adding new cpuinfo fields after "siblings" field, will not cause any app failure. Thats because today's /proc/cpuinfo format is completely different on x86, x86_64 and we haven...
```diff diff --git a/arch/i386/kernel/cpu/proc.c b/arch/i386/kernel/cpu/proc.c index 0f1125b15b76..4f28eba7fb8a 100644 --- a/arch/i386/kernel/cpu/proc.c +++ b/arch/i386/kernel/cpu/proc.c @@ -98,6 +98,8 @@ static int show_cpuinfo(struct seq_file *m, void *v) seq_printf(m, "physical id\t: %d\n", phys_proc_id[n]); s...
635186447d0e6f3b35895fda993a266a1315d2a7
Analyze and fix the following issue in the Linux kernel code: [PATCH] x86_64: Final support for AMD dual core
Problem Details: Clean up the code greatly. Now uses the infrastructure from the Intel dual core patch Should fix a final bug noticed by Tyan of not detecting the nodes correctly in some corner cases. Patch for x86-64 and i386 Signed-off-by: Andi Kleen <ak@suse.de> Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl> Sign...
```diff diff --git a/arch/i386/kernel/cpu/amd.c b/arch/i386/kernel/cpu/amd.c index fa10d0a509c7..8d182e875cd7 100644 --- a/arch/i386/kernel/cpu/amd.c +++ b/arch/i386/kernel/cpu/amd.c @@ -24,6 +24,9 @@ __asm__(".align 4\nvide: ret"); static void __init init_amd(struct cpuinfo_x86 *c) { +#ifdef CONFIG_SMP + int cpu =...
daeeafecf029a05a304fa299706b3ecc90e16175
Analyze and fix the following issue in the Linux kernel code: [PATCH] x86_64: Keep only a single debug notifier chain
Problem Details: Calling a notifier three times in the debug handler does not make much sense, because a debugger can figure out the various conditions by itself. Remove the additional calls to DIE_DEBUG and DIE_DEBUGSTEP completely. This matches what i386 does now. This also makes sure interrupts are always still d...
```diff diff --git a/arch/x86_64/kernel/traps.c b/arch/x86_64/kernel/traps.c index 2f42fd5c075f..f6ccf155e3e5 100644 --- a/arch/x86_64/kernel/traps.c +++ b/arch/x86_64/kernel/traps.c @@ -659,9 +659,9 @@ asmlinkage void do_debug(struct pt_regs * regs, unsigned long error_code) asm("movq %%db6,%0" : "=r" (condition)); ...
a1e9778203b15b86bc2219e87478d3be9acce735
Analyze and fix the following issue in the Linux kernel code: [PATCH] x86_64: Port over e820 gap detection from i386
Problem Details: Look for gaps in the e820 memory map to put PCI resources in. This hopefully fixes problems with the PCI code assigning 32bit BARs MMIO resources which are >32bit. Signed-off-by: Andi Kleen <ak@suse.de> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/arch/x86_64/kernel/e820.c b/arch/x86_64/kernel/e820.c index 657003e461e6..56516ac92e5d 100644 --- a/arch/x86_64/kernel/e820.c +++ b/arch/x86_64/kernel/e820.c @@ -511,3 +511,62 @@ void __init parse_memopt(char *p, char **from) end_user_pfn >>= PAGE_SHIFT; } +unsigned long pci_mem_start = 0xae...
cf94b62f7005805be0a3ba02c624cb8cd3595bac
Analyze and fix the following issue in the Linux kernel code: [PATCH] x86_64-always-use-cpuid-80000008-to-figure-out-mtrr fix
Problem Details: We need to use the size_and_mask in set_mtrr_var_ranges(which is called while programming MTRR's for AP's Signed-off-by: Suresh Siddha <suresh.b.siddha@intel.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/arch/i386/kernel/cpu/mtrr/generic.c b/arch/i386/kernel/cpu/mtrr/generic.c index a4cce454d09b..9f7a7ea6388d 100644 --- a/arch/i386/kernel/cpu/mtrr/generic.c +++ b/arch/i386/kernel/cpu/mtrr/generic.c @@ -193,7 +193,8 @@ static int set_mtrr_var_ranges(unsigned int index, struct mtrr_var_range *vr) ...
1c1734090ebcd31e479798b3af4c260ae09bf3a4
Analyze and fix the following issue in the Linux kernel code: [PATCH] x86_64: Correct wrong comment in local.h
Problem Details: local_t is actually a win over atomic_t because it does not need lock prefixes. Signed-off-by: Andi Kleen <ak@suse.de> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/include/asm-x86_64/local.h b/include/asm-x86_64/local.h index 169c223a8452..c954f15c1a75 100644 --- a/include/asm-x86_64/local.h +++ b/include/asm-x86_64/local.h @@ -45,7 +45,8 @@ static __inline__ void local_sub(unsigned long i, local_t *v) :"ir" (i), "m" (v->counter)); } -/* On x86, these a...
cdd219cd1f9e657aead247dfa1ecfdeb37efdf70
Analyze and fix the following issue in the Linux kernel code: [PATCH] x86_64: Fix a small missing schedule race
Problem Details: Could lead to a lost reschedule event when the process already rescheduled on exception exit, and needs it again while still being in the kernel. Unlikely case though. Also remove one redundant cli in another entry.S path. Signed-off-by: Andi Kleen <ak@suse.de> Signed-off-by: Andrew Morton <akpm@osd...
```diff diff --git a/arch/x86_64/kernel/entry.S b/arch/x86_64/kernel/entry.S index 3e888c2e5a06..887c5f017d28 100644 --- a/arch/x86_64/kernel/entry.S +++ b/arch/x86_64/kernel/entry.S @@ -284,6 +284,7 @@ int_careful: pushq %rdi call schedule popq %rdi + cli jmp int_with_check /* handle signals and tracing --...
6fefb0d17599d63e9d30c23bcbe2d4e06477cd55
Analyze and fix the following issue in the Linux kernel code: [PATCH] x86_64: Regularize exception stack handling
Problem Details: This fixes various issues in the return path for "paranoid" handlers (= running on a private exception stack that act like NMIs). Generalize previous hack to switch back to process stack for scheduling/signal handling purposes. Signed-off-by: Andi Kleen <ak@suse.de> Signed-off-by: Andrew Morton <akpm...
```diff diff --git a/arch/x86_64/kernel/entry.S b/arch/x86_64/kernel/entry.S index 12a307100929..3e888c2e5a06 100644 --- a/arch/x86_64/kernel/entry.S +++ b/arch/x86_64/kernel/entry.S @@ -579,6 +579,7 @@ ENTRY(spurious_interrupt) movq ORIG_RAX(%rsp),%rsi movq $-1,ORIG_RAX(%rsp) call \sym + cli .endm /* @@ -7...
11b854b2f10f398f9a18c65e202853f929dd3185
Analyze and fix the following issue in the Linux kernel code: [PATCH] x86_64: Call do_notify_resume unconditionally in entry.S
Problem Details: This removes some unnecessary code in the assembly files. Matches i386 behaviour. In addition don't clear the work check mask after work has been done. This fixes some theoretical signal/other event losses. Signed-off-by: Andi Kleen <ak@suse.de> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-of...
```diff diff --git a/arch/x86_64/kernel/entry.S b/arch/x86_64/kernel/entry.S index 053d6e80c31f..12a307100929 100644 --- a/arch/x86_64/kernel/entry.S +++ b/arch/x86_64/kernel/entry.S @@ -197,7 +197,7 @@ ENTRY(system_call) */ .globl ret_from_sys_call ret_from_sys_call: - movl $_TIF_WORK_MASK,%edi + movl $_TIF_ALL...
d61915da63e2ef03d9034e3b2ec7d8cca55d7584
Analyze and fix the following issue in the Linux kernel code: [PATCH] x86_64: Fix interaction of single stepping with debuggers
Problem Details: Ported from i386/Linus Fix another TF corner case. Need to do the special TF handling for all signals to make debuggers happy Signed-off-by: Andi Kleen <ak@suse.de> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/arch/x86_64/kernel/signal.c b/arch/x86_64/kernel/signal.c index 4ff0f0117a09..7760224cdfe3 100644 --- a/arch/x86_64/kernel/signal.c +++ b/arch/x86_64/kernel/signal.c @@ -368,6 +368,18 @@ handle_signal(unsigned long sig, siginfo_t *info, struct k_sigaction *ka, } } + /* + * If TF is set due ...
e502cdd63de666832b3b65017bb607c22d2868de
Analyze and fix the following issue in the Linux kernel code: [PATCH] x86_64: Handle programs that set TF in user space using popf while single stepping
Problem Details: Ported from i386/Linus Still won't handle other TF changing instructions like IRET or LAHF. Prefix handling must be double checked... Signed-off-by: Andi Kleen <ak@suse.de> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/arch/x86_64/kernel/ptrace.c b/arch/x86_64/kernel/ptrace.c index 002237c3b6a2..c7011675007d 100644 --- a/arch/x86_64/kernel/ptrace.c +++ b/arch/x86_64/kernel/ptrace.c @@ -86,6 +86,84 @@ static inline long put_stack_long(struct task_struct *task, int offset, return 0; } +#define LDT_SEGMENT 4 + ...
be61bff789fe44bfb6d9282d8f7eccc860bdcfb6
Analyze and fix the following issue in the Linux kernel code: [PATCH] x86_64: Some fixes for single step handling
Problem Details: Ported from i386/Linus Be more careful with TF handling to fix some copy protection codes in Wine Signed-off-by: Andi Kleen <ak@suse.de> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/arch/x86_64/kernel/signal.c b/arch/x86_64/kernel/signal.c index 5ace32c6ac5c..4ff0f0117a09 100644 --- a/arch/x86_64/kernel/signal.c +++ b/arch/x86_64/kernel/signal.c @@ -185,7 +185,6 @@ static inline int setup_sigcontext(struct sigcontext __user *sc, struct pt_regs *regs, unsigned long mask, struc...
107ce721abddbd876aa6203ac982821e405400e9
Analyze and fix the following issue in the Linux kernel code: [PATCH] x86_64: disable interrupts during SMP bogomips checking
Problem Details: Port over a i386 kludge from rusty to x86-64 I don't think it is a full solution, but the upcomming smp bootup rewrite will solve it. This fixes BUGs at bootup on bigger x86-64 systems. Signed-off-by: Andi Kleen <ak@suse.de> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds ...
```diff diff --git a/arch/x86_64/kernel/smpboot.c b/arch/x86_64/kernel/smpboot.c index afd3600b919e..e5714090b00d 100644 --- a/arch/x86_64/kernel/smpboot.c +++ b/arch/x86_64/kernel/smpboot.c @@ -304,8 +304,6 @@ static void __init smp_callin(void) Dprintk("CALLIN, before setup_local_APIC().\n"); setup_local_APIC(); ...
f18de453eb52dae49bc512ccfa638d9a0f153771
Analyze and fix the following issue in the Linux kernel code: [PATCH] x86-64: Fix BUG()
Problem Details: Use the correct file name in BUG() Signed-off-by: Andi Kleen <ak@suse.de> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/include/asm-x86_64/bug.h b/include/asm-x86_64/bug.h index d2032f56e87c..19aed6e78fec 100644 --- a/include/asm-x86_64/bug.h +++ b/include/asm-x86_64/bug.h @@ -18,7 +18,7 @@ struct bug_frame { #define HAVE_ARCH_BUG #define BUG() \ asm volatile("ud2 ; .quad %c1 ; .short %c0" :: \ - "i"(__LIN...
ecd02dddd1d5bfc2141cbd0e205a53fb9d849c9e
Analyze and fix the following issue in the Linux kernel code: [PATCH] i386: Use loaddebug macro consistently
Problem Details: This moves the macro loaddebug from asm-i386/suspend.h to asm-i386/processor.h, which is the place that makes sense for it to be defined, removes the extra copy of the same macro in arch/i386/kernel/process.c, and makes arch/i386/kernel/signal.c use the macro in place of its expansion. This is a purel...
```diff diff --git a/arch/i386/kernel/process.c b/arch/i386/kernel/process.c index 36145efc61b5..b2203e21acb3 100644 --- a/arch/i386/kernel/process.c +++ b/arch/i386/kernel/process.c @@ -558,13 +558,6 @@ handle_io_bitmap(struct thread_struct *next, struct tss_struct *tss) */ tss->io_bitmap_base = INVALID_IO_BITMAP...
e63f8f439de010b6227c0c9c6f56e2c44dbe5dae
Analyze and fix the following issue in the Linux kernel code: [PATCH] ppc64: no prefetch for NULL pointers
Problem Details: For prefetches of NULL (as when walking a short linked list), PPC64 will in some cases take a performance hit. The hardware needs to do the TLB walk, and said walk will always miss, which means (up to) two L2 misses as penalty. This seems to hurt overall performance, so for NULL pointers skip the pre...
```diff diff --git a/include/asm-ppc64/processor.h b/include/asm-ppc64/processor.h index eb33d33cfd6d..cae65b30adb8 100644 --- a/include/asm-ppc64/processor.h +++ b/include/asm-ppc64/processor.h @@ -642,11 +642,17 @@ static inline unsigned long __pack_fe01(unsigned int fpmode) static inline void prefetch(const void ...
89e09f5ebba4bcde9852e4be4af536d5b691f20a
Analyze and fix the following issue in the Linux kernel code: [PATCH] ppc64: remove -fno-omit-frame-pointer
Problem Details: During some code inspection using gcc 4.0 I noticed a stack frame was being created for a number of functions that didnt require it. For example: c0000000000df944 <._spin_unlock>: c0000000000df944: fb e1 ff f0 std r31,-16(r1) c0000000000df948: f8 21 ff c1 stdu r1,-64(r1) c0...
```diff diff --git a/arch/ppc64/Kconfig b/arch/ppc64/Kconfig index 15c4a1455cae..ef1f05e437c4 100644 --- a/arch/ppc64/Kconfig +++ b/arch/ppc64/Kconfig @@ -40,10 +40,6 @@ config COMPAT bool default y -config FRAME_POINTER - bool - default y - # We optimistically allocate largepages from the VM, so make the limit ...
187335a4ec72c9bc7f3f168d6858a41fcfb63302
Analyze and fix the following issue in the Linux kernel code: [PATCH] ppc64: Detect altivec via firmware on unknown CPUs
Problem Details: This patch adds detection of the Altivec capability of the CPU via the firmware in addition to the cpu table. This allows newer CPUs that aren't in the table to still have working altivec support in the kernel. It also fixes a problem where if a CPU isn't recognized as having altivec features, and ta...
```diff diff --git a/arch/ppc64/kernel/head.S b/arch/ppc64/kernel/head.S index fe05f3fbf9d0..92a744c31ab1 100644 --- a/arch/ppc64/kernel/head.S +++ b/arch/ppc64/kernel/head.S @@ -922,7 +922,9 @@ fp_unavailable_common: altivec_unavailable_common: EXCEPTION_PROLOG_COMMON(0xf20, PACA_EXGEN) #ifdef CONFIG_ALTIVEC +BEGI...
fa89c5092eddcbcb425a1416f85906e3cc519793
Analyze and fix the following issue in the Linux kernel code: [PATCH] ppc64: fix export of wrong symbol
Problem Details: In arch/ppc64/kernel/ppc_ksyms.c, we are still exporting flush_icache_range, but that has been changed to be an inline in include/asm-ppc64/cacheflush.h which calls __flush_icache_range (defined in arch/ppc64/kernel/misc.S). This patch changes the export to __flush_icache_range, thus allowing modules ...
```diff diff --git a/arch/ppc64/kernel/ppc_ksyms.c b/arch/ppc64/kernel/ppc_ksyms.c index 6ced63a3439f..b230a63fe4c8 100644 --- a/arch/ppc64/kernel/ppc_ksyms.c +++ b/arch/ppc64/kernel/ppc_ksyms.c @@ -74,7 +74,7 @@ EXPORT_SYMBOL(giveup_fpu); #ifdef CONFIG_ALTIVEC EXPORT_SYMBOL(giveup_altivec); #endif -EXPORT_SYMBOL(fl...
dfbacdc1a0b568dfa69fb2c1b39b608074001083
Analyze and fix the following issue in the Linux kernel code: [PATCH] ppc64: Fix semantics of __ioremap
Problem Details: This patch fixes ppc64 __ioremap() so that it stops adding implicitely _PAGE_GUARDED when the cache is not writeback, and instead, let the callers provide the flag they want here. This allows things like framebuffers to explicitely request a non-cacheable and non-guarded mapping which is more efficien...
```diff diff --git a/arch/ppc64/kernel/maple_setup.c b/arch/ppc64/kernel/maple_setup.c index 1db6ea0f336f..8cf95a27178e 100644 --- a/arch/ppc64/kernel/maple_setup.c +++ b/arch/ppc64/kernel/maple_setup.c @@ -142,7 +142,7 @@ static void __init maple_init_early(void) if (physport) { void *comport; /* Map the uart ...
16b817579fb61050f1abcc0e81089974328a9c27
Analyze and fix the following issue in the Linux kernel code: [PATCH] ppc32: MV643XX ethernet is an option for Pegasos
Problem Details: This patch allows Kconfig to build the MV643xx ethernet driver on Pegasos (CONFIG_PPC_MULTIPLATFORM) and adds what I think is a missing fix from Dale's batch, that is remove SA_INTERRUPT and add SA_SHIRQ in there as the interrupt is shared if I understand things correctly. Signed-off-by: Benjamin Herr...
```diff diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig index 74d57865a819..68242bda4b9c 100644 --- a/drivers/net/Kconfig +++ b/drivers/net/Kconfig @@ -2044,7 +2044,7 @@ config GFAR_NAPI config MV643XX_ETH tristate "MV-643XX Ethernet support" - depends on MOMENCO_OCELOT_C || MOMENCO_JAGUAR_ATX || MV64360 ||...
d8f6098d5b0e9755c79d05e30b185a6e964fd3fa
Analyze and fix the following issue in the Linux kernel code: [PATCH] ppc32: fix compilation error in arch/ppc/syslib/open_pic_defs.h
Problem Details: make defconfig give the following error on ppc (gcc-4): arch/ppc/syslib/open_pic.c:36: error: static declaration of ‘OpenPIC’ follows non-static declaration arch/ppc/syslib/open_pic_defs.h:175: error: previous declaration of ‘OpenPIC’ was here Signed-Off-By: Benoit Boissinot <benoit.boissinot@ens-lyo...
```diff diff --git a/arch/ppc/syslib/open_pic_defs.h b/arch/ppc/syslib/open_pic_defs.h index 4f05624b249e..6c94e7131463 100644 --- a/arch/ppc/syslib/open_pic_defs.h +++ b/arch/ppc/syslib/open_pic_defs.h @@ -172,9 +172,6 @@ struct OpenPIC { OpenPIC_Processor Processor[OPENPIC_MAX_PROCESSORS]; }; -extern volatile...
cd2c169e6a2d15dce3f526b1e2f97e843f8f5787
Analyze and fix the following issue in the Linux kernel code: [PATCH] ppc32: fix compilation error in include/asm/prom.h
Problem Details: make defconfig give the following error on ppc (gcc-4): arch/ppc/syslib/prom_init.c:120: error: static declaration of ‘prom_display_paths’ follows non-static declaration include/asm/prom.h:17: error: previous declaration of ‘prom_display_paths’ was here arch/ppc/syslib/prom_init.c:122: error: static d...
```diff diff --git a/include/asm-ppc/prom.h b/include/asm-ppc/prom.h index 56394c6cf52e..75c0637acdc8 100644 --- a/include/asm-ppc/prom.h +++ b/include/asm-ppc/prom.h @@ -14,9 +14,6 @@ typedef u32 phandle; typedef u32 ihandle; -extern char *prom_display_paths[]; -extern unsigned int prom_num_displays; - struct add...
51e6606491a0f5deaba52fb00c0374b9cb612f98
Analyze and fix the following issue in the Linux kernel code: [PATCH] ppc32: fix compilation error in arch/ppc/kernel/time.c
Problem Details: make defconfig give the following error on ppc (gcc-4): arch/ppc/kernel/time.c:92: error: static declaration of ‘time_offset’ follows non-static declaration include/linux/timex.h:236: error: previous declaration of ‘time_offset’ was here The following patch solves it (time_offset is declared in timer...
```diff diff --git a/arch/ppc/kernel/time.c b/arch/ppc/kernel/time.c index b3cee6b01454..735866559199 100644 --- a/arch/ppc/kernel/time.c +++ b/arch/ppc/kernel/time.c @@ -89,8 +89,6 @@ unsigned long tb_to_ns_scale; extern unsigned long wall_jiffies; -static long time_offset; - DEFINE_SPINLOCK(rtc_lock); EXPORT...
9ce3a719bc5772bc84ab6f50ef505da6992778ff
Analyze and fix the following issue in the Linux kernel code: [PATCH] ppc32: fix compilation error in include/asm-m68k/setup.h
Problem Details: make defconfig give the following error on ppc (gcc-4): include/asm-m68k/setup.h:365: error: array type has incomplete element type Signed-Off-By: Benoit Boissinot <benoit.boissinot@ens-lyon.org> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/include/asm-m68k/setup.h b/include/asm-m68k/setup.h index 9e23492685eb..a89aa84073e5 100644 --- a/include/asm-m68k/setup.h +++ b/include/asm-m68k/setup.h @@ -360,14 +360,14 @@ extern int m68k_is040or060; #define COMMAND_LINE_SIZE CL_SIZE #ifndef __ASSEMBLY__ -extern int m68k_num_memory; /* # o...
ef2f3253f061cbb86da25411a6e6e6a69a84b6ac
Analyze and fix the following issue in the Linux kernel code: [PATCH] ppc32: Fix building 32bit kernel for 64bit machines
Problem Details: When building a ppc32 MULTIPLATFORM kernel for a 64bit pmac, we try and build certain files or use certain functions that make no sense in that context. This catches the last of these. Signed-off-by: Tom Rini <trini@kernel.crashing.org> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linu...
```diff diff --git a/arch/ppc/boot/simple/Makefile b/arch/ppc/boot/simple/Makefile index d8d801fcee10..c28061ad5982 100644 --- a/arch/ppc/boot/simple/Makefile +++ b/arch/ppc/boot/simple/Makefile @@ -123,10 +123,13 @@ zimageinitrd-$(pcore) := zImage.initrd-STRIPELF end-$(pcore) := pcore cacheflag-$(pco...
54095a6ec7b11a008c07c5016b025206a051f560
Analyze and fix the following issue in the Linux kernel code: [PATCH] ppc32: Fix a problem with NTP on !(chrp||gemini)
Problem Details: The following problem was found by Giovambattista Pulcini <gpulcini@swintel.it>, who also provided a partial patch, and this has been verified by our time guru Gabriel Paubert <paubert@iram.es>. The problem is that in do_settimeofday() we always set time_state to TIME_ERROR and except on two platforms...
```diff diff --git a/arch/ppc/kernel/time.c b/arch/ppc/kernel/time.c index 50724139402c..b3cee6b01454 100644 --- a/arch/ppc/kernel/time.c +++ b/arch/ppc/kernel/time.c @@ -272,7 +272,6 @@ int do_settimeofday(struct timespec *tv) time_adjust = 0; /* stop active adjtime() */ time_status |= STA_UNSYNC;...
fd16230a05751af5a221a1f1c988bb519fd66679
Analyze and fix the following issue in the Linux kernel code: [PATCH] ppc32: Fix mpc8xx watchdog
Problem Details: The CONFIG_8xx_WDT option got broken in the generic hardirq update as ppc32 had its own different request_irq that worked when other arches used setup_irq. This is the trivial fix for the problem. From: Carsten Juttner <carjay@gmx.net> Signed-off-by: Tom Rini <trini@kernel.crashing.org> Signed-off-by...
```diff diff --git a/arch/ppc/syslib/m8xx_wdt.c b/arch/ppc/syslib/m8xx_wdt.c index 7838a44bfd1d..2ddc857e7fc7 100644 --- a/arch/ppc/syslib/m8xx_wdt.c +++ b/arch/ppc/syslib/m8xx_wdt.c @@ -11,6 +11,7 @@ #include <linux/init.h> #include <linux/interrupt.h> +#include <linux/irq.h> #include <linux/kernel.h> #include <...
7a1e335085ead05da08f791340f58b493126894d
Analyze and fix the following issue in the Linux kernel code: [PATCH] ppc32: Fix pte_update for 64-bit PTEs
Problem Details: While the existing pte_update code handled atomically modifying a 64-bit PTE, it did not return all 64-bits of the PTE before it was modified. This causes problems in some places that expect the full PTE to be returned, like ptep_get_and_clear(). Created a new pte_update function that is conditional ...
```diff diff --git a/include/asm-ppc/pgtable.h b/include/asm-ppc/pgtable.h index 19dfb7abaa21..2e88cd9feffe 100644 --- a/include/asm-ppc/pgtable.h +++ b/include/asm-ppc/pgtable.h @@ -526,10 +526,10 @@ extern void add_hash_page(unsigned context, unsigned long va, * Atomic PTE updates. * * pte_update clears and set...
0c541b4406a68e74d94ddb667c69d9e03bce8681
Analyze and fix the following issue in the Linux kernel code: [PATCH] ppc32: Fix AGP and sleep again
Problem Details: My previous patch that added sleep support for uninorth-agp and some AGP "off" stuff in radeonfb and aty128fb is breaking some configs. More specifically, it has problems with rage128 setups since the DRI code for these in X doesn't properly re-enable AGP on wakeup or console switch (unlike the radeon...
```diff diff --git a/arch/ppc/platforms/pmac_feature.c b/arch/ppc/platforms/pmac_feature.c index eda9c80746a4..24b42fd9e014 100644 --- a/arch/ppc/platforms/pmac_feature.c +++ b/arch/ppc/platforms/pmac_feature.c @@ -2944,3 +2944,48 @@ void __pmac pmac_call_early_video_resume(void) if (pmac_early_vresume_proc) pmac_...
7a648b9ec09f32606fe0f27fb9d095311cf968ca
Analyze and fix the following issue in the Linux kernel code: [PATCH] ppc32: Fix cpufreq problems
Problem Details: This patch updates the PowerMac cpufreq driver. It depends on the addition of the suspend() method (my previous patch) and on the new flag I defined to silence some warnings that are normal for us. It fixes various issues related to cpufreq on pmac, including some crashes on some models when sleeping...
```diff diff --git a/arch/ppc/platforms/pmac_cpufreq.c b/arch/ppc/platforms/pmac_cpufreq.c index 9c85f9ca1cfb..f7fb2786cd50 100644 --- a/arch/ppc/platforms/pmac_cpufreq.c +++ b/arch/ppc/platforms/pmac_cpufreq.c @@ -1,13 +1,18 @@ /* * arch/ppc/platforms/pmac_cpufreq.c * - * Copyright (C) 2002 - 2004 Benjamin Herr...
6c26e03b2db4b66d79bfb774628c1fc9b458b943
Analyze and fix the following issue in the Linux kernel code: [PATCH] ppc32: fix single-stepping of emulated instructions
Problem Details: On ppc, we emulate instructions that cause alignment exceptions. If we are single-stepping an instruction and it causes an alignment exception, we will currently do the next instruction as well before taking the single-step exception. This patch fixes that, so we take the single-step exception after ...
```diff diff --git a/arch/ppc/kernel/traps.c b/arch/ppc/kernel/traps.c index aec225b402ae..002322a1f3ce 100644 --- a/arch/ppc/kernel/traps.c +++ b/arch/ppc/kernel/traps.c @@ -679,6 +679,7 @@ void AlignmentException(struct pt_regs *regs) fixed = fix_alignment(regs); if (fixed == 1) { regs->nip += 4; /* skip over ...
35b535d9cc8dce79c3b72f47c4417c3159d7a8c9
Analyze and fix the following issue in the Linux kernel code: [PATCH] ppc32: ppc4xx_pic - add acknowledge when enabling level-sensitive IRQ
Problem Details: This patch adds interrupt acknowledge to the PPC4xx PIC enable_irq implementation for level-sensitive IRQ sources. This helps in cases when enable/disable_irq is used in interrupt handlers for hardware, which requires IRQ acknowledge to be issued from non-interrupt context (e.g. when actual ACK in de...
```diff diff --git a/arch/ppc/syslib/ppc4xx_pic.c b/arch/ppc/syslib/ppc4xx_pic.c index 08f06dd17e7b..05686fa73545 100644 --- a/arch/ppc/syslib/ppc4xx_pic.c +++ b/arch/ppc/syslib/ppc4xx_pic.c @@ -41,7 +41,10 @@ extern unsigned char ppc4xx_uic_ext_irq_cfg[] __attribute__ ((weak)); #define UIC_HANDLERS(n) \ static...
16acbc624e2b7b750570cb672341d05a816051f4
Analyze and fix the following issue in the Linux kernel code: [PATCH] ppc32: fix bogosity in process-freezing code
Problem Details: The code that went into arch/ppc/kernel/signal.c recently to handle process freezing seems to contain a dubious assumption: that a process that calls do_signal when PF_FREEZE is set will have entered the kernel because of a system call. This patch removes that assumption. Signed-off-by: Paul Mackerra...
```diff diff --git a/arch/ppc/kernel/signal.c b/arch/ppc/kernel/signal.c index 9567d3041ea7..645eae19805c 100644 --- a/arch/ppc/kernel/signal.c +++ b/arch/ppc/kernel/signal.c @@ -708,7 +708,6 @@ int do_signal(sigset_t *oldset, struct pt_regs *regs) if (current->flags & PF_FREEZE) { refrigerator(PF_FREEZE); sign...
7e5c6bc0a600c49e5922591ad41ff41987f54eb4
Analyze and fix the following issue in the Linux kernel code: [PATCH] irda_device() oops fix
Problem Details: Acked-by: "David S. Miller" <davem@davemloft.net> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/net/irda/irda_device.c b/net/irda/irda_device.c index fda299e300c0..9b9bb003c5a9 100644 --- a/net/irda/irda_device.c +++ b/net/irda/irda_device.c @@ -125,8 +125,15 @@ void irda_device_set_media_busy(struct net_device *dev, int status) self = (struct irlap_cb *) dev->atalk_ptr; - IRDA_ASSERT(s...
6775cab98b89b2caa10dce4b07e2c81999e45517
Analyze and fix the following issue in the Linux kernel code: [PATCH] Fix dst_destroy() race
Problem Details: When we are not the real parent of the dst (e.g., when we're xfrm_dst and the child is an rtentry), it may already be on the GC list. In fact the current code is buggy to, we need to check dst->flags before the dec as dst may no longer be valid afterwards. Signed-off-by: Herbert Xu <herbert@gondor.ap...
```diff diff --git a/net/core/dst.c b/net/core/dst.c index 3bf6cc434814..fc434ade5270 100644 --- a/net/core/dst.c +++ b/net/core/dst.c @@ -198,13 +198,15 @@ again: dst = child; if (dst) { + int nohash = dst->flags & DST_NOHASH; + if (atomic_dec_and_test(&dst->__refcnt)) { /* We were real parent of this ds...
2a27805127aee1e7e62854bcf9ca8c355c23b73e
Analyze and fix the following issue in the Linux kernel code: [PATCH] net: don't call kmem_cache_create with a spinlock held
Problem Details: This fixes the warning reported by Marcel Holtmann (Thanks!). Signed-off-by: Arnaldo Carvalho de Melo <acme@conectiva.com.br> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/net/core/sock.c b/net/core/sock.c index 629ab4a5b45b..f52c87a9268a 100644 --- a/net/core/sock.c +++ b/net/core/sock.c @@ -1359,8 +1359,6 @@ int proto_register(struct proto *prot, int alloc_slab) { int rc = -ENOBUFS; - write_lock(&proto_list_lock); - if (alloc_slab) { prot->slab = kmem_cac...
9f3786dc8b1d6229dbe76e364323f0d787e7a0ea
Analyze and fix the following issue in the Linux kernel code: [PATCH] Fix linux/atalk.h header
Problem Details: This recently got changed to include a lot of kernel internal stuff in the non-__KERNEL__ area of the header, which isn't so kosher and breaks libc builds. The fix is pretty simple. Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus ...
```diff diff --git a/include/linux/atalk.h b/include/linux/atalk.h index 55fcfc11fdc7..31d3fc25ccbd 100644 --- a/include/linux/atalk.h +++ b/include/linux/atalk.h @@ -1,8 +1,6 @@ #ifndef __LINUX_ATALK_H__ #define __LINUX_ATALK_H__ -#include <net/sock.h> - /* * AppleTalk networking structures * @@ -39,6 +37,10 ...
41aac24f8fb5a21ff3d0f6f56f85fad3cf0e88a9
Analyze and fix the following issue in the Linux kernel code: [PATCH] r128_state.c: break missing in switch statement
Problem Details: drm: fix r128_state.c switch statements.. in drivers/char/drm/r128_state.c (linux-2.6.12-rc2), some breaks are missing in the switch statement. See trivial fix below. Signed-off-by: Hansjoerg Lipp <hjlipp@web.de> Signed-off-by: Dave Airlie <airlied@linux.ie> Signed-off-by: Andrew Morton <akpm@osdl.o...
```diff diff --git a/drivers/char/drm/r128_state.c b/drivers/char/drm/r128_state.c index 38b3cbd0bbba..53af69162829 100644 --- a/drivers/char/drm/r128_state.c +++ b/drivers/char/drm/r128_state.c @@ -1549,12 +1549,16 @@ static int r128_cce_depth( DRM_IOCTL_ARGS ) switch ( depth.func ) { case R128_WRITE_SPAN: ret ...
388c69789a2a2e50965e805e3e641418082b352c
Analyze and fix the following issue in the Linux kernel code: [PATCH] SELinux: fix bug in Netlink message type detection
Problem Details: This patch fixes a bug in the SELinux Netlink message type detection code, where the wrong constant was being used in a case statement. The incorrect value is not valid for this class of object so it would not have been reached, and fallen through to a default handler for all Netlink messages. Signed...
```diff diff --git a/security/selinux/nlmsgtab.c b/security/selinux/nlmsgtab.c index fa7fa030e6eb..f79408252730 100644 --- a/security/selinux/nlmsgtab.c +++ b/security/selinux/nlmsgtab.c @@ -126,7 +126,7 @@ int selinux_nlmsg_lookup(u16 sclass, u16 nlmsg_type, u32 *perm) break; case SECCLASS_NETLINK_FIREWALL_SOCK...
1db7fc75a410d9a15cbc58a9b073a688669c6d42
Analyze and fix the following issue in the Linux kernel code: [PATCH] fix Bug 4395: modprobe bttv freezes the computer
Problem Details: ) From: Johannes Stezenbach <js@linuxtv.org> Fix http://bugme.osdl.org/show_bug.cgi?id=4395. Patch by Manu Abraham and Gerd Knorr: Remove redundant bttv_reset_audio() which caused the computer to freeze with some bt8xx based DVB cards when loading the bttv driver. Signed-off-by: Johannes Stezenba...
```diff diff --git a/drivers/media/video/bttv-cards.c b/drivers/media/video/bttv-cards.c index abce874e71cc..85224b90e394 100644 --- a/drivers/media/video/bttv-cards.c +++ b/drivers/media/video/bttv-cards.c @@ -2785,8 +2785,6 @@ void __devinit bttv_init_card2(struct bttv *btv) } btv->pll.pll_current = -1; ...
51410d3c53d85da0f24277f9580cbec1260ffc8f
Analyze and fix the following issue in the Linux kernel code: [PATCH] Fix get_compat_sigevent()
Problem Details: I have no idea how a bug like this lasted so long. Anyways, obvious memset()'ing of incorrect pointer. Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/kernel/compat.c b/kernel/compat.c index dad10656bf14..ddfcaaa86623 100644 --- a/kernel/compat.c +++ b/kernel/compat.c @@ -640,7 +640,7 @@ long compat_sys_clock_nanosleep(clockid_t which_clock, int flags, int get_compat_sigevent(struct sigevent *event, const struct compat_sigevent __user *u_even...
5df240826c90afdc7956f55a004ea6b702df9203
Analyze and fix the following issue in the Linux kernel code: [PATCH] fix crash in entry.S restore_all
Problem Details: Fix the access-above-bottom-of-stack crash. 1. Allows to preserve the valueable optimization 2. Works for NMIs 3. Doesn't care whether or not there are more of the like instances where the stack is left empty. 4. Seems to work for me without the crashes:) (akpm: this is still under discussion...
```diff diff --git a/arch/i386/kernel/entry.S b/arch/i386/kernel/entry.S index 1e45ff292bc9..3c73dc865ead 100644 --- a/arch/i386/kernel/entry.S +++ b/arch/i386/kernel/entry.S @@ -245,6 +245,9 @@ syscall_exit: restore_all: movl EFLAGS(%esp), %eax # mix EFLAGS, SS and CS + # Warning: OLDSS(%esp) contains the wrong/...
e493073d8d053429fbb42331b57a95dd0d61cadb
Analyze and fix the following issue in the Linux kernel code: [PATCH] Fix acl Oops
Problem Details: ) From: Andreas Gruenbacher <agruen@suse.de> ext[23]_get_acl will return an error when reading the attribute fails or out-of-memory occurs. Catch this case. Signed-off-by: Andreas Gruenbacher <agruen@suse.de> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl...
```diff diff --git a/fs/ext2/acl.c b/fs/ext2/acl.c index 8369ee8d28c4..25f4a64fd6bc 100644 --- a/fs/ext2/acl.c +++ b/fs/ext2/acl.c @@ -283,6 +283,8 @@ ext2_check_acl(struct inode *inode, int mask) { struct posix_acl *acl = ext2_get_acl(inode, ACL_TYPE_ACCESS); + if (IS_ERR(acl)) + return PTR_ERR(acl); if (acl) ...
9ffb7146f0aa9c0070cda3d8701b0a89e34913d1
Analyze and fix the following issue in the Linux kernel code: [PATCH] crypto: call zlib end functions on deflate exit path
Problem Details: In the deflate_[compress|uncompress|pcompress] functions we call the zlib_[in|de]flateReset function at the beginning. This is OK. But when we unload the deflate module we don't call zlib_[in|de]flateEnd to free all the zlib internal data. It looks like a bug for me. Please, consider the attached p...
```diff diff --git a/crypto/deflate.c b/crypto/deflate.c index 77d7655d316a..bc73342cd1ec 100644 --- a/crypto/deflate.c +++ b/crypto/deflate.c @@ -93,11 +93,13 @@ out_free: static void deflate_comp_exit(struct deflate_ctx *ctx) { + zlib_deflateEnd(&ctx->comp_stream); vfree(ctx->comp_stream.workspace); } stati...
7aa52f5128b06d1df9b2ee65c06d401af27da0a4
Analyze and fix the following issue in the Linux kernel code: [PATCH] arm: fix help text for ixdp465
Problem Details: ) From: Russell King <rmk+lkml@arm.linux.org.uk> For some reason, this help text was missed when the file was last audited by the documentation referencing folk. Fix this incorrect documentation reference. Signed-off-by: Russell King <rmk@arm.linux.org.uk> Signed-off-by: Andrew Morton <akpm@osdl.o...
```diff diff --git a/arch/arm/mach-ixp4xx/Kconfig b/arch/arm/mach-ixp4xx/Kconfig index aacb5f9200ea..89762a26495c 100644 --- a/arch/arm/mach-ixp4xx/Kconfig +++ b/arch/arm/mach-ixp4xx/Kconfig @@ -41,7 +41,7 @@ config MACH_IXDP465 help Say 'Y' here if you want your kernel to support Intel's IXDP465 Development ...
2d137c24e9f433e37ffd10b3d5f418157589a8d2
Analyze and fix the following issue in the Linux kernel code: [PATCH] arm: fix SIGBUS handling
Problem Details: ) From: Russell King <rmk+lkml@arm.linux.org.uk> ARM wasn't raising a SIGBUS with a siginfo structure. Fix __do_user_fault() to allow us to use it for SIGBUS conditions, and arrange for the sigbus path to use this. We need to prevent the siginfo code being called if we do not have a user space con...
```diff diff --git a/arch/arm/mm/fault.c b/arch/arm/mm/fault.c index 29be1c018949..e25b4fd8412c 100644 --- a/arch/arm/mm/fault.c +++ b/arch/arm/mm/fault.c @@ -108,14 +108,15 @@ __do_kernel_fault(struct mm_struct *mm, unsigned long addr, unsigned int fsr, */ static void __do_user_fault(struct task_struct *tsk, unsig...
baaa2c512dc1c47e3afeb9d558c5323c9240bd21
Analyze and fix the following issue in the Linux kernel code: [PATCH] Avoid deadlock in sync_page_io by using GFP_NOIO
Problem Details: ..as sync_page_io can be called on the write-out path. Signed-off-by: Neil Brown <neilb@cse.unsw.edu.au> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/drivers/md/md.c b/drivers/md/md.c index 04562add1920..aa72c88a024f 100644 --- a/drivers/md/md.c +++ b/drivers/md/md.c @@ -332,7 +332,7 @@ static int bi_complete(struct bio *bio, unsigned int bytes_done, int error) static int sync_page_io(struct block_device *bdev, sector_t sector, int size, ...
8d38eadb7a97f265f7b3a9e8a30df358c3a546c8
Analyze and fix the following issue in the Linux kernel code: [PATCH] mmtimer build fix
Problem Details: Signed-off-by: Christoph Lameter <clameter@sgi.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/drivers/char/mmtimer.c b/drivers/char/mmtimer.c index 58eddfdd3110..12006182f575 100644 --- a/drivers/char/mmtimer.c +++ b/drivers/char/mmtimer.c @@ -485,7 +485,7 @@ void mmtimer_tasklet(unsigned long data) { goto out; t->it_overrun = 0; - if (tasklist_lock.write_lock || posix_timer_event(t,...